[PATCH] Add package definition for GNU XaoS

[PATCH] Add package definition for GNU XaoS

[Fabian Harfert]

[-- Attachment #1: Type: text/plain, Size: 416 bytes --]

Hello,

this is my first contribution to this project.  I hope everything is
right with this package definition for GNU XaoS
(see https://www.gnu.org/software/xaos/).  It's a nice program to
discover fractals, so I decided to use it for my first packaging
attempt.

"guix-lint" worked fine and without error messages after I had
corrected some little things. Please let me know if something is wrong.

Fabian Harfert

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-XaoS.patch --]
[-- Type: text/x-patch, Size: 3451 bytes --]

From 6c9d69a42e1a54951a2ba0f9cedf67bec67c739e Mon Sep 17 00:00:00 2001
From: Fabian Harfert <fhmgufs@web.de>
Date: Mon, 14 Dec 2015 21:53:58 +0100
Subject: [PATCH] gnu: Add XaoS.

* gnu/packages/xaos.scm: New file.
* gnu-system.am (GNU_SYSTEM_MODULES): Add it.
---
 gnu-system.am         |  1 +
 gnu/packages/xaos.scm | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)
 create mode 100644 gnu/packages/xaos.scm

diff --git a/gnu-system.am b/gnu-system.am
index 77a8b2e..1abce66 100644
--- a/gnu-system.am
+++ b/gnu-system.am
@@ -340,6 +340,7 @@ GNU_SYSTEM_MODULES =				\
   gnu/packages/wordnet.scm			\
   gnu/packages/wv.scm				\
   gnu/packages/wxwidgets.scm			\
+  gnu/packages/xaos.scm             \
   gnu/packages/xfig.scm				\
   gnu/packages/xiph.scm				\
   gnu/packages/xml.scm				\
diff --git a/gnu/packages/xaos.scm b/gnu/packages/xaos.scm
new file mode 100644
index 0000000..70183a2
--- /dev/null
+++ b/gnu/packages/xaos.scm
@@ -0,0 +1,57 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2015 Fabian Harfert <fhmgufs@web.de>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages xaos)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (gnu packages gettext)
+  #:use-module (gnu packages xorg)
+  #:use-module (gnu packages compression)
+  #:use-module (gnu packages image)
+  #:use-module (gnu packages maths))
+
+(define-public xaos
+  (package
+    (name "xaos")
+    (version "3.6")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
+                                  ".tar.gz"))
+              (sha256
+               (base32
+                "15cd1cx1dyygw6g2nhjqq3bsfdj8sj8m4va9n75i0f3ryww3x7wq"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("gettext", gnu-gettext)))
+    (inputs `(("libx11" ,libx11)
+              ("zlib" ,zlib)
+              ("libpng" ,libpng)
+              ("gsl" ,gsl)))
+    (arguments
+     `(#:tests? #f ;no "check" target
+       #:make-flags '("LOCALEDIR=$DATAROOTDIR/locale")))
+    (synopsis "Real-time fractal zoomer")
+    (description "GNU XaoS is a graphical program that generates fractal patterns and
+allows you to zoom in and out of them infinitely in a fluid, continuous
+manner.  It also includes tutorials that help to explain how fractals are
+built.  It can generate many different fractal types such as the Mandelbrot
+set.")
+    (home-page "http://www.gnu.org/software/xaos/")
+    (license license:gpl2+)))
-- 
2.1.4

Re: [PATCH] Add package definition for GNU XaoS

[Leo Famulari]

On Mon, Dec 14, 2015 at 10:01:39PM +0100, Fabian Harfert wrote:
> Hello,
> 
> this is my first contribution to this project.  I hope everything is
> right with this package definition for GNU XaoS
> (see https://www.gnu.org/software/xaos/).  It's a nice program to
> discover fractals, so I decided to use it for my first packaging
> attempt.

This program is a lot of fun!

> +    (license license:gpl2+)))

Some of the files say "GPL 2 or later" and some say "GPL 3 or later".
What's the typical way to denote that in the license field?

Otherwise, looks good to me!

Re: [PATCH] Add package definition for GNU XaoS

[Andreas Enge]

Hello,

I think it would make sense to add it to maths.scm, to avoid the profusion
of modules.

> +              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
> +                                  ".tar.gz"))

It is not available on the GNU ftp server?

Andreas

Re: [PATCH] Add package definition for GNU XaoS

[Alex Kost]

Andreas Enge (2015-12-15 10:22 +0300) wrote:

> Hello,
>
> I think it would make sense to add it to maths.scm, to avoid the profusion
> of modules.
>
>> +              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
>> +                                  ".tar.gz"))
>
> It is not available on the GNU ftp server?

There is <http://ftp.gnu.org/pub/gnu/xaos/> but it has a very old version.

-- 
Alex

Re: [PATCH] Add package definition for GNU XaoS

[Alex Kost]

Fabian Harfert (2015-12-15 00:01 +0300) wrote:

> Hello,
>
> this is my first contribution to this project.  I hope everything is
> right with this package definition for GNU XaoS
> (see https://www.gnu.org/software/xaos/).  It's a nice program to
> discover fractals, so I decided to use it for my first packaging
> attempt.

Hello, great attempt!  And thank you for showing this awesome program!
I didn't know about it.

[...]
> +(define-public xaos
> +  (package
> +    (name "xaos")
> +    (version "3.6")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
> +                                  ".tar.gz"))
> +              (sha256
> +               (base32
> +                "15cd1cx1dyygw6g2nhjqq3bsfdj8sj8m4va9n75i0f3ryww3x7wq"))))
> +    (build-system gnu-build-system)
> +    (native-inputs `(("gettext", gnu-gettext)))
It should be:         `(("gettext" ,gnu-gettext))
                                  ^^

> +    (inputs `(("libx11" ,libx11)
> +              ("zlib" ,zlib)
> +              ("libpng" ,libpng)
> +              ("gsl" ,gsl)))
> +    (arguments
> +     `(#:tests? #f ;no "check" target
> +       #:make-flags '("LOCALEDIR=$DATAROOTDIR/locale")))
> +    (synopsis "Real-time fractal zoomer")
> +    (description "GNU XaoS is a graphical program that generates fractal patterns and

Please do not make such long lines, we stay within 80 columns (I
personally prefer to stay within 72 if possible).

> +allows you to zoom in and out of them infinitely in a fluid, continuous
> +manner.  It also includes tutorials that help to explain how fractals are
> +built.  It can generate many different fractal types such as the Mandelbrot
> +set.")
> +    (home-page "http://www.gnu.org/software/xaos/")
> +    (license license:gpl2+)))

Otherwise, the patch looks good to me, so if there will be no other
comments I'll push it soon.

-- 
Alex

Re: [PATCH] Add package definition for GNU XaoS

[Alex Kost]

Leo Famulari (2015-12-15 01:58 +0300) wrote:

> On Mon, Dec 14, 2015 at 10:01:39PM +0100, Fabian Harfert wrote:
>> Hello,
>> 
>> this is my first contribution to this project.  I hope everything is
>> right with this package definition for GNU XaoS
>> (see https://www.gnu.org/software/xaos/).  It's a nice program to
>> discover fractals, so I decided to use it for my first packaging
>> attempt.
>
> This program is a lot of fun!
>
>> +    (license license:gpl2+)))
>
> Some of the files say "GPL 2 or later" and some say "GPL 3 or later".
> What's the typical way to denote that in the license field?

I think we can just use a list with 2 licenses, but I didn't find GPL3
in the source code, what files do you mean?

-- 
Alex

[PATCH] Add package definition for GNU XaoS.

[Fabian Harfert]

[-- Attachment #1: Type: text/plain, Size: 203 bytes --]

Hello,

here's the new patch for GNU XaoS, I added it to maths.scm, fixed the
("gettext" ,gnu-gettext) thing but didn't add gpl3+ to the licenses
because I couldn't find any file with it.

Fabian Harfert

[-- Attachment #2: 0001-Add-package-definition-for-GNU-XaoS.patch --]
[-- Type: text/x-patch, Size: 2231 bytes --]

From 7c3a50c184745dcf2fb0b81ad30a629739ddf8d0 Mon Sep 17 00:00:00 2001
From: Fabian Harfert <fhmgufs@web.de>
Date: Tue, 15 Dec 2015 20:43:55 +0100
Subject: [PATCH] Add package definition for GNU XaoS.

* gnu/packages/maths.scm (xaos): Add package definition for GNU XaoS.
---
 gnu/packages/maths.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 0c0f013..a288291 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -53,6 +53,7 @@
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages less)
   #:use-module (gnu packages lisp)
   #:use-module (gnu packages gnome)
@@ -1991,3 +1992,32 @@ variables, a command history, hex/octal/binary input and output, unit
 conversions, embedded comments, and an expandable expression entry field.  It
 evaluates expressions using the standard order of operations.")
     (license license:gpl2+)))
+
+(define-public xaos
+  (package
+    (name "xaos")
+    (version "3.6")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
+                                  ".tar.gz"))
+              (sha256
+                (base32
+                  "15cd1cx1dyygw6g2nhjqq3bsfdj8sj8m4va9n75i0f3ryww3x7wq"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("gettext" ,gnu-gettext)))
+    (inputs `(("libx11" ,libx11)
+              ("zlib" ,zlib)
+              ("libpng" ,libpng)
+              ("gsl" ,gsl)))
+    (arguments
+     `(#:tests? #f ;no "check" target
+       #:make-flags '("LOCALEDIR=$DATAROOTDIR/locale")))
+    (synopsis "Real-time fractal zoomer")
+    (description "GNU XaoS is a graphical program that generates fractal
+patterns and allows you to zoom in and out of them infinitely in a fluid,
+continuous manner.  It also includes tutorials that help to explain how fractals
+are built.  It can generate many different fractal types such as the Mandelbrot
+set.")
+    (home-page "http://www.gnu.org/software/xaos/")
+    (license license:gpl2+)))
-- 
2.1.4

Re: [PATCH] Add package definition for GNU XaoS.

[Fabian Harfert]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

Am Tue, 15 Dec 2015 20:51:44 +0100
schrieb Fabian Harfert <fhmgufs@web.de>:

Excuse me, I've forgotten to add the copyright.

> Hello,
> 
> here's the new patch for GNU XaoS, I added it to maths.scm, fixed the
> ("gettext" ,gnu-gettext) thing but didn't add gpl3+ to the licenses
> because I couldn't find any file with it.
> 
> Fabian Harfert

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-package-definition-for-GNU-XaoS.patch --]
[-- Type: text/x-patch, Size: 2515 bytes --]

From 6687ea7c21725bdc13e368773d5c7576a43db14e Mon Sep 17 00:00:00 2001
From: Fabian Harfert <fhmgufs@web.de>
Date: Tue, 15 Dec 2015 21:00:38 +0100
Subject: [PATCH] Add package definition for GNU XaoS.

---
 gnu/packages/maths.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 0c0f013..181809c 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
 ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
 ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
+;;; Copyright © 2015 Fabian Harfert <fhmgufs@web.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -53,6 +54,7 @@
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gtk)
+  #:use-module (gnu packages image)
   #:use-module (gnu packages less)
   #:use-module (gnu packages lisp)
   #:use-module (gnu packages gnome)
@@ -1991,3 +1993,32 @@ variables, a command history, hex/octal/binary input and output, unit
 conversions, embedded comments, and an expandable expression entry field.  It
 evaluates expressions using the standard order of operations.")
     (license license:gpl2+)))
+
+(define-public xaos
+  (package
+    (name "xaos")
+    (version "3.6")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/xaos/xaos-" version
+                                  ".tar.gz"))
+              (sha256
+                (base32
+                  "15cd1cx1dyygw6g2nhjqq3bsfdj8sj8m4va9n75i0f3ryww3x7wq"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("gettext" ,gnu-gettext)))
+    (inputs `(("libx11" ,libx11)
+              ("zlib" ,zlib)
+              ("libpng" ,libpng)
+              ("gsl" ,gsl)))
+    (arguments
+     `(#:tests? #f ;no "check" target
+       #:make-flags '("LOCALEDIR=$DATAROOTDIR/locale")))
+    (synopsis "Real-time fractal zoomer")
+    (description "GNU XaoS is a graphical program that generates fractal
+patterns and allows you to zoom in and out of them infinitely in a fluid,
+continuous manner.  It also includes tutorials that help to explain how fractals
+are built.  It can generate many different fractal types such as the Mandelbrot
+set.")
+    (home-page "http://www.gnu.org/software/xaos/")
+    (license license:gpl2+)))
-- 
2.1.4

Re: [PATCH] Add package definition for GNU XaoS

[Leo Famulari]

On Tue, Dec 15, 2015, at 14:24, Alex Kost wrote:
> Leo Famulari (2015-12-15 01:58 +0300) wrote:
> 
> > On Mon, Dec 14, 2015 at 10:01:39PM +0100, Fabian Harfert wrote:
> >> Hello,
> >> 
> >> this is my first contribution to this project.  I hope everything is
> >> right with this package definition for GNU XaoS
> >> (see https://www.gnu.org/software/xaos/).  It's a nice program to
> >> discover fractals, so I decided to use it for my first packaging
> >> attempt.
> >
> > This program is a lot of fun!
> >
> >> +    (license license:gpl2+)))
> >
> > Some of the files say "GPL 2 or later" and some say "GPL 3 or later".
> > What's the typical way to denote that in the license field?
> 
> I think we can just use a list with 2 licenses, but I didn't find GPL3
> in the source code, what files do you mean?

You're right. I did `grep -rIi gpl` and didn't notice that all of the
GPL 3 results were describing the licenses of the dependencies.

> 
> -- 
> Alex

Re: [PATCH] Add package definition for GNU XaoS

[Leo Famulari]

On Tue, Dec 15, 2015 at 10:24:15PM +0300, Alex Kost wrote:
> Fabian Harfert (2015-12-15 00:01 +0300) wrote:
> > +    (description "GNU XaoS is a graphical program that generates fractal patterns and
> 
> Please do not make such long lines, we stay within 80 columns (I
> personally prefer to stay within 72 if possible).

I'm surprised that `guix lint` doesn't complain about this...

Re: [PATCH] Add package definition for GNU XaoS

[Andreas Enge]

On Tue, Dec 15, 2015 at 10:23:52PM +0300, Alex Kost wrote:
> There is <http://ftp.gnu.org/pub/gnu/xaos/> but it has a very old version.

Maybe it would make sense to kindly remind them to put their releases
on ftp.gnu.org. That would also allow us to be notified of updates
(which could be used as an argument).

Fabian, since you have a special interest in the program, would you like
to do this?

Andreas

Re: [PATCH] Add package definition for GNU XaoS

[Fabian Harfert]

Am Wed, 16 Dec 2015 02:48:25 +0100
schrieb Andreas Enge <andreas@enge.fr>:

> On Tue, Dec 15, 2015 at 10:23:52PM +0300, Alex Kost wrote:
> > There is <http://ftp.gnu.org/pub/gnu/xaos/> but it has a very old
> > version.
> 
> Maybe it would make sense to kindly remind them to put their releases
> on ftp.gnu.org. That would also allow us to be notified of updates
> (which could be used as an argument).
> 
> Fabian, since you have a special interest in the program, would you
> like to do this?
> 
> Andreas
> 

I couldn't get information about who's the maintainer of GNU XaoS for
GNU, but I have sent a mail to the person who owns the GitHub
repository.

Fabian

Re: [PATCH] Add package definition for GNU XaoS

[Mark H Weaver]

Fabian Harfert <fhmgufs@web.de> writes:

> Am Wed, 16 Dec 2015 02:48:25 +0100
> schrieb Andreas Enge <andreas@enge.fr>:
>
>> On Tue, Dec 15, 2015 at 10:23:52PM +0300, Alex Kost wrote:
>> > There is <http://ftp.gnu.org/pub/gnu/xaos/> but it has a very old
>> > version.
>> 
>> Maybe it would make sense to kindly remind them to put their releases
>> on ftp.gnu.org. That would also allow us to be notified of updates
>> (which could be used as an argument).
>> 
>> Fabian, since you have a special interest in the program, would you
>> like to do this?
>> 
>> Andreas
>> 
>
> I couldn't get information about who's the maintainer of GNU XaoS for
> GNU, but I have sent a mail to the person who owns the GitHub
> repository.

According to GNU's records, Zoltan Kovacs <kovzol@gmail.com> is the
maintainer of Xaos.

      Mark

Re: [PATCH] Add package definition for GNU XaoS.

[Alex Kost]

Andreas Enge (2015-12-16 04:48 +0300) wrote:

> Maybe it would make sense to kindly remind them to put their releases
> on ftp.gnu.org. That would also allow us to be notified of updates
> (which could be used as an argument).

I was going to commit this patch but now I don't know: should we wait
for a reply from the maintainers about updating xaos release on gnu.org?
Or maybe push this patch now, and change the origin URL later (if there
will be a response)?

Fabian Harfert (2015-12-15 23:02 +0300) wrote:

[...]
> From 6687ea7c21725bdc13e368773d5c7576a43db14e Mon Sep 17 00:00:00 2001
> From: Fabian Harfert <fhmgufs@web.de>
> Date: Tue, 15 Dec 2015 21:00:38 +0100
> Subject: [PATCH] Add package definition for GNU XaoS.

Our convention is to use the following commit message:

--8<---------------cut here---------------start------------->8---
gnu: Add xaos.

* gnu/packages/maths.scm (xaos): New variable.
--8<---------------cut here---------------end--------------->8---

> ---
>  gnu/packages/maths.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 0c0f013..181809c 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2015 Sou Bunnbu <iyzsong@gmail.com>
>  ;;; Copyright © 2015 Mark H Weaver <mhw@netris.org>
>  ;;; Copyright © 2015 Efraim Flashner <efraim@flashner.co.il>
> +;;; Copyright © 2015 Fabian Harfert <fhmgufs@web.de>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -53,6 +54,7 @@
>    #:use-module (gnu packages ghostscript)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)

Our (gnu packages image) module uses (gnu packages maths).  I wouldn't
add this circularity, I think it was better to have xaos in a separate
module.  But actually I don't know if it's a real issue and what our
policy on such things is.  I hope more experienced guix/guile people
will tell if we should avoid such circularities.

-- 
Alex

Re: [PATCH] Add package definition for GNU XaoS.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Andreas Enge (2015-12-16 04:48 +0300) wrote:
>
>> Maybe it would make sense to kindly remind them to put their releases
>> on ftp.gnu.org. That would also allow us to be notified of updates
>> (which could be used as an argument).
>
> I was going to commit this patch but now I don't know: should we wait
> for a reply from the maintainers about updating xaos release on gnu.org?
> Or maybe push this patch now, and change the origin URL later (if there
> will be a response)?

No, this shouldn’t be blocking packaging.  (It’s really a thankless side
activity of trying to get GNU maintainers to follow GNU conventions. ;-))

Ludo’.

Re: [PATCH] Add package definition for GNU XaoS.

[Alex Kost]

Alex Kost (2015-12-21 15:42 +0300) wrote:

> Fabian Harfert (2015-12-15 23:02 +0300) wrote:
>
> [...]
>> @@ -53,6 +54,7 @@
>>    #:use-module (gnu packages ghostscript)
>>    #:use-module (gnu packages glib)
>>    #:use-module (gnu packages gtk)
>> +  #:use-module (gnu packages image)
>
> Our (gnu packages image) module uses (gnu packages maths).  I wouldn't
> add this circularity, I think it was better to have xaos in a separate
> module.  But actually I don't know if it's a real issue and what our
> policy on such things is.  I hope more experienced guix/guile people
> will tell if we should avoid such circularities.

Sorry for bumping, just to prevent this package from burying in ML.

Originally Fabian sent a patch for separate "xaos.scm" file.  Then
Andreas suggested to move it to "maths.scm".  But this will lead to the
mentioned circularity:
  (gnu packages image) already uses (gnu packages maths)
and after this patch:
  (gnu packages maths) will use (gnu packages image).

Is it OK to leave it like this, or should 'xaos' be left in a
separate file?

-- 
Alex

Re: [PATCH] Add package definition for GNU XaoS.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Alex Kost (2015-12-21 15:42 +0300) wrote:
>
>> Fabian Harfert (2015-12-15 23:02 +0300) wrote:
>>
>> [...]
>>> @@ -53,6 +54,7 @@
>>>    #:use-module (gnu packages ghostscript)
>>>    #:use-module (gnu packages glib)
>>>    #:use-module (gnu packages gtk)
>>> +  #:use-module (gnu packages image)
>>
>> Our (gnu packages image) module uses (gnu packages maths).  I wouldn't
>> add this circularity, I think it was better to have xaos in a separate
>> module.  But actually I don't know if it's a real issue and what our
>> policy on such things is.  I hope more experienced guix/guile people
>> will tell if we should avoid such circularities.
>
> Sorry for bumping, just to prevent this package from burying in ML.
>
> Originally Fabian sent a patch for separate "xaos.scm" file.  Then
> Andreas suggested to move it to "maths.scm".  But this will lead to the
> mentioned circularity:
>   (gnu packages image) already uses (gnu packages maths)
> and after this patch:
>   (gnu packages maths) will use (gnu packages image).
>
> Is it OK to leave it like this, or should 'xaos' be left in a
> separate file?

It’s OK to leave it as is.

Module circularity are not a problem, unless there are circular
*top-level* references.

That is, if maths.scm does, say:

  (define foo libpng)

and image.scm does:

  (define bar lapack)

then we have a problem.

Ludo’.

Re: [PATCH] Add package definition for GNU XaoS.

[Alex Kost]

Alex Kost (2015-12-21 15:42 +0300) wrote:

> Fabian Harfert (2015-12-15 23:02 +0300) wrote:
>
> [...]
>> From 6687ea7c21725bdc13e368773d5c7576a43db14e Mon Sep 17 00:00:00 2001
>> From: Fabian Harfert <fhmgufs@web.de>
>> Date: Tue, 15 Dec 2015 21:00:38 +0100
>> Subject: [PATCH] Add package definition for GNU XaoS.
>
> Our convention is to use the following commit message:
>
> gnu: Add xaos.
>
> * gnu/packages/maths.scm (xaos): New variable.

I have changed the commit message and pushed this patch.  Thanks! and
sorry for the long delay.

-- 
Alex

Re: [PATCH] Add package definition for GNU XaoS.

[Alex Kost]

Ludovic Courtès (2015-12-30 18:51 +0300) wrote:

> Alex Kost <alezost@gmail.com> skribis:
[...]
>> Originally Fabian sent a patch for separate "xaos.scm" file.  Then
>> Andreas suggested to move it to "maths.scm".  But this will lead to the
>> mentioned circularity:
>>   (gnu packages image) already uses (gnu packages maths)
>> and after this patch:
>>   (gnu packages maths) will use (gnu packages image).
>>
>> Is it OK to leave it like this, or should 'xaos' be left in a
>> separate file?
>
> It’s OK to leave it as is.
>
> Module circularity are not a problem, unless there are circular
> *top-level* references.

Great!  Though I believe it's preferable to avoid module circularities
if possible, right?

> That is, if maths.scm does, say:
>
>   (define foo libpng)
>
> and image.scm does:
>
>   (define bar lapack)
>
> then we have a problem.

Thanks for the explanation!

-- 
Alex

Re: [PATCH] Add package definition for GNU XaoS.

[Ludovic Courtès]

Alex Kost <alezost@gmail.com> skribis:

> Ludovic Courtès (2015-12-30 18:51 +0300) wrote:
>
>> Alex Kost <alezost@gmail.com> skribis:
> [...]
>>> Originally Fabian sent a patch for separate "xaos.scm" file.  Then
>>> Andreas suggested to move it to "maths.scm".  But this will lead to the
>>> mentioned circularity:
>>>   (gnu packages image) already uses (gnu packages maths)
>>> and after this patch:
>>>   (gnu packages maths) will use (gnu packages image).
>>>
>>> Is it OK to leave it like this, or should 'xaos' be left in a
>>> separate file?
>>
>> It’s OK to leave it as is.
>>
>> Module circularity are not a problem, unless there are circular
>> *top-level* references.
>
> Great!  Though I believe it's preferable to avoid module circularities
> if possible, right?

Yes, but it’s also hard, unless there’s one package per module.

Ludo’.