From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data. Date: Wed, 9 Dec 2015 16:26:32 -0500 Message-ID: <20151209212632.GC1835@jasmine> References: <87fuzcsvt1.fsf@gnu.org> <87wpsnsp8x.fsf@gnu.org> <87y4d31p24.fsf@gnu.org> <87zixjl4w8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35362) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6mFt-0007vx-W0 for guix-devel@gnu.org; Wed, 09 Dec 2015 16:26:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a6mFp-0001UM-0Q for guix-devel@gnu.org; Wed, 09 Dec 2015 16:26:33 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a6mFo-0001U8-Si for guix-devel@gnu.org; Wed, 09 Dec 2015 16:26:28 -0500 Content-Disposition: inline In-Reply-To: <87zixjl4w8.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel On Wed, Dec 09, 2015 at 09:54:15PM +0100, Ludovic Courtès wrote: > Mathieu Lirzin skribis: > > > ludo@gnu.org (Ludovic Courtès) writes: > > > >> Otherwise LGTM. It’s great that you fixed this! People had reported > >> the issue on IRC, so that’ll make them happy! :-) > > > > I think this is only a partial fix. to launch emacsclient I still need > > to do this: > > > > TERMINFO="$HOME/.guix-profile/share/terminfo" emacsclient --tty foo > > > > in terminfo(5), we can read this: > > [...] > > > I suppose that "system terminfo directory" is set to > > /gnu/store/...-ncurses-6.0 and IIUC correctly this is the only place > > automatically searched. What about adding TERMINFO_DIRS in > > "$HOME/.guix-profile/etc/profile"? I think TERMINFO_DIRS is more > > appropriate than TERMINFO because it let the possibility for non-GuixSD > > users to have multiple directories in it. > > Indeed, sounds good. > > > From eedb9ca34c5bbc973765c8bd8a17b0a42c98e427 Mon Sep 17 00:00:00 2001 > > From: Mathieu Lirzin > > Date: Sun, 6 Dec 2015 21:58:03 +0100 > > Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data. > > > > This sets the destination when installing the necessary terminal > > capability data, which are not provided by ncurses. See > > https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html > > > > * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses. > > [arguments]: Set the destination of the terminfo files. > > [native-search-path]: New field. Make them automatically available to > > the user. > > [...] > > > + (native-search-paths > > + (list (search-path-specification > > + (variable "TERMINFO_DIRS") > > + (files '("share/terminfo"))))) > > This should be in the ncurses package itself, since it is “owned” by > ncurses, not rxvt. > > However, there’s the limitation that, currently, --search-paths > advertises the variables of things that are explicitly in the profile. > Ncurses is usually not in the profile; it is a dependency of something > that is in the profile. Thus, people wouldn’t see anything about > TERMINFO_DIRS in practice (we have the same problem with OpenSSL, > GStreamer, and other librairies that have associated variables.) > > Long story short, I would avoid adding this ‘native-search-paths’ here, > but I’m OK with it since that would make the thing usable, provided > there’s a big FIXME in there. > > WDYT? Since the linked discussion is from 2009, maybe somebody should again try to politely submit the patch upstream. > > Ludo’. >