From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: swh-plugins-lv2: New variable [WIP] v2
Date: Wed, 9 Dec 2015 15:04:05 -0500
Message-ID: <20151209200405.GA19108@jasmine>
References: <5664BA45.3080600@gmx.net> <5664BB8C.6030100@gmx.net>
	<87wpsqm00d.fsf@elephly.net> <87r3ixzifw.fsf@netris.org>
	<87y4d59vap.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1a6ky8-0001yo-Cc
	for guix-devel@gnu.org; Wed, 09 Dec 2015 15:04:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1a6ky3-0003GU-Lg
	for guix-devel@gnu.org; Wed, 09 Dec 2015 15:04:08 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47544)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1a6ky3-0003GJ-Ff
	for guix-devel@gnu.org; Wed, 09 Dec 2015 15:04:03 -0500
Content-Disposition: inline
In-Reply-To: <87y4d59vap.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel@gnu.org

On Tue, Dec 08, 2015 at 09:52:30AM +0100, Ludovic Courtès wrote:
> Mark H Weaver <mhw@netris.org> skribis:
> 
> > Ricardo Wurmus <rekado@elephly.net> writes:
> >
> >>> +(define-public swh-plugins-lv2
> >>> +  (let ((commit "5098e09e255eaed14e0d40ca5e7e6dfcb782d7ea"))
> >>
> >> We usually don’t use full commit hashes.  You could probably trim it to
> >> the first six characters or so.
> >
> > I would recommend using at least 10 characters, maybe more.  We should
> > use enough characters to ensure that the commit id remains unique for as
> > long as this package version remains in use -- keeping in mind that for
> > purposes of reproducing old experiments, someone might try to build this
> > package+version several years from now.
> 
> I sympathize with this.  I would think 10 digits is more than needed,
> though: With 6 hex digits, it takes on average 16^6 = 16M commits before
> the 6-digit ID is ambiguous, and with 8 hex digits that goes to
> 4 billion commits (Emacs has around 123,000 commits as an example.)
> 
> But anyway, to be super-safe, we could use the full SHA1 in the URL, but
> strip it in the ‘version’ field so that it remains readable.
> 
> Thoughts?

I don't see a reason to not use the full hash. I know the odds but why
discard the information? We can't complain about it being ugly given the
aesthetics of /gnu/store. ;)

> 
> Thanks,
> Ludo’.
>