Re: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.

[Leo Famulari <leo@famulari.name>]

On Tue, Dec 08, 2015 at 06:18:50PM +0100, Mathieu Lirzin wrote:
> From 00d45cdc47bd0d031d0870155e24fa814dad4833 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <mthl@gnu.org>
> Date: Sun, 6 Dec 2015 21:58:03 +0100
> Subject: [PATCH] gnu: rxvt-unicode: Add the terminal capability data.
> 
> This adds the necessary terminal capability data which are not provided
> by Ncurses due to a personal conflict between the respective
> maintainers.  See
> https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.
> 
> * gnu/packages/xdisorg.scm (rxvt-unicode)[native-inputs]: Add ncurses.
> [arguments]: Set the destination of the terminfo files.
> ---
>  gnu/packages/xdisorg.scm | 30 ++++++++++++++++++------------
>  1 file changed, 18 insertions(+), 12 deletions(-)
> 
> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index 4b5308c..df8aa99 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -40,6 +40,7 @@
>    #:use-module (gnu packages gettext)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gnome)               ;for libgudev
> +  #:use-module (gnu packages ncurses)
>    #:use-module (gnu packages perl)
>    #:use-module (gnu packages python)
>    #:use-module (gnu packages linux)
> @@ -529,23 +530,28 @@ compact configuration syntax.")
>    (package
>      (name "rxvt-unicode")
>      (version "9.21")
> -    (source
> -      (origin
> -        (method url-fetch)
> -        (uri (string-append
> -              "http://dist.schmorp.de/rxvt-unicode/"
> -              name "-"
> -              version
> -              ".tar.bz2"))
> -        (sha256
> -          (base32
> -            "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://dist.schmorp.de/rxvt-unicode/"
> +                                  name "-" version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "0swmi308v5yxsddrdhvi4cch88k2bbs2nffpl5j5m2f55gbhw9vm"))))
>      (build-system gnu-build-system)
> +    (arguments
> +     ;; This sets the destination when installing the necessary terminal
> +     ;; capability data which are not provided by Ncurses due to a personal
> +     ;; conflict between the respective maintainers.  See
> +     ;; https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html.

I think it's best not to describe the issue in these terms in the
codebase. I don't know the situation, but if it is as you say, I think
it will never get better as things like this "cement" the conflict in
source code. Also, ncurses seems to be capitalized only at the beginning
of a sentence. How about this:

This sets the destination when installing the necessary terminal
capability data, which are not provided by ncurses. See
https://lists.gnu.org/archive/html/bug-ncurses/2009-10/msg00031.html

> +     '(#:make-flags (list (string-append "TERMINFO="
> +                                         (assoc-ref %outputs "out")
> +                                         "/share/terminfo"))))
>      (inputs
>       `(("libXft" ,libxft)
>         ("libX11" ,libx11)))
>      (native-inputs
> -     `(("perl" ,perl)
> +     `(("ncurses" ,ncurses)         ;trigger the installation of terminfo data
> +       ("perl" ,perl)
>         ("pkg-config" ,pkg-config)))
>      (home-page "http://software.schmorp.de/pkg/rxvt-unicode.html")
>      (synopsis "Rxvt clone with XFT and unicode support")
> -- 
> 2.6.3
> 
>