Re: [PATCH 10/10] gnu: Add git-annex-remote-hubic.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1.1: Type: text/plain, Size: 2432 bytes --]

On Fri, 4 Dec 2015 10:57:27 +0100
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > +(define-public git-annex-remote-hubic
> > +  (package
> > +    (name "git-annex-remote-hubic")
> > +    (version "0.3.1")
> > +    (source (origin
> > +              (method url-fetch)
> > +              (uri (string-append
> > +                    "https://github.com/Schnouki/" name "/archive/v"
> > +                    version ".tar.gz"))
> > +              (file-name (string-append name "-" version))  
> 
> You should also append “.tar.gz”.
> 
> > +              (sha256
> > +               (base32
> > +                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
> > +    (build-system python-build-system)
> > +    (arguments
> > +     `(#:python ,python-2))
> > +    (native-inputs
> > +    `(("python2-setuptools" ,python2-setuptools)
> > +      ;; some extras for the tests
> > +      ("python2-futures" ,python2-futures)
> > +      ("python2-six" ,python2-six)))
> > +    (inputs
> > +     `(("python2-dateutil" ,python2-dateutil)
> > +       ("python2-rauth" ,python2-rauth)
> > +       ("python2-swiftclient" ,python2-swiftclient)))  
> 
> These are probably propagated-inputs.
> 
> > +    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
> > +    (synopsis "Use hubic as a git-annex remote")  
> 
> I don’t know what “hubic” is but in the description you spell it as
> “hubiC”.  Which spelling is correct?

hubic.com is one of those free online storage places, and in their image they
spell it "hubiC," but it's unlikely people will search for it like that, so
I've made them all "hubic."

> 
> > +    (description
> > +     "Git annex remote hubic allows you to use your hubiC account as a \"special
> > +repository\".")  
> 
> I found it difficult to read this description because the first four
> words are actually the name of the package.  In this case I’d suggest
> replacing “Git annex remote hubic” with the generic “This package”; but
> then you should also add “with git-annex” after “special repository”.
> 
> ~~ Ricardo



-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0010-gnu-Add-git-annex-remote-hubic.patch --]
[-- Type: text/x-patch, Size: 2400 bytes --]

From 88877256de8eaa36fa87a99ed433b2c65663a972 Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Mon, 30 Nov 2015 20:55:01 +0200
Subject: [PATCH 10/10] gnu: Add git-annex-remote-hubic.

* gnu/packages/version-control.scm (git-annex-remote-hubic): New variable.
---
 gnu/packages/version-control.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 6861e35..d5d95f7 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -54,6 +54,7 @@
   #:use-module (gnu packages ncurses)
   #:use-module (gnu packages ssh)
   #:use-module (gnu packages web)
+  #:use-module (gnu packages openstack)
   #:use-module (gnu packages perl)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
@@ -983,3 +984,35 @@ fetching updates) over a collection of version control repositories.  It
 supports a large number of version control systems: Git, Subversion,
 Mercurial, Bazaar, Darcs, CVS, Fossil, and Veracity.")
     (license gpl2+)))
+
+(define-public git-annex-remote-hubic
+  (package
+    (name "git-annex-remote-hubic")
+    (version "0.3.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/Schnouki/" name "/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2))
+    (native-inputs
+    `(("python2-setuptools" ,python2-setuptools)
+      ;; some extras for the tests
+      ("python2-futures" ,python2-futures)
+      ("python2-six" ,python2-six)))
+    (propagated-inputs
+     `(("python2-dateutil" ,python2-dateutil)
+       ("python2-rauth" ,python2-rauth)
+       ("python2-swiftclient" ,python2-swiftclient)))
+    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/")
+    (synopsis "Use hubic as a git-annex remote")
+    (description
+     "This package allows you to use your hubic account as a \"special
+repository\" with git-annex.")
+    (license gpl3+)))
-- 
2.6.2


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]