From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add docopt.
Date: Thu, 3 Dec 2015 14:31:29 -0500
Message-ID: <20151203193129.GA22316@jasmine>
References: <1449123849-13644-1-git-send-email-kyle@kyleam.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43583)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1a4ZbO-0005x5-Ju
	for guix-devel@gnu.org; Thu, 03 Dec 2015 14:31:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1a4ZbK-0001XT-EF
	for guix-devel@gnu.org; Thu, 03 Dec 2015 14:31:38 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1a4ZbK-0001Wp-8L
	for guix-devel@gnu.org; Thu, 03 Dec 2015 14:31:34 -0500
Content-Disposition: inline
In-Reply-To: <1449123849-13644-1-git-send-email-kyle@kyleam.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Kyle Meyer <kyle@kyleam.com>
Cc: guix-devel <guix-devel@gnu.org>

On Thu, Dec 03, 2015 at 01:24:09AM -0500, Kyle Meyer wrote:
> * gnu/packages/python.scm (python-docopt, python2-docopt): New
>   variables.

Have you tested the software provided by this patch to make sure it
works? I'm not sure how to test it since it's just a library.

> ---
>  gnu/packages/python.scm | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 45222e9..5b31ae8 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -5994,3 +5994,29 @@ automatically detect a wide range of file encodings.")
>  
>  (define-public python2-chardet
>    (package-with-python2 python-chardet))
> +
> +(define-public python-docopt
> +  (package
> +    (name "python-docopt")
> +    (version "0.6.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "docopt" version))

Nice, I haven't noticed this before. Looks like a recent addition :)

> +       (sha256
> +        (base32
> +         "14f4hn6d1j4b99svwbaji8n2zj58qicyz19mm0x6pmhb50jsics9"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-setuptools" ,python-setuptools)))
> +    (arguments '(#:tests? #f))   ; Tests are not included in the PyPI release.

Are there tests in any other releases? If not, I would change the
comment to "No test suite", just to make it more clear. If yes, we
should probably package that release while asking upstream to include
the tests in the PyPi release.

> +    (home-page "http://docopt.org")
> +    (synopsis "Command-line interface description language for Python")
> +    (description "This library allows the user to define a command-line
> +interface from a program's help message rather than specifying it
> +programatically with command-line parsers like @code{getopt} and
> +@code{argparse}.")
> +    (license license:expat)))
> +
> +(define-public python2-docopt
> +  (package-with-python2 python-docopt))
> -- 
> 2.6.2
> 
>