From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add python-contextlib2 Date: Wed, 18 Nov 2015 09:46:40 +0100 Message-ID: <20151118084640.GA4950@debian.ntu.edu.sg> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyyOE-0007FM-Lz for guix-devel@gnu.org; Wed, 18 Nov 2015 03:46:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZyyOB-00029s-Bb for guix-devel@gnu.org; Wed, 18 Nov 2015 03:46:54 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZyyOB-00029o-1q for guix-devel@gnu.org; Wed, 18 Nov 2015 03:46:51 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Chris Marusich Cc: guix-devel@gnu.org Hello, and congratulations for your first package! Upon a quick glance, I have the following comments: > gnu: Add python-contextlib2 Please add a "." at the end of the line. > * gnu/packages/python.scm (python-contextlib2, python2-contextlib2): > New variables. > gnu/packages/patches/python-contextlib2.patch | 51 +++++++++++++++++++++++++++ > gnu/packages/python.scm | 24 +++++++++++++ > 2 files changed, 75 insertions(+) You also need to add the patch to gnu-system.am. Then add two lines to the commit log explaining the changes to the two other files; you will find examples in the commit history. At the top of a patch file, we usually provide a little explanation of why the patch is needed; if it concerns a problem to be fixed upstream, we usually report the bug and add a reference to the bug url; if it comes from another distribution we give the reference. Did you run "./pre-inst-env guix lint python-contextlib2" etc.? This can detect potential problems. (I did not try it on your patch, and am just asking because I tend to forget it myself.) I let the python gurus comment on the content of the package. Andreas