Re: [PATCH] gnu: guile: Add guile-irregex.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1: Type: text/plain, Size: 2113 bytes --]

On Fri, 06 Nov 2015 10:58:58 -0600
Christopher Allan Webber <cwebber@dustycloud.org> wrote:

> Ludovic Courtès writes:
> 
> > Christopher Allan Webber <cwebber@dustycloud.org> skribis:
> >  
> >> On a side note, it would really be nice to have a
> >> r6rs-build-system... starting to result in a lot of similar spaghetti in
> >> a few of these packages.  
> >
> > Is there really a standard R6 way of doing things?
> >
> > I agree some factorization would be welcome anyhow!  
> 
> I don't really know, that comes from reading the Guildhall README:
> 
>   https://github.com/ijp/guildhall/blob/master/README
> 
>   > === Background ==========================================================
>   > Guildhall is a port of Andreas Rottmanns Dorodango portable package manager for
>   > R6RS Scheme, adapted to better fit in with Guile Scheme environments. 
>   > It is compatible with the R6RS Scheme package archives that Dorodango uses.
>   >
>   > dorodango is (intended to be) a package manager for R6RS
>   > implementations. Its main concepts are outlined in this thread:
>   > <http://groups.google.com/group/ikarus-users/browse_thread/thread/fabb890e3015f6f1>.  
> 
> So I've thought there's something probably, but I haven't really looked
> enough...
> 
> >> +     `(#:modules ((guix build utils)
> >> +                  (ice-9 match)
> >> +                  ,@%gnu-build-system-modules)  
> >
> > I think (guix build gnu-build-system) is enough on the 3rd line.  
> 
> Good call.
> 
> >> +    (synopsis "S-expression based regular expressions, packaged for Guile")  
> >
> > I’d remove “, packaged for Guile”.
> >
> > Otherwise LGTM, thank you!
> >
> > Ludo’.  
> 
> Done, and pushed!
> 

I see its already pushed, but when you were busy replacing everything in
gnu-build-system except for 'patch-shebang, you deleted 'check twice.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]