* Re: [PATCH] gnu: Add ghc-haddock-api.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:20 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-haskell-src-exts ericbavier
` (21 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-haddock-api): New variable.
> ---
> gnu/packages/haskell.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 4dacc92..be14e82 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -417,6 +417,31 @@ project if you can't release often. For interacting with Haddock itself, see
> the ‘haddock’ package.")
> (license bsd-3)))
>
> +(define-public ghc-haddock-api
> + (package
> + (name "ghc-haddock-api")
> + (version "2.16.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/haddock-api/haddock-api-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1spd5axg1pdjv4dkdb5gcwjsc8gg37qi4mr2k2db6ayywdkis1p2"))))
> + (build-system haskell-build-system)
> + (propagated-inputs
> + `(("ghc-paths" ,ghc-paths)
> + ("ghc-haddock-library" ,ghc-haddock-library)))
> + (home-page "http://www.haskell.org/haddock/")
> + (synopsis
> + "Documentation-generation tool for Haskell libraries")
> + (description
> + "Haddock is a documentation-generation tool for Haskell libraries.")
Could you adjust the synopsis and description to differentiate this package
from ghc-haddock?
Thanks,
`~Eric
> + (license bsd-3)))
> +
> (define-public ghc-simple-reflect
> (package
> (name "ghc-simple-reflect")
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-haskell-src-exts.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-haddock-api ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:07 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hlint ericbavier
` (20 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-haskell-src-exts): New variable.
> ---
> gnu/packages/haskell.scm | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d374b8d..d56c9e2 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -461,6 +461,43 @@ specification in BNF, Happy generates Haskell code to parse the grammar.
> Happy works in a similar way to the yacc tool for C.")
> (license bsd-3)))
>
> +(define-public ghc-haskell-src-exts
> + (package
[...]
> + "Manipulating Haskell source: abstract syntax, lexer, parser, and
> +pretty-printer")
How about: "Manipulate Haskell source"
`~Eric
> + (description
> + "Haskell-Source with Extensions (HSE, haskell-src-exts) is an extension
> +of the standard haskell-src package, and handles most registered syntactic
> +extensions to Haskell. All extensions implemented in GHC are supported.
> +Apart from these standard extensions, it also handles regular patterns as per
> +the HaRP extension as well as HSX-style embedded XML syntax.")
> + (license bsd-3)))
> +
> (define-public ghc-cpphs
> (package
> (name "ghc-cpphs")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-hlint.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-haddock-api ericbavier
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-haskell-src-exts ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:15 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hscolour ericbavier
` (19 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-hlint): New variable.
> ---
> gnu/packages/haskell.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d56c9e2..c03848f 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -498,6 +498,36 @@ Apart from these standard extensions, it also handles regular patterns as per
> the HaRP extension as well as HSX-style embedded XML syntax.")
> (license bsd-3)))
>
> +(define-public ghc-hlint
> + (package
> + (name "ghc-hlint")
I would suggest calling this package simple "hlint", as it is primarily a tool.
`~Eric
> + (version "1.9.21")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/hlint/hlint-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "14v3rdjjlml9nimdk7d5dvir2bw78ai49yylvms9lnzmw29s3546"))))
> + (build-system haskell-build-system)
> + (inputs
> + `(("ghc-cpphs" ,ghc-cpphs)
> + ("ghc-cmdargs" ,ghc-cmdargs)
> + ("ghc-haskell-src-exts" ,ghc-haskell-src-exts)
> + ("ghc-uniplate" ,ghc-uniplate)
> + ("ghc-ansi-terminal" ,ghc-ansi-terminal)
> + ("ghc-extra" ,ghc-extra)
> + ("ghc-hscolour" ,ghc-hscolour)))
> + (home-page
> + "http://community.haskell.org/~ndm/hlint/")
> + (synopsis "Source code suggestions")
"Make suggestions for Haskell source code"
> + (description
> + "HLint gives suggestions on how to improve your source code.")
How about, from the home-page:
"HLint reads Haskell programs and suggests changes that hopefully make them
easier to read. HLint also makes it easy to disable unwanted suggestions, and
to add your own custom suggestions."
> + (license bsd-3)))
> +
> (define-public ghc-cpphs
> (package
> (name "ghc-cpphs")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-hlint.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hlint ericbavier
@ 2015-10-22 15:15 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 15:15 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-hlint
>> + (package
>> + (name "ghc-hlint")
>
> I would suggest calling this package simple "hlint", as it is primarily a tool.
Indeed, i had the same feeling :). Done.
>> + (synopsis "Source code suggestions")
>
> "Make suggestions for Haskell source code"
Slightly modified, but done.
>> + (description
>> + "HLint gives suggestions on how to improve your source code.")
>
> How about, from the home-page:
>
> "HLint reads Haskell programs and suggests changes that hopefully make them
> easier to read. HLint also makes it easy to disable unwanted suggestions, and
> to add your own custom suggestions."
Perfect, applied.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-hscolour.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (2 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hlint ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:17 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-opengl ericbavier
` (18 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-hscolour): New variable.
> ---
> gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 905471d..ebad06a 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1331,6 +1331,30 @@ for better error messages.")
> (description "This library provides @code{Comonad}s for Haskell.")
> (license bsd-3)))
>
> +(define-public ghc-hscolour
> + (package
> + (name "ghc-hscolour")
I would suggest we name this package "hscolour" because it is primarily
program or tool. It also has libraries; perhaps those could be put in a "lib"
output? WDYT?
`~Eric
> + (version "1.23")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/hscolour/hscolour-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1c4i2zpami8g3w9949nm3f92g7xwh5c94vkx658zz7ihrjp7w5lp"))))
> + (build-system haskell-build-system)
> + (home-page "https://hackage.haskell.org/package/hscolour")
> + (synopsis "Script to colourise Haskell code")
> + (description "HSColour is a small Haskell script to colourise Haskell
> +code. It currently has six output formats: ANSI terminal codes (optionally
> +XTerm-256colour codes), HTML 3.2 with font tags, HTML 4.01 with CSS, HTML 4.01
> +with CSS and mouseover annotations, XHTML 1.0 with inline CSS styling, LaTeX,
> +and mIRC chat codes.")
> + (license bsd-3)))
> +
> (define-public ghc-appar
> (package
> (name "ghc-appar")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-hscolour.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hscolour ericbavier
@ 2015-10-22 15:17 ` Paul van der Walt
2015-10-22 16:48 ` Eric Bavier
0 siblings, 1 reply; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 15:17 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-hscolour
>> + (package
>> + (name "ghc-hscolour")
>
> I would suggest we name this package "hscolour" because it is primarily
> program or tool.
Indeed, i have renamed it.
> It also has libraries; perhaps those could be put in a "lib"
> output? WDYT?
Maybe i should be less lazy (surely we can forgive that in the context
of Haskell), but to be perfectly frank, i'd just love to get these
patches off my plate. Given that the Guix behaviour mirrors the Cabal
behaviour for this package (that is, it's installed, or not) i think
it's fine. But indeed i am not the most pedantic person here.
I will defer to your better judgement, but for now i've only changed the
package name.
Thanks,
p.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-hscolour.
2015-10-22 15:17 ` Paul van der Walt
@ 2015-10-22 16:48 ` Eric Bavier
2015-10-22 16:53 ` Paul van der Walt
0 siblings, 1 reply; 81+ messages in thread
From: Eric Bavier @ 2015-10-22 16:48 UTC (permalink / raw)
To: Paul van der Walt; +Cc: guix-devel
On 2015-10-22 10:17, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> +(define-public ghc-hscolour
>>> + (package
>>> + (name "ghc-hscolour")
>>
>> I would suggest we name this package "hscolour" because it is
>> primarily
>> program or tool.
>
> Indeed, i have renamed it.
>
>> It also has libraries; perhaps those could be put in a "lib"
>> output? WDYT?
>
> Maybe i should be less lazy (surely we can forgive that in the context
> of Haskell), but to be perfectly frank, i'd just love to get these
> patches off my plate. Given that the Guix behaviour mirrors the Cabal
> behaviour for this package (that is, it's installed, or not) i think
> it's fine. But indeed i am not the most pedantic person here.
>
> I will defer to your better judgement, but for now i've only changed
> the
> package name.
Seems fair. We can revisit later if need be. Thanks for sticking out
the review.
--
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-opengl.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (3 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-hscolour ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:10 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-openglraw ericbavier
` (17 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-opengl): New variable.
> ---
> gnu/packages/haskell.scm | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 5203cd0..792dce0 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -940,6 +940,36 @@ It is basically a 1:1 mapping of GLU's C API, intended as a basis for a nicer
> interface.")
> (license bsd-3)))
>
> +(define-public ghc-opengl
> + (package
[...]
> + (synopsis
> + "Bindings for the OpenGL graphics system")
"Haskell bindings for the OpenGL graphics system"
> + (description
> + "A Haskell binding for the OpenGL graphics system (GL, version 4.5) and
> +its accompanying utility library (GLU, version 1.3).")
"This package provides Haskell bindings for..."
And similar suggestions for ghc-glut.
`~Eric
> + (license bsd-3)))
> +
> (define-public ghc-streaming-commons
> (package
> (name "ghc-streaming-commons")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-opengl.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-opengl ericbavier
@ 2015-10-22 15:10 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 15:10 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-opengl
>> + (package
> [...]
>> + (synopsis
>> + "Bindings for the OpenGL graphics system")
>
> "Haskell bindings for the OpenGL graphics system"
>
>> + (description
>> + "A Haskell binding for the OpenGL graphics system (GL, version 4.5) and
>> +its accompanying utility library (GLU, version 1.3).")
>
> "This package provides Haskell bindings for..."
>
> And similar suggestions for ghc-glut.
Fixed for ghc-glut and ghc-opengl.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-openglraw.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (4 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-opengl ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:07 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-pcre-light ericbavier
` (16 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
[...]
> +(define-public ghc-openglraw
> + (package
> + (name "ghc-openglraw")
> + (version "2.5.1.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/OpenGLRaw/OpenGLRaw-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1kfq24mxg922ml3kkmym2qfpc56jbmrfbiix4rc2cxlwv05i191k"))))
> + (build-system haskell-build-system)
> + (inputs
> + `(("ghc-half" ,ghc-half)
> + ("glu" ,glu)
> + ("ghc-text" ,ghc-text)))
> + (home-page
> + "http://www.haskell.org/haskellwiki/Opengl")
> + (synopsis
> + "Raw bindings for the OpenGL graphics system")
"Raw bindings" -> "Raw Haskell bindings"
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-pcre-light.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (5 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-openglraw ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:06 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-reflection ericbavier
` (15 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-pcre-light): New variable.
> ---
> gnu/packages/haskell.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
[...]
> + (synopsis
> + "Efficient and portable Perl-compatible regex library")
In order to disambiguate with other pcre libraries, how about:
"Haskell library for Perl 5 compatible regular expressions"
> + (description
> + "This package provides a small, efficient and portable regex library for
We tend to make use of the Oxford comma. --------^
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-pcre-light.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-pcre-light ericbavier
@ 2015-10-22 15:06 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 15:06 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (synopsis
>> + "Efficient and portable Perl-compatible regex library")
>
> In order to disambiguate with other pcre libraries, how about:
>
> "Haskell library for Perl 5 compatible regular expressions"
>
>> + (description
>> + "This package provides a small, efficient and portable regex library for
>
> We tend to make use of the Oxford comma. --------^
All fixed.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-reflection.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (6 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-pcre-light ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:04 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-base ericbavier
` (14 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-reflection): New variable.
> ---
> gnu/packages/haskell.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index ee30454..86fc76f 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -364,6 +364,31 @@ package.")
> package.")
> (license bsd-3)))
>
> +(define-public ghc-reflection
> + (package
> + (name "ghc-reflection")
> + (version "2.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/reflection/reflection-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "10w3m6v3g6am203wbrikdbp57x9vw6b4jsh7bxdzsss4nmpm81zg"))))
> + (build-system haskell-build-system)
> + (inputs `(("ghc-tagged" ,ghc-tagged)))
> + (home-page "http://github.com/ekmett/reflection")
> + (synopsis "Reifies arbitrary terms into types that can be reflected back
> +into terms")
"Reifies" -> "Reify"
> + (description "This package addresses the 'configuration problem' which is
> +propogating configurations that are available at run-time, allowing multible
"multible" -> "multiple"
> +configurations to coexist without resorting to mutable global variables or
> +@code{System.IO.Unsafe.unsafePerformIO}.")
> + (license bsd-3)))
> +
> (define-public ghc-old-locale
> (package
> (name "ghc-old-locale")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-regex-base.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (7 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-reflection ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:03 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-posix ericbavier
` (13 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-regex-base): New variable.
> ---
> gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
[...]
> + (description
> + "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
How about:
Text.Regex.Base provides the interface API for regex-posix, regex-pcre,
regex-parsec, regex-tdfa, and regex-dfa.
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-regex-base.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-base ericbavier
@ 2015-10-22 15:03 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 15:03 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (description
>> + "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
>
> How about:
>
> Text.Regex.Base provides the interface API for regex-posix, regex-pcre,
> regex-parsec, regex-tdfa, and regex-dfa.
Fixed.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-regex-posix.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (8 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-base ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:01 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-tdfa-rc ericbavier
` (12 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-regex-posix): New variable.
> ---
> gnu/packages/haskell.scm | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index bff7a54..92345f0 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1692,6 +1692,28 @@ Both IPv4 and IPv6 are supported.")
> "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
> (license bsd-3)))
>
> +(define-public ghc-regex-posix
> + (package
> + (name "ghc-regex-posix")
> + (version "0.95.2")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/regex-posix/regex-posix-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "0gkhzhj8nvfn1ija31c7xnl6p0gadwii9ihyp219ck2arlhrj0an"))))
> + (build-system haskell-build-system)
> + (inputs `(("ghc-regex-base" ,ghc-regex-base)))
> + (home-page "http://sourceforge.net/projects/lazy-regex")
> + (synopsis "Replaces/Enhances Text.Regex")
How about: "POSIX regular expressions for Haskell"
`~Eric
> + (description "This library provides the posix regex backend used by
> +@code{regex-base}.")
> + (license bsd-3)))
> +
> (define-public ghc-regex-tdfa-rc
> (package
> (name "ghc-regex-tdfa-rc")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-regex-tdfa-rc.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (9 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-posix ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:00 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-sdl-mixer ericbavier
` (11 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-regex-tdfa-rc): New variable.
> ---
> gnu/packages/haskell.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index be37c5a..810dfb1 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1132,6 +1132,34 @@ Both IPv4 and IPv6 are supported.")
> "Interface API for regex-posix, pcre, parsec, tdfa, dfa.")
> (license bsd-3)))
>
> +(define-public ghc-regex-tdfa-rc
> + (package
> + (name "ghc-regex-tdfa-rc")
> + (version "1.1.8.3")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/regex-tdfa-rc/regex-tdfa-rc-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1vi11i23gkkjg6193ak90g55akj69bhahy542frkwb68haky4pp3"))))
> + (build-system haskell-build-system)
> + (propagated-inputs
> + `(("ghc-regex-base" ,ghc-regex-base)
> + ("ghc-parsec" ,ghc-parsec)))
> + (inputs
> + `(("ghc-mtl" ,ghc-mtl)))
I would be surprised if this did not also need to be propagated, but I confess
I do not know of a reliable way to check.
> + (home-page
> + "http://hackage.haskell.org/package/regex-tdfa")
> + (synopsis "Replaces/Enhances Text.Regex")
How about: "Tagged DFA regex engine for Haskell"
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-sdl-mixer.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (10 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-regex-tdfa-rc ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 16:04 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroupoids ericbavier
` (10 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-sdl-mixer): New variable.
> ---
> gnu/packages/haskell.scm | 42 ++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 42 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 161b3e5..914c518 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -894,6 +894,48 @@ by MPEG playback software, emulators, and many popular games, including the
> award winning Linux port of \"Civilization: Call To Power.\"")
> (license bsd-3)))
>
> +(define-public ghc-sdl-mixer
> + (package
> + (name "ghc-sdl-mixer")
> + (version "0.6.1.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/SDL-mixer/SDL-mixer-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "0md3238hx79mxb9a7l43kg3b3d28x4mqvj0hjsbsh15ajnvy9x2z"))))
> + (build-system haskell-build-system)
> + (arguments
> + `(#:configure-flags
> + (let* ((sdl-mixer (assoc-ref %build-inputs "sdl-mixer"))
> + (sdl-mixer-lib (string-append sdl-mixer "/lib"))
> + (sdl-mixer-include (string-append sdl-mixer "/include/SDL")))
> + (list (string-append "--extra-include-dirs=" sdl-mixer-include)
> + (string-append "--extra-lib-dirs=" sdl-mixer-lib)))
Is the --extra-lib-dirs argument really necessary? I think
haskell-build-system already passes flags for every "lib" directory it sees in
inputs.
> + #:phases
> + (modify-phases %standard-phases
> + (add-before
> + 'configure 'fix-/bin/sh
> + (lambda _
> + ;; Use `sh', not `/bin/sh'.
> + (substitute* (find-files "." "Makefile|configure")
> + (("/bin/sh") "sh")))))))
See comments about ghc-doctest package.
> + (propagated-inputs
> + `(("sdl-mixer" ,sdl-mixer)
I can understand propagating ghc-sdl, but is it necessary to propagate the
sdl-mixer library too?
> + ("ghc-sdl" ,ghc-sdl)))
> + (home-page
> + "http://hackage.haskell.org/package/SDL-mixer")
> + (synopsis "Binding to libSDL_mixer")
"Haskell bindings to libSDL_mixer"
Similar comments for the ghc-sdl-image patch.
`~Eric
> + (description "SDL_mixer is a sample multi-channel audio mixer library. It
> +supports any number of simultaneously playing channels of 16 bit stereo audio,
> +plus a single channel of music, mixed by the popular MikMod MOD, Timidity
> +MIDI, Ogg Vorbis, and SMPEG MP3 libraries.")
> + (license bsd-3)))
> +
> (define-public ghc-half
> (package
> (name "ghc-half")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-sdl-mixer.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-sdl-mixer ericbavier
@ 2015-10-22 16:04 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 16:04 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + `(#:configure-flags
>> + (let* ((sdl-mixer (assoc-ref %build-inputs "sdl-mixer"))
>> + (sdl-mixer-lib (string-append sdl-mixer "/lib"))
>> + (sdl-mixer-include (string-append sdl-mixer "/include/SDL")))
>> + (list (string-append "--extra-include-dirs=" sdl-mixer-include)
>> + (string-append "--extra-lib-dirs=" sdl-mixer-lib)))
>
> Is the --extra-lib-dirs argument really necessary? I think
> haskell-build-system already passes flags for every "lib" directory it
> sees in inputs.
Indeed, that was a troubleshooting remnant. Thanks! Removed.
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-before
>> + 'configure 'fix-/bin/sh
>> + (lambda _
>> + ;; Use `sh', not `/bin/sh'.
>> + (substitute* (find-files "." "Makefile|configure")
>> + (("/bin/sh") "sh")))))))
>
> See comments about ghc-doctest package.
I assume you mean the more elegant CONFIG_SHELL environment variable
patch? If so, it's been fixed.
>> + (propagated-inputs
>> + `(("sdl-mixer" ,sdl-mixer)
>
> I can understand propagating ghc-sdl, but is it necessary to propagate the
> sdl-mixer library too?
You're right, it's not. Removed.
>> + ("ghc-sdl" ,ghc-sdl)))
>> + (home-page
>> + "http://hackage.haskell.org/package/SDL-mixer")
>> + (synopsis "Binding to libSDL_mixer")
>
> "Haskell bindings to libSDL_mixer"
Fixed.
> Similar comments for the ghc-sdl-image patch.
The same changes have been applied to ghc-sdl-image.
Thank you!
p.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-semigroupoids.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (11 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-sdl-mixer ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:57 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroups ericbavier
` (9 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-semigroupoids): New variable.
> ---
> gnu/packages/haskell.scm | 39 +++++++++++++++++++++++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 9b1c4cb..c6b092b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -3087,6 +3087,45 @@ are implemented as FFI bindings to efficient code from zlib.")
> (description "This package provides bifunctors for Haskell.")
> (license bsd-3)))
>
> +(define-public ghc-semigroupoids
> + (package
> + (name "ghc-semigroupoids")
> + (version "5.0.0.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/semigroupoids/semigroupoids-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1jf7jnfhdvl6p18wdr21yi2fim1xb8alcn6szhrdswj0dkilgq6d"))))
> + (build-system haskell-build-system)
> + (propagated-inputs
> + `(("ghc-base-orphans" ,ghc-base-orphans)
> + ("ghc-transformers-compat" ,ghc-transformers-compat)
> + ("ghc-bifunctors" ,ghc-bifunctors)
> + ("ghc-comonad" ,ghc-comonad)
> + ("ghc-contravariant" ,ghc-contravariant)
> + ("ghc-distributive" ,ghc-distributive)))
> + (arguments `(#:tests? #f)) ; FIXME: test framework unavailable
> + (inputs
> + `(("ghc-semigroups" ,ghc-semigroups)
> + ("ghc-tagged" ,ghc-tagged)
> + ("ghc-doctest" ,ghc-doctest)))
> + (home-page "http://github.com/ekmett/semigroupoids")
> + (synopsis "Semigroupoids: Category sans id")
How about: "Semigroupoid operations for Haskell"
`~Eric
> + (description "This library provides a wide array of (semi)groupoids and
> +operations for working with them. A @code{Semigroupoid} is a @code{Category}
> +without the requirement of identity arrows for every object in the category.
> +A @code{Category} is any @code{Semigroupoid} for which the Yoneda lemma holds.
> +Finally, to work with these weaker structures it is beneficial to have
> +containers that can provide stronger guarantees about their contents, so
> +versions of @code{Traversable} and @code{Foldable} that can be folded with
> +just a @code{Semigroup} are added.")
> + (license bsd-3)))
> +
> (define-public ghc-contravariant
> (package
> (name "ghc-contravariant")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-semigroups.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (12 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroupoids ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:15 ` Paul van der Walt
2015-10-22 14:56 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-tasty-golden ericbavier
` (8 subsequent siblings)
22 siblings, 2 replies; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-semigroups): New variable.
> ---
> gnu/packages/haskell.scm | 33 +++++++++++++++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index a26c7cf..a40cc3c 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2468,6 +2468,39 @@ unbounded @code{Integer} type.")
> (description "This library provides the natural numbers for Haskell.")
> (license bsd-3)))
>
> +(define-public ghc-semigroups
> + (package
[...]
> + (inputs
> + `(("ghc-text" ,ghc-text)
> + ("ghc-hashable" ,ghc-hashable)))
Do these not need to also be propagated?
> + (synopsis "Anything that associates")
This is quite general. How about: "Semigroup operations for Haskell"
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-semigroups.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroups ericbavier
@ 2015-10-22 14:15 ` Paul van der Walt
2015-10-22 16:54 ` Eric Bavier
2015-10-22 14:56 ` Paul van der Walt
1 sibling, 1 reply; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 14:15 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (inputs
>> + `(("ghc-text" ,ghc-text)
>> + ("ghc-hashable" ,ghc-hashable)))
>
> Do these not need to also be propagated?
This is a comment that comes up frequently. To be honest, i don't know
how to check. My packaging strategy has been,
1) put everything in `inputs`
2) make sure the package P1 builds
3) use P1 as an input elsewhere, say in P2
4) if and only if P2 cannot build because of the usual "broken package,
missing dependencies for P1" error, i add the missing packages to
`propagated-inputs` of P1.
So no, pragmatically speaking, those inputs do not need to be
propagated, because subsequent builds work fine (up to and including
Idris, which was the root of the dependency tree causing me to add this
and many other packages).
If, however, you believe it's preferable to put the inputs you mention
into `propagated-inputs`, i will not provide any resistance.
Regards,
p.
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-semigroups.
2015-10-22 14:15 ` Paul van der Walt
@ 2015-10-22 16:54 ` Eric Bavier
0 siblings, 0 replies; 81+ messages in thread
From: Eric Bavier @ 2015-10-22 16:54 UTC (permalink / raw)
To: Paul van der Walt; +Cc: guix-devel
On 2015-10-22 09:15, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> + (inputs
>>> + `(("ghc-text" ,ghc-text)
>>> + ("ghc-hashable" ,ghc-hashable)))
>>
>> Do these not need to also be propagated?
>
> This is a comment that comes up frequently. To be honest, i don't know
> how to check. My packaging strategy has been,
>
> 1) put everything in `inputs`
>
> 2) make sure the package P1 builds
>
> 3) use P1 as an input elsewhere, say in P2
>
> 4) if and only if P2 cannot build because of the usual "broken package,
> missing dependencies for P1" error, i add the missing packages to
> `propagated-inputs` of P1.
>
> So no, pragmatically speaking, those inputs do not need to be
> propagated, because subsequent builds work fine (up to and including
> Idris, which was the root of the dependency tree causing me to add this
> and many other packages).
Great. Yes, we'd rather not propagate inputs unless strictly necessary.
The only reason I ask is for cases where a user might be using the
library to build something we do not have packaged, but in that case
it's trivial enough them to install the missing dependency. Again, all
this should be a moot point with a native-search-path for GHC.
--
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-semigroups.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroups ericbavier
2015-10-22 14:15 ` Paul van der Walt
@ 2015-10-22 14:56 ` Paul van der Walt
1 sibling, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 14:56 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> +(define-public ghc-semigroups
>> + (package
> [...]
>> + (inputs
>> + `(("ghc-text" ,ghc-text)
>> + ("ghc-hashable" ,ghc-hashable)))
>
> Do these not need to also be propagated?
I don't know, but it works for me (including packages which depend on
this one). See my previous email on the subject.
>> + (synopsis "Anything that associates")
>
> This is quite general. How about: "Semigroup operations for Haskell"
Fixed.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-tasty-golden.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (13 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-semigroups ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:54 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-uniplate ericbavier
` (7 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-tasty-golden): New variable.
> ---
> gnu/packages/haskell.scm | 35 +++++++++++++++++++++++++++++++++++
> 1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index e017595..ccfb087 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -2877,6 +2877,41 @@ It is modeled after doctest for Python, see
> Haskell test framework.")
> (license expat)))
>
> +(define-public ghc-tasty-golden
> + (package
[...]
> + (description
> + "This package provides support for «golden testing». A golden test is an
It might be best to use standard quotes here, rather than the guillemets, and
let translators handle localization. WDYT?
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-uniplate.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (14 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-tasty-golden ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:52 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-unix-time ericbavier
` (6 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-uniplate): New variable.
> ---
> gnu/packages/haskell.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 4246b64..50da7ff 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1381,6 +1381,34 @@ optimized for performance critical use, both in terms of large data quantities
> and high speed.")
> (license bsd-3)))
>
> +(define-public ghc-uniplate
> + (package
[...]
> + (synopsis
> + "Help writing simple, concise and fast generic operations")
How about: "Simple, concise, and fast generic operations"
> + (description "Uniplate is library for writing simple and concise generic
Uniplate is _a_ library...
> +operations. Uniplate has similar goals to the original Scrap Your Boilerplate
> +work, but is substantially simpler and faster.")
^---- I believe this comma is grammatically unnecessary.
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-uniplate.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-uniplate ericbavier
@ 2015-10-22 14:52 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 14:52 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (synopsis
>> + "Help writing simple, concise and fast generic operations")
>
> How about: "Simple, concise, and fast generic operations"
Changed.
>> + (description "Uniplate is library for writing simple and concise generic
>
> Uniplate is _a_ library...
Good catch, thanks.
>> +operations. Uniplate has similar goals to the original Scrap Your Boilerplate
>> +work, but is substantially simpler and faster.")
>
> ^---- I believe this comma is grammatically unnecessary.
Without the comma, i find the sentence a bit breathless.
p.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-unix-time.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (15 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-uniplate ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 15:43 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-wai ericbavier
` (5 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-unix-time): New variable.
> ---
> gnu/packages/haskell.scm | 40 ++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 40 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index fc1f836..de55610 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -972,6 +972,46 @@ transformers 0.2 or 0.3 compatibility to run on old versions of the platform,
> but also need those types.")
> (license bsd-3)))
>
> +(define-public ghc-unix-time
> + (package
> + (name "ghc-unix-time")
> + (version "0.3.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/unix-time/unix-time-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "0dyvyxwaffb94bgri1wc4b9wqaasy32pyjn0lww3dqblxv8fn5ax"))))
> + (build-system haskell-build-system)
> + (arguments
> + `(#:tests? #f ; FIXME: Test fails with "System.Time not found". This is
> + ; weird, that should be provided by GHC 7.10.2.
> + #:phases
> + (alist-cons-before
> + 'configure 'fix-/bin/sh
> + (lambda _
> + ;; Use `sh', not `/bin/sh'.
> + (substitute* (find-files "." "Makefile|configure")
> + (("/bin/sh")
> + "sh")))
> + %standard-phases)))
See the ghc-x11 package for a, IMHO, more elegant solution.
This appears to be a more general issue however. Any package that declares in
its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL and/or
SHELL in the environment. See additionally the proposed ghc-sdl,
ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
Perhaps we could patch haskell-build-system to export appropriate CONFIG_SHELL
and SHELL variables if it sees a "configure" file in the top-level source
directory. WDYT? Would you like to send a patch?
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-unix-time.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-unix-time ericbavier
@ 2015-10-22 15:43 ` Paul van der Walt
2015-10-22 16:22 ` Andreas Enge
2015-10-22 16:57 ` Eric Bavier
0 siblings, 2 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 15:43 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + #:phases
>> + (alist-cons-before
>> + 'configure 'fix-/bin/sh
>> + (lambda _
>> + ;; Use `sh', not `/bin/sh'.
>> + (substitute* (find-files "." "Makefile|configure")
>> + (("/bin/sh")
>> + "sh")))
>> + %standard-phases)))
>
> See the ghc-x11 package for a, IMHO, more elegant solution.
Ah! Indeed.
> This appears to be a more general issue however. Any package that declares in
> its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL and/or
> SHELL in the environment. See additionally the proposed ghc-sdl,
> ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
>
> Perhaps we could patch haskell-build-system to export appropriate CONFIG_SHELL
> and SHELL variables if it sees a "configure" file in the top-level source
> directory. WDYT? Would you like to send a patch?
Right, i see what you mean. I agree that it'd probably be the right
thing to do. However, to expedite the merge of wip-haskell-… i propose
that i take the solution of ghc-x11 and apply it to the relevant
packages, and then look at fixing the haskell-build-system. At that
point we can simply remove the phases introduced to work around this
deficiency.
Do you think that's acceptable, or is it imperative* that we first solve
the problem in the build system?
I prefer the incremental approach (but i am not an objective outside
observer).
King regards,
p.
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-unix-time.
2015-10-22 15:43 ` Paul van der Walt
@ 2015-10-22 16:22 ` Andreas Enge
2015-10-22 16:50 ` Paul van der Walt
2015-10-22 16:57 ` Eric Bavier
1 sibling, 1 reply; 81+ messages in thread
From: Andreas Enge @ 2015-10-22 16:22 UTC (permalink / raw)
To: Paul van der Walt; +Cc: guix-devel
On Thu, Oct 22, 2015 at 05:43:03PM +0200, Paul van der Walt wrote:
> Right, i see what you mean. I agree that it'd probably be the right
> thing to do. However, to expedite the merge of wip-haskell-… i propose
> that i take the solution of ghc-x11 and apply it to the relevant
> packages, and then look at fixing the haskell-build-system. At that
> point we can simply remove the phases introduced to work around this
> deficiency.
> Do you think that's acceptable, or is it imperative* that we first solve
> the problem in the build system?
> I prefer the incremental approach (but i am not an objective outside
> observer).
I think it sounds reasonable, and would save us from further iterations
of 150 commits sent to the mailing list :-) Seriously, I am impressed
by your git juggling.
Andreas
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-unix-time.
2015-10-22 16:22 ` Andreas Enge
@ 2015-10-22 16:50 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 16:50 UTC (permalink / raw)
To: Andreas Enge; +Cc: guix-devel
Hey Andreas,
On 2015-10-22 at 18:22, quoth Andreas Enge:
> On Thu, Oct 22, 2015 at 05:43:03PM +0200, Paul van der Walt wrote:
>> Right, i see what you mean. I agree that it'd probably be the right
>> thing to do. However, to expedite the merge of wip-haskell-… i propose
>> that i take the solution of ghc-x11 and apply it to the relevant
>> packages, and then look at fixing the haskell-build-system. At that
>> point we can simply remove the phases introduced to work around this
>> deficiency.
>> Do you think that's acceptable, or is it imperative* that we first solve
>> the problem in the build system?
>> I prefer the incremental approach (but i am not an objective outside
>> observer).
>
> I think it sounds reasonable, and would save us from further iterations
> of 150 commits sent to the mailing list :-)
I'm glad i'm not the only one who thinks that way :). I'll be happy to
have these patches off my plate.
> Seriously, I am impressed by your git juggling.
Haha, thank you :-$, i still have much to learn though. I guess Guix is
good practice for me? :)
Kind regards,
p.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-unix-time.
2015-10-22 15:43 ` Paul van der Walt
2015-10-22 16:22 ` Andreas Enge
@ 2015-10-22 16:57 ` Eric Bavier
1 sibling, 0 replies; 81+ messages in thread
From: Eric Bavier @ 2015-10-22 16:57 UTC (permalink / raw)
To: Paul van der Walt; +Cc: guix-devel
On 2015-10-22 10:43, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> + #:phases
>>> + (alist-cons-before
>>> + 'configure 'fix-/bin/sh
>>> + (lambda _
>>> + ;; Use `sh', not `/bin/sh'.
>>> + (substitute* (find-files "." "Makefile|configure")
>>> + (("/bin/sh")
>>> + "sh")))
>>> + %standard-phases)))
>>
>> See the ghc-x11 package for a, IMHO, more elegant solution.
>
> Ah! Indeed.
>
>> This appears to be a more general issue however. Any package that
>> declares in
>> its *.cabal file "build-type: Configure" is going to need CONFIG_SHELL
>> and/or
>> SHELL in the environment. See additionally the proposed ghc-sdl,
>> ghc-sdl-image, ghc-sdl-mixer, and ghc-old-time patches.
>>
>> Perhaps we could patch haskell-build-system to export appropriate
>> CONFIG_SHELL
>> and SHELL variables if it sees a "configure" file in the top-level
>> source
>> directory. WDYT? Would you like to send a patch?
>
> Right, i see what you mean. I agree that it'd probably be the right
> thing to do. However, to expedite the merge of wip-haskell-… i propose
> that i take the solution of ghc-x11 and apply it to the relevant
> packages, and then look at fixing the haskell-build-system. At that
> point we can simply remove the phases introduced to work around this
> deficiency.
OK.
> Do you think that's acceptable, or is it imperative* that we first
> solve
> the problem in the build system?
An incremental approach seems reasonable to me in this case, since there
are not so many affected packages at this point.
--
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-wai.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (16 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-unix-time ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:50 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-xml ericbavier
` (4 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-wai): New variable.
> ---
> gnu/packages/haskell.scm | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 4236aab..accbd35 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -4004,4 +4004,36 @@ for Haskell, optimized for ease of use and high performance. (A note on
> naming: in Greek mythology, Aeson was the father of Jason.)")
> (license bsd-3)))
>
> +(define-public ghc-wai
> + (package
> + (name "ghc-wai")
> + (version "3.0.4.0")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/wai/wai-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "1551n0g0n22vml33v0jz5xgjcy6j79algvsdqg11a1z5ljjrjlqf"))))
> + (build-system haskell-build-system)
> + (propagated-inputs
> + `(("ghc-bytestring-builder" ,ghc-bytestring-builder)
> + ("ghc-unix-compat" ,ghc-unix-compat)
> + ("ghc-vault" ,ghc-vault)
> + ("ghc-blaze-builder" ,ghc-blaze-builder)
> + ("ghc-network" ,ghc-network)))
> + (inputs
> + `(("ghc-quickcheck" ,ghc-quickcheck)
> + ("ghc-hunit" ,ghc-hunit)
> + ("ghc-hspec" ,ghc-hspec)
> + ("ghc-text" ,ghc-text)
> + ("ghc-http-types" ,ghc-http-types)))
> + (home-page "https://hackage.haskell.org/package/wai")
> + (synopsis "WAI: Web Application Interface")
How about: "Web application interface library for Haskell."
> + (description "Web Application Interface library for Haskell.")
and:
"This package provides a Web Application Interface (WAI) library for the
Haskell language. It defines a common protocol for communication between web
applications and web servers."
`~Eric
> + (license bsd-3)))
> +
> ;;; haskell.scm ends here
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-wai.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-wai ericbavier
@ 2015-10-22 14:50 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 14:50 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (synopsis "WAI: Web Application Interface")
>
> How about: "Web application interface library for Haskell."
>
>> + (description "Web Application Interface library for Haskell.")
>
> and:
>
> "This package provides a Web Application Interface (WAI) library for the
> Haskell language. It defines a common protocol for communication between web
> applications and web servers."
Both changed, thanks for the suggestions!
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-xml.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (17 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-wai ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:48 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-zip-archive ericbavier
` (3 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-xml): New variable.
> ---
> gnu/packages/haskell.scm | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 28a65fb..ff11c1b 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1085,6 +1085,27 @@ Transformers\" available @uref{http://okmij.org/ftp/papers/LogicT.pdf,
> online}.")
> (license bsd-3)))
>
> +(define-public ghc-xml
> + (package
[...]
> + (inputs `(("ghc-text" ,ghc-text)))
This input should probably be propagated.
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add ghc-zip-archive.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (18 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-xml ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:47 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: Add Idris, the dependently-typed language ericbavier
` (2 subsequent siblings)
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-zip-archive): New variable.
> ---
> gnu/packages/haskell.scm | 31 +++++++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index d9704c8..35952ed 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -31,6 +31,7 @@
> #:use-module (gnu packages compression)
> #:use-module (gnu packages elf)
> #:use-module (gnu packages bootstrap)
> + #:use-module (gnu packages zip)
> #:use-module (gnu packages ghostscript)
> #:use-module (gnu packages libffi)
> #:use-module (gnu packages libedit)
> @@ -1217,6 +1218,36 @@ complicated text/binary file formats.")
> Haskell.")
> (license bsd-3)))
>
> +(define-public ghc-zip-archive
> + (package
> + (name "ghc-zip-archive")
> + (version "0.2.3.7")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "http://hackage.haskell.org/package/zip-archive/zip-archive-"
> + version
> + ".tar.gz"))
> + (sha256
> + (base32
> + "169nkxr5zlbymiz1ydlhlqr66vqiycmg85xh559phpkr64w3nqj1"))))
> + (build-system haskell-build-system)
> + (propagated-inputs
> + `(("ghc-old-time" ,ghc-old-time)
> + ("ghc-digest" ,ghc-digest)))
> + (inputs
> + `(("ghc-hunit" ,ghc-hunit)
> + ("ghc-mtl" ,ghc-mtl)
> + ("zip" ,zip)
> + ("ghc-text" ,ghc-text)
> + ("ghc-zlib" ,ghc-zlib)))
> + (home-page "https://hackage.haskell.org/package/zip-archive")
> + (synopsis "Zip archive library")
Let's distinguish this package with a "for Haskell" in the synopsis. WDYT?
`~Eric
> + (description "The zip-archive library provides functions for creating,
> +modifying, and extracting files from zip archives.")
> + (license bsd-3)))
> +
> (define-public ghc-appar
> (package
> (name "ghc-appar")
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add Idris, the dependently-typed language.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (19 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-zip-archive ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 14:45 ` Paul van der Walt
2015-10-22 8:47 ` [PATCH] gnu: ghc-split: Update dependencies ericbavier
2015-10-22 14:21 ` [PATCH] gnu: Add ghc-gluraw Paul van der Walt
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
With our conventions, the subject line should be just "gnu: Add Idris"
> * gnu/packages/haskell.scm (idris): New variable.
> ---
> gnu/packages/haskell.scm | 62 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 62 insertions(+)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index e814f24..5cf1827 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -32,6 +32,7 @@
> #:use-module (gnu packages elf)
> #:use-module (gnu packages bootstrap)
> #:use-module (gnu packages zip)
> + #:use-module (gnu packages gcc)
> #:use-module (gnu packages ghostscript)
> #:use-module (gnu packages libffi)
> #:use-module (gnu packages libedit)
> @@ -4314,4 +4315,65 @@ naming: in Greek mythology, Aeson was the father of Jason.)")
> functionality.")
> (license expat)))
>
> +(define-public idris
> + (package
> + (name "idris")
> + (version "0.9.19.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "https://hackage.haskell.org/package/idris-"
> + version "/idris-" version ".tar.gz"))
> + (sha256
> + (base32
> + "10641svdsjlxbxmbvylpia04cz5nn9486lpiay8ibqcrc1792qgc"))))
> + (build-system haskell-build-system)
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'patch-cc-command
> + (lambda _
> + (setenv "CC" "gcc")
> + ;; Package description file has a too-tight
> + ;; version restriction, rendering it
> + ;; incompatible with GHC 7.10.2. This is
> + ;; fixed upstream.
> + (substitute* "idris.cabal"
> + (("vector < 0.11") "vector < 0.12")))))))
Try adding "--allow-newer=vector" to #:configure-flags. Otherwise move this
to a separate phase, as it's not strictly related to patching cc.
> + (native-inputs
> + `(("gcc" ,gcc)))
gcc is already in the implicit inputs, so this may be left out.
Otherwise LGTM!
`~Eric
> + (inputs
> + `(("gmp" ,gmp)
> + ("ncurses" ,ncurses)
> + ("ghc-annotated-wl-pprint" ,ghc-annotated-wl-pprint)
> + ("ghc-ansi-terminal" ,ghc-ansi-terminal)
> + ("ghc-ansi-wl-pprint" ,ghc-ansi-wl-pprint)
> + ("ghc-base64-bytestring" ,ghc-base64-bytestring)
> + ("ghc-blaze-html" ,ghc-blaze-html)
> + ("ghc-blaze-markup" ,ghc-blaze-markup)
> + ("ghc-cheapskate" ,ghc-cheapskate)
> + ("ghc-fingertree" ,ghc-fingertree)
> + ("ghc-mtl" ,ghc-mtl)
> + ("ghc-network" ,ghc-network)
> + ("ghc-optparse-applicative" ,ghc-optparse-applicative)
> + ("ghc-parsers" ,ghc-parsers)
> + ("ghc-safe" ,ghc-safe)
> + ("ghc-split" ,ghc-split)
> + ("ghc-text" ,ghc-text)
> + ("ghc-trifecta" ,ghc-trifecta)
> + ("ghc-uniplate" ,ghc-uniplate)
> + ("ghc-unordered-containers" ,ghc-unordered-containers)
> + ("ghc-utf8-string" ,ghc-utf8-string)
> + ("ghc-vector-binary-instances" ,ghc-vector-binary-instances)
> + ("ghc-vector" ,ghc-vector)
> + ("ghc-zip-archive" ,ghc-zip-archive)
> + ("ghc-zlib" ,ghc-zlib)))
> + (home-page "http://www.idris-lang.org")
> + (synopsis "General purpose language with full dependent types")
> + (description "Idris is a general purpose language with full dependent
> +types. It is compiled, with eager evaluation. Dependent types allow types to
> +be predicated on values, meaning that some aspects of a program's behaviour
> +can be specified precisely in the type. The language is closely related to
> +Epigram and Agda.")
> + (license bsd-3)))
> +
> ;;; haskell.scm ends here
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add Idris, the dependently-typed language.
2015-10-22 8:47 ` [PATCH] gnu: Add Idris, the dependently-typed language ericbavier
@ 2015-10-22 14:45 ` Paul van der Walt
2015-10-22 17:02 ` Eric Bavier
0 siblings, 1 reply; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 14:45 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
Hi Eric,
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
> With our conventions, the subject line should be just "gnu: Add Idris"
Awww, no embellishments allowed *sniff*? :)
Fixed though.
> Try adding "--allow-newer=vector" to #:configure-flags.
I tried, this option does not exist.
> Otherwise move this to a separate phase, as it's not strictly related
> to patching cc.
Done.
>> + (native-inputs
>> + `(("gcc" ,gcc)))
>
> gcc is already in the implicit inputs, so this may be left out.
Indeed, done!
p.
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: Add Idris, the dependently-typed language.
2015-10-22 14:45 ` Paul van der Walt
@ 2015-10-22 17:02 ` Eric Bavier
2015-10-22 17:20 ` Paul van der Walt
0 siblings, 1 reply; 81+ messages in thread
From: Eric Bavier @ 2015-10-22 17:02 UTC (permalink / raw)
To: Paul van der Walt; +Cc: guix-devel
On 2015-10-22 09:45, Paul van der Walt wrote:
> Hi Eric,
>
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> With our conventions, the subject line should be just "gnu: Add Idris"
>
> Awww, no embellishments allowed *sniff*? :)
>
> Fixed though.
:)
>
>> Try adding "--allow-newer=vector" to #:configure-flags.
>
> I tried, this option does not exist.
Interesting. Thanks for trying, I honestly haven't used the flag
before, but I saw it in the Cabal documentation, so thought I make the
suggestion.
--
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add Idris, the dependently-typed language.
2015-10-22 17:02 ` Eric Bavier
@ 2015-10-22 17:20 ` Paul van der Walt
0 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 17:20 UTC (permalink / raw)
To: Eric Bavier; +Cc: guix-devel
On 2015-10-22 at 19:02, quoth Eric Bavier:
>>> Try adding "--allow-newer=vector" to #:configure-flags.
>>
>> I tried, this option does not exist.
>
> Interesting. Thanks for trying, I honestly haven't used the flag
> before, but I saw it in the Cabal documentation, so thought I make the
> suggestion.
Maybe i'm trying wrong. I tried to add it to #:configure-flags, which
doesn't work. I also tried:
1) `cabal get something`
2) cd something-…; runhaskell Setup.lhs configure --help
The option isn't mentioned there.
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: ghc-split: Update dependencies.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (20 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: Add Idris, the dependently-typed language ericbavier
@ 2015-10-22 8:47 ` ericbavier
2015-10-22 16:16 ` Paul van der Walt
2015-10-22 14:21 ` [PATCH] gnu: Add ghc-gluraw Paul van der Walt
22 siblings, 1 reply; 81+ messages in thread
From: ericbavier @ 2015-10-22 8:47 UTC (permalink / raw)
To: guix-devel, Paul van der Walt
From: Eric Bavier <ericbavier@openmailbox.org>
> * gnu/packages/haskell.scm (ghc-split): Update package dependencies for
> compatibility with new GHC.
> ---
> gnu/packages/haskell.scm | 21 ++++++++++++++++++++-
> 1 file changed, 20 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 2d5f857..6b4b5eb 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -1397,8 +1397,27 @@ and high speed.")
> (base32
> "0xa3j0gwr6k5vizxybnzk5fgb3pppgspi6mysnp2gwjp2dbrxkzr"))))
> (build-system haskell-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before
> + 'configure 'update-cabal
> + ;; the cabal file on hackage is updated, but the tar.gz does not
> + ;; include it.
> + (lambda* _
> + (copy-file (assoc-ref %build-inputs "ghc-split-cabal-update")
> + "split.cabal"))))))
> (inputs
> - `(("ghc-quickcheck" ,ghc-quickcheck)))
> + `(("ghc-quickcheck" ,ghc-quickcheck)
> + ("ghc-split-cabal-update"
> + ,(origin
> + (method url-fetch)
> + (uri (string-append
> + "https://hackage.haskell.org/package/split-"
> + version "/revision/1.cabal"))
> + (sha256
> + (base32
> + "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
> (home-page "http://hackage.haskell.org/package/split")
> (synopsis
> "Combinator library for splitting lists")
Similarly to the xmonad cabal patch, perhaps this could be addressed with
#:configure-flags '("--allow-newer=base")
with an appropriate comment. Otherwise using an origin snippet.
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: ghc-split: Update dependencies.
2015-10-22 8:47 ` [PATCH] gnu: ghc-split: Update dependencies ericbavier
@ 2015-10-22 16:16 ` Paul van der Walt
2015-10-22 17:06 ` Eric Bavier
0 siblings, 1 reply; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 16:16 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (arguments
>> + `(#:phases
>> + (modify-phases %standard-phases
>> + (add-before
>> + 'configure 'update-cabal
>> + ;; the cabal file on hackage is updated, but the tar.gz does not
>> + ;; include it.
>> + (lambda* _
>> + (copy-file (assoc-ref %build-inputs "ghc-split-cabal-update")
>> + "split.cabal"))))))
>> (inputs
>> - `(("ghc-quickcheck" ,ghc-quickcheck)))
>> + `(("ghc-quickcheck" ,ghc-quickcheck)
>> + ("ghc-split-cabal-update"
>> + ,(origin
>> + (method url-fetch)
>> + (uri (string-append
>> + "https://hackage.haskell.org/package/split-"
>> + version "/revision/1.cabal"))
>> + (sha256
>> + (base32
>> + "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>> (home-page "http://hackage.haskell.org/package/split")
>> (synopsis
>> "Combinator library for splitting lists")
>
> Similarly to the xmonad cabal patch, perhaps this could be addressed with
>
> #:configure-flags '("--allow-newer=base")
Nope, that option doesn't exist, i've checked.
> with an appropriate comment. Otherwise using an origin snippet.
I've made it into a (substitute* "split.cabal" ..) which simply updates
the version number of base ("base <4.8" → "base <4.9"), in accordance
with the change on Hackage. A comment is provided.
The patches responding to your latest batch of comments have been pushed
to the wip-haskell-… branch.
Thanks again!
p.
^ permalink raw reply [flat|nested] 81+ messages in thread* Re: [PATCH] gnu: ghc-split: Update dependencies.
2015-10-22 16:16 ` Paul van der Walt
@ 2015-10-22 17:06 ` Eric Bavier
2015-10-22 17:26 ` Paul van der Walt
0 siblings, 1 reply; 81+ messages in thread
From: Eric Bavier @ 2015-10-22 17:06 UTC (permalink / raw)
To: Paul van der Walt; +Cc: guix-devel
On 2015-10-22 11:16, Paul van der Walt wrote:
> On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>>> + (arguments
>>> + `(#:phases
>>> + (modify-phases %standard-phases
>>> + (add-before
>>> + 'configure 'update-cabal
>>> + ;; the cabal file on hackage is updated, but the tar.gz
>>> does not
>>> + ;; include it.
>>> + (lambda* _
>>> + (copy-file (assoc-ref %build-inputs
>>> "ghc-split-cabal-update")
>>> + "split.cabal"))))))
>>> (inputs
>>> - `(("ghc-quickcheck" ,ghc-quickcheck)))
>>> + `(("ghc-quickcheck" ,ghc-quickcheck)
>>> + ("ghc-split-cabal-update"
>>> + ,(origin
>>> + (method url-fetch)
>>> + (uri (string-append
>>> + "https://hackage.haskell.org/package/split-"
>>> + version "/revision/1.cabal"))
>>> + (sha256
>>> + (base32
>>> +
>>> "1i1h5v1zqvganhzy1wdd9r648yjpir078n0g8051njg82h2f964h"))))))
>>> (home-page "http://hackage.haskell.org/package/split")
>>> (synopsis
>>> "Combinator library for splitting lists")
>>
>> Similarly to the xmonad cabal patch, perhaps this could be addressed
>> with
>>
>> #:configure-flags '("--allow-newer=base")
>
> Nope, that option doesn't exist, i've checked.
>
>> with an appropriate comment. Otherwise using an origin snippet.
>
> I've made it into a (substitute* "split.cabal" ..) which simply updates
> the version number of base ("base <4.8" → "base <4.9"), in accordance
> with the change on Hackage. A comment is provided.
OK
> The patches responding to your latest batch of comments have been
> pushed
> to the wip-haskell-… branch.
Great! I'll take one last look, then I think we can merge. WDYT?
--
`~Eric
^ permalink raw reply [flat|nested] 81+ messages in thread
* Re: [PATCH] gnu: Add ghc-gluraw.
2015-10-22 8:47 ` [PATCH] gnu: Add ghc-gluraw ericbavier
` (21 preceding siblings ...)
2015-10-22 8:47 ` [PATCH] gnu: ghc-split: Update dependencies ericbavier
@ 2015-10-22 14:21 ` Paul van der Walt
22 siblings, 0 replies; 81+ messages in thread
From: Paul van der Walt @ 2015-10-22 14:21 UTC (permalink / raw)
To: ericbavier; +Cc: guix-devel
On 2015-10-22 at 10:47, quoth ericbavier@openmailbox.org:
>> + (synopsis
>> + "Raw bindings for the OpenGL graphics system")
>
> How about: "Raw Haskell bindings for GLU"
Done!
^ permalink raw reply [flat|nested] 81+ messages in thread