From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] GCJ: run libjava tests. Date: Thu, 22 Oct 2015 14:33:45 +0200 Message-ID: <20151022123345.GA7846@debian> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpF42-0004Yd-R6 for guix-devel@gnu.org; Thu, 22 Oct 2015 08:33:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZpF3z-0008QK-Ld for guix-devel@gnu.org; Thu, 22 Oct 2015 08:33:50 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:51418) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZpF3z-0008P3-CI for guix-devel@gnu.org; Thu, 22 Oct 2015 08:33:47 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel Hello, On Thu, Oct 22, 2015 at 01:07:25PM +0200, Ricardo Wurmus wrote: > ((#:phases phases) > `(modify-phases ,phases > + (replace 'check > + (lambda _ (zero? (system* "make" "check-target-libjava")))) Could this be replaced by #:test-target "check-target-libjava" ? Apart from that, your patch looks very useful. Andreas