unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] GCJ: run libjava tests.
Date: Thu, 22 Oct 2015 14:33:45 +0200	[thread overview]
Message-ID: <20151022123345.GA7846@debian> (raw)
In-Reply-To: <idjtwpjxitu.fsf@bimsb-sys02.mdc-berlin.net>

Hello,

On Thu, Oct 22, 2015 at 01:07:25PM +0200, Ricardo Wurmus wrote:
>         ((#:phases phases)
>          `(modify-phases ,phases
> +           (replace 'check
> +            (lambda _ (zero? (system* "make" "check-target-libjava"))))

Could this be replaced by
   #:test-target "check-target-libjava"
? Apart from that, your patch looks very useful.

Andreas

  reply	other threads:[~2015-10-22 12:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-22 11:07 [PATCH] GCJ: run libjava tests Ricardo Wurmus
2015-10-22 12:33 ` Andreas Enge [this message]
2015-10-22 13:41   ` Ricardo Wurmus
2015-10-22 14:58     ` Ricardo Wurmus
2015-10-23  8:30       ` Andreas Enge
2015-10-25 21:48       ` Ludovic Courtès
2015-10-27 10:59         ` Ricardo Wurmus
2015-10-27 12:28           ` Ludovic Courtès
2015-10-27 14:39             ` Ricardo Wurmus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151022123345.GA7846@debian \
    --to=andreas@enge.fr \
    --cc=guix-devel@gnu.org \
    --cc=ricardo.wurmus@mdc-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).