From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 03/43] gnu: xmonad: Patch to work on new Haskell Platform
Date: Wed, 21 Oct 2015 17:08:22 -0500
Message-ID: <20151021170822.381d2d08@openmailbox.org>
References: <1444911697-15515-1-git-send-email-paul@denknerd.org>
	<1444911697-15515-3-git-send-email-paul@denknerd.org>
	<20151019083608.2115296f@openmailbox.org>
	<87h9ll4pgk.fsf@denknerd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53770)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1Zp694-0001f3-Cb
	for guix-devel@gnu.org; Wed, 21 Oct 2015 23:02:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1Zp690-0006AT-Ca
	for guix-devel@gnu.org; Wed, 21 Oct 2015 23:02:26 -0400
Received: from smtp27.openmailbox.org ([62.4.1.61]:53568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1Zp690-0006AK-3o
	for guix-devel@gnu.org; Wed, 21 Oct 2015 23:02:22 -0400
In-Reply-To: <87h9ll4pgk.fsf@denknerd.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Paul van der Walt <paul@denknerd.org>
Cc: guix-devel@gnu.org

On Tue, 20 Oct 2015 15:52:27 +0200
Paul van der Walt <paul@denknerd.org> wrote:

> 
> On 2015-10-19 at 15:36, quoth Eric Bavier:
> >> +       ("xmonad-cabal-patch"
> >> +        ,(origin
> >> +           (method url-fetch)
> >> +           (uri (string-append
> >> +                 "https://hackage.haskell.org/package/xmonad-" version "/revision/1.cabal"))
> >> +           (sha256
> >> +            (base32
> >> +             "0gdzsn2mv45i67wzmcjxyljr2w9fccc19n0i0f69mwvwcgi9v10j"))))))
> >
> > Could this instead be formulated as a patch, rather than a complete
> > file overwrite?  A diff would help in understanding the rationale for
> > the change.
> 
> It could, but since hackage provides this new Cabal file, it seemed
> "cleanest" to not re-implement it as a patch.  If you prefer, i could do
> one of two things:
> 
> * Add a comment explaining that the patch simply changed the library
>   component's dependency on utf8-string from
> 
>      >=0.3 && <0.4
> 
>   to
> 
>      >=0.3 && <1.1
> 
> or,
> 
> * Add that as a "(substitute ...)" type patch.
> 
> My thinking was that the fact that this new Cabal file comes from
> Hackage lends it a certain "credibility", whereas otherwise it might
> look like i'm arbitrarily modifying the Cabal file to make it compile.
> I admit that this was also the easier approach, it seemed to me.

I think passing '#:configure-flags '("--allow-newer=utf8-string")' in
arguments might do the trick.

Otherwise, the "(substitute* ...)" approach, with a comment, seems
clearest to me.

WDYT?

Thanks for working on it,
`~Eric