From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 1/2] gnu: Add ghc-transformers Date: Mon, 12 Oct 2015 18:28:09 -0500 Message-ID: <20151012182809.0d494eb5@openmailbox.org> References: <1444595036-20254-1-git-send-email-james.trotter@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlr5L-0001nP-0q for guix-devel@gnu.org; Tue, 13 Oct 2015 00:21:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zlr5H-0004qe-0u for guix-devel@gnu.org; Tue, 13 Oct 2015 00:21:11 -0400 Received: from smtp7.openmailbox.org ([62.4.1.41]:37285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zlr5G-0004q1-OV for guix-devel@gnu.org; Tue, 13 Oct 2015 00:21:06 -0400 In-Reply-To: <1444595036-20254-1-git-send-email-james.trotter@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: James David Trotter Cc: guix-devel@gnu.org Hello James, Thanks for the patch. Comments inline. On Sun, 11 Oct 2015 22:23:55 +0200 James David Trotter wrote: > * gnu/packages/haskell.scm (ghc-transformers): New variable. > --- > gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) Could you please add a copyright statement for yourself at the top of gnu/packages/haskell.scm? > diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm > index 34cad87..33d58f4 100644 > --- a/gnu/packages/haskell.scm > +++ b/gnu/packages/haskell.scm > @@ -458,6 +458,30 @@ Haskell software by automating the fetching, configuration, compilation and > installation of Haskell libraries and programs.") > (license bsd-3))) > > +(define-public ghc-transformers > + (package > + (name "ghc-transformers") > + (version "0.4.3.0") > + (outputs '("out" "doc")) Although other ghc packages in haskell.scm include these two outputs, the "out" output very often ends up referencing the "doc" output, so both end up installed in practice, so it should be safe to remove this field. > + (source > + (origin > + (method url-fetch) > + (uri (string-append > + "http://hackage.haskell.org/package/transformers/transformers-" > + version > + ".tar.gz")) > + (sha256 > + (base32 "179sbhvc9dghyw58hz80109pbrzgh7vh437227a51jhmx2bsgl5k")))) > + (build-system haskell-build-system) > + (home-page "http://hub.darcs.net/ross/transformers") This is the repository page. Perhaps the hackage.haskell.org address would be more appropriate, as many other packages use. WDYT? > + (synopsis "Concrete functor and monad transformers") > + (description > + "A portable library of functor and monad transformers, inspired by the > +paper \"Functional Programming with Overloading and Higher-Order > +Polymorphism\", by Mark P Jones, in Advanced School of Functional Programming, > +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).") Descriptions can now optionally include texinfo markup, so maybe that last could be "@url{http://web.cecs.pdx.edu/...}" > + (license bsd-3))) > + > (define-public ghc-mtl > (package > (name "ghc-mtl") Otherwise looks good. Could you send an updated patch? `~Eric