From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: 01/02: gnu: libbluray: Upgrade to 0.9.1. Date: Tue, 6 Oct 2015 20:28:59 +0300 Message-ID: <20151006202859.709f8811@debian-netbook> References: <20151006122208.24501.87369@vcs.savannah.gnu.org> <87y4fgkllm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/.VPQPfmeFbQjj.T77eSLEMX"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:50523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZjW3A-0002Bh-5g for guix-devel@gnu.org; Tue, 06 Oct 2015 13:29:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZjW35-0005zd-GA for guix-devel@gnu.org; Tue, 06 Oct 2015 13:29:16 -0400 In-Reply-To: <87y4fgkllm.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel@gnu.org --Sig_/.VPQPfmeFbQjj.T77eSLEMX Content-Type: multipart/mixed; boundary="MP_/WpSv5/vdUWKlzoxbLyQY6nQ" --MP_/WpSv5/vdUWKlzoxbLyQY6nQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Tue, 06 Oct 2015 18:28:21 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > Efraim Flashner skribis: >=20 > > commit 3f9f176b3a98a8c7dedb40f7fd14e8b5b3f45906 > > Author: Efraim Flashner > > Date: Tue Oct 6 15:04:12 2015 +0300 > > > > gnu: libbluray: Upgrade to 0.9.1. > > =20 > > * gnu/packages/video.scm (libbluray): Upgrade to 0.9.1. > > [inputs]: Add "ant" and "icedtea7" to native-inputs. > > [arguments]: Set environment variable "JAVA_HOME". >=20 > Do you know what libbluray uses Java for? Truthfully, I'm not too sure. I have the commit for checking to make sure it was available (https://git.videolan.org/?p=3Dlibbluray.git;a=3Dcommitdiff;h=3D84ffa5d2e36= a5b92dbd8cdeee1e9dc332dcf1b57) and I've checked their mailinglist, but no discussion around it being there. =20 > I think it would be good to be able to watch videos without having to > pull Icedtea and its dependencies, if possible. Agreed, which is why I stuck it in native-inputs, drawing from java.scm as inspiration. =20 > Thanks, > Ludo=E2=80=99. It turns out I typo'd in the commit message, the version is 0.9.0 and not 0.9.1. I dug around in configure.ac a bit more and found a flag to not require ant and java at compile time, and would have the package at the same state it was at pre-update in terms of java support. -Efraim --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --MP_/WpSv5/vdUWKlzoxbLyQY6nQ Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-libbluray-Remove-java-as-native-input.patch =46rom 2da45ebe56e4ac9821ae0f563346c97b3819d1df Mon Sep 17 00:00:00 2001 From: Efraim Flashner Date: Tue, 6 Oct 2015 20:22:09 +0300 Subject: [PATCH] gnu: libbluray: Remove java as native-input. * gnu/packages/video.scm (libbluray)[inputs]: Remove "ant" and "icedtea" as native-inputs. [arguments]: Remove environmental variable "JAVA_HOME". Add configure flag to disable java. --- gnu/packages/video.scm | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index c36d7a8..5ec225e 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -51,7 +51,6 @@ #:use-module (gnu packages gnupg) #:use-module (gnu packages gtk) #:use-module (gnu packages image) - #:use-module (gnu packages java) #:use-module (gnu packages linux) #:use-module (gnu packages lua) #:use-module (gnu packages mp3) @@ -823,16 +822,8 @@ YouTube.com and a few more sites.") (base32 "0kb9znxk6610vi0fjhqxn4z5i98nvxlsz1f8dakj99rg42livdl4")))) (build-system gnu-build-system) - (arguments=20 - `(#:phases - (modify-phases %standard-phases - (add-after 'configure 'java-home - (lambda* (#:key inputs #:allow-other-keys) - (setenv "JAVA_HOME" (assoc-ref inputs "icedtea7")) - #t))))) - (native-inputs `(("ant" ,ant) - ("icedtea7" ,icedtea7 "jdk") - ("pkg-config" ,pkg-config))) + (arguments `(#:configure-flags '("--disable-bdjava"))) + (native-inputs `(("pkg-config" ,pkg-config))) (inputs `(("doxygen" ,doxygen) ("fontconfig" ,fontconfig) --=20 2.6.1 --MP_/WpSv5/vdUWKlzoxbLyQY6nQ-- --Sig_/.VPQPfmeFbQjj.T77eSLEMX Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJWFATcAAoJEPTB05F+rO6TGFAP/2boRpLv7fbFd2qVHQIFXl0C FzzSEkbZLbOaBokcIETLUsxzc7ZEuKj79MPF/yw35W9k1F1dkuz4R9NjxiULGBNL VxNLqLCvZApmB5bCwNzjq1rjm6VGxfGGhlJ6o6FPS4lDMvJuFbrQhJKk3a6B41cL CvtuTZ9ZQMEPUpNHGMX+L+8Dwd8FRhQjRvPVtq0WkdD7ai9kfaan3lABmqC1CQ0p GjtqImHSkSSuFEDPQsSnlxA7lsqbfiDynPnxyXhBiUfKJrPpKl2q3JQB5sz4O6O1 jxhw+2tkU0w7UTTtd56ncqv6N7NXnpY5PQoGGj7oZV6HxI01U9fsZcCdJ9v6nnHX z0NGHyoso17u27mwzvcSekf0ntLO9yzGxLuoUZkuaUfPvhsxcNCtww+92KVPFMpu jJS1+ViW9W7AaenJE8fKgXfP4LcpClsyyj5LV/tDyvPnai03WnQl6X2lFgSuUAkR p30TVjQx7BJWs3AvVIGlmfTkj2+HqMB4Uxj/yMZq4/YCAk3LagSitlcQi4rXZ2pd TszvZK8VzE3A8DaX2dpeBhgz41NTGCvkeMTA49VGJSWElVpWxCX59nqODVZFk0V4 ZudmJsZiUJFFrYbqhbMIAeuy4ByZvGWQnAzdstA2l4Rs6R5x/U7hqjYFhI5m9fqC XbTpCMGrssjhzSbB3S4u =UDDM -----END PGP SIGNATURE----- --Sig_/.VPQPfmeFbQjj.T77eSLEMX--