Re: [PATCH] Add Blender

[Eric Bavier <ericbavier@openmailbox.org>]

Hello Ricardo,

Just some nitpicks:

> From d1d46f01d7aad783f7931be1ea4bbdffb21fd9b7 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Sat, 5 Sep 2015 12:34:09 +0200
> Subject: [PATCH 1/2] gnu: Add openimageio.
> 
> * gnu/packages/graphics.scm (openimageio): New variable.
> ---
>  gnu/packages/graphics.scm | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
> 
> diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
> index 14badc9..d9d1f26 100644
> --- a/gnu/packages/graphics.scm
> +++ b/gnu/packages/graphics.scm
> @@ -130,6 +130,44 @@ use in computer imaging applications.  The IlmImf C++ libraries support
>  storage of the \"EXR\" file format for storing 16-bit floating-point images.")
>      (license license:bsd-3)))
>  
> +(define-public openimageio
> +  (package
[...]
> +    (description
> +      "OpenImageIO is a library for reading and writing images, and a bunch of
        ^
Align the opening quote to the 'd'.


> From 6e9eba597d5588f845ccec6507ad1b7e987ba659 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <rekado@elephly.net>
> Date: Thu, 3 Sep 2015 14:17:34 +0200
> Subject: [PATCH 2/2] gnu: Add Blender.
> 
> * gnu/packages/graphics.scm (blender): New variable.
> ---
>  gnu/packages/graphics.scm | 67 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 67 insertions(+)
[...]
> +(define-public blender
> +  (package
> +    (name "blender")
> +    (version "2.75a")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "http://download.blender.org/source/"
> +                                  "blender-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "09lxb2li70p6fg7hbakin9ffy3b3101c1gdjqi3pykks5q3h9sq4"))))
> +    (build-system cmake-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'disable-broken-tests
> +          (lambda _
> +            (substitute* "tests/python/CMakeLists.txt"
> +              (("# PLY Import tests") "if(FALSE)")
> +              (("# PLY Export")       "endif()"))
> +            #t))
> +         (add-after 'unpack 'fix-broken-import
> +          (lambda _
> +            (substitute* "release/scripts/addons/io_scene_fbx/json2fbx.py"
> +              (("import encode_bin") "from . import encode_bin"))
> +            #t))
> +         (add-after 'set-paths 'add-ilmbase-include-path
> +          (lambda* (#:key inputs #:allow-other-keys)
> +            ;; OpenEXR propagates ilmbase, but its include files do not appear
> +            ;; in the CPATH, so we need to add "$ilmbase/include/OpenEXR/" to
> +            ;; the CPATH to satisfy the dependency on "half.h".
> +            (setenv "CPATH"
> +                    (string-append (assoc-ref inputs "ilmbase")
> +                                   "/include/OpenEXR"
> +                                   ":" (getenv "CPATH")))

Is the "half.h" header in OpenEXR, or in blender?  If the latter, would
it make more sense to instead patch the include directive to include
the OpenEXR path?

Otherwise LGTM.

`~Eric