unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Pjotr Prins <pjotr.public12@thebird.nl>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add ruby-docile.
Date: Thu, 17 Sep 2015 07:19:27 +0200	[thread overview]
Message-ID: <20150917051927.GA9866@thebird.nl> (raw)
In-Reply-To: <87mvwm7let.fsf@elephly.net>

Do you mind just editing this patch your way? The description comes
from the package website - I don't feel the urge to improve on it.

Pj.

On Wed, Sep 16, 2015 at 11:39:38AM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
> 
> > * gnu/packages/ruby.scm (ruby-docile): New variable.
> 
> [...]
> 
> > +    (arguments
> > +     '(#:tests? #f)) ; needs github-markup, among others
> 
> There also is at least one nasty dependency cycle which should be
> mentioned.  A development dependency is ruby-coveralls, which needs
> ruby-simplecov at runtime, which in turn needs ruby-docile at runtime.
> 
> Other dev dependencies are ruby-github-markdown, ruby-redcarpet, and
> ruby-rspec.  (I’ve been working on the same package but went down the
> rabbit hole, depth first.)
> 
> > +    (synopsis "Docile turns any Ruby object into a DSL")
> > +    (description "Turn any Ruby object into a DSL.  Especially useful
> > +with the Builder pattern.  Docile is a small, self-contained Ruby
> > +library, that let's you map a DSL (domain specific language) to your
> > +Ruby objects in a snap.")
> 
> This description is not very helpful, probably because the first two
> sentences are just fragments.  The last sentence is okay, except for the
> “in a snap”, IMO.
> 
> > +    (home-page "https://ms-ati.github.io/docile/")
> > +    (license license:expat)))
> > +
> >  (define-public ruby-gherkin3
> >    (package
> >      (name "ruby-gherkin3")
> > @@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by all Cucumber
> >  implementations to parse '.feature' files.")
> >      (home-page "https://github.com/cucumber/gherkin3")
> >      (license license:expat)))
> > +
> 
> Oh, an additional newline in the middle of “ruby-gherkin3”?  Did
> something go wrong when cutting out the patch amidst other changes?
> 
> ~~ Ricardo
> 

-- 

  reply	other threads:[~2015-09-17  5:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  4:06 [PATCH 1/2] gnu: Add ruby-docile Pjotr Prins
2015-09-16  9:39 ` Ricardo Wurmus
2015-09-17  5:19   ` Pjotr Prins [this message]
2015-09-19 12:37 ` Thompson, David

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917051927.GA9866@thebird.nl \
    --to=pjotr.public12@thebird.nl \
    --cc=guix-devel@gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).