Re: [PATCH] gnu: Add ruby-bio-logger.

[Pjotr Prins <pjotr.public12@thebird.nl>]

[-- Attachment #1: Type: text/plain, Size: 1887 bytes --]

Hopefully OK now.

On Wed, Sep 16, 2015 at 06:02:59PM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
> 
> > * gnu/packages/ruby.scm (ruby-bio-logger): New variable.
> 
> [...]
>   
> > +(define-public ruby-bio-logger
> > +  (package
> > +    (name "ruby-bio-logger")
> > +    (version "1.0.1")
> > +    (source
> > +      (origin
> > +        (method url-fetch)
> > +        (uri (rubygems-uri "bio-logger" version))
> > +        (sha256
> > +          (base32
> > +            "02pylfy8nkdqzyzplvnhn1crzmfkj1zmi3qjhrj2f2imlxvycd28"))))
> 
> This opening quote of this string should be aligned with the “b” in
> “base64”.  Likewise, the opening parenthesis of “(base32 ...)” should be
> aligned with the “s” in “(sha256 ...)”, and “(origin” should be aligned
> with the “s” of “(source”.
> 
> Are you using Emacs to indent?  In many cases you can just use ‘M-x
> indent-sexp’.
> 
> > +    (build-system ruby-build-system)
> > +    (propagated-inputs `(("ruby-log4r" ,ruby-log4r)))
> > +    (arguments
> > +     '(#:tests? #f)) ; no test suite
> > +    (synopsis "Log4r wrapper for Ruby with extra features")
> > +    (description "Library with extra logging features on top of
> > +ruby-log4r (not specific to bioinformatics)")
> 
> This is not a complete description as it is not a full sentence.  A
> minimal description might be
> 
>   “Bio-logger is a wrapper around Log4r adding extra logging features
> such as x, y, and z.”
> 
> The README at the Github site is rather detailed; mentioning a few of
> the added features in the description would be nice.
> 
> > +    (home-page "https://github.com/pjotrp/bioruby-logger-plugin")
> > +    (license license:expat)))
> > +
> >  (define-public ruby-atoulme-antwrap
> >    (package
> >      (name "ruby-atoulme-antwrap")
> 
> ~~ Ricardo
> 

-- 

[-- Attachment #2: 0001-gnu-Add-ruby-bio-logger.patch --]
[-- Type: text/x-diff, Size: 1418 bytes --]

From 4acfc340705bd2a9e91f9b7a74ccf93a27185b17 Mon Sep 17 00:00:00 2001
Date: Wed, 16 Sep 2015 06:06:26 +0000
Subject: [PATCH] gnu: Add ruby-bio-logger.
To: guix-devel@gnu.org
From: Pjotr Prins <pjotr.public12@thebird.nl>

* gnu/packages/ruby.scm (ruby-bio-logger): New variable.
---
 gnu/packages/ruby.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
index 7dc46b6..be44bed 100644
--- a/gnu/packages/ruby.scm
+++ b/gnu/packages/ruby.scm
@@ -1147,3 +1147,22 @@ It is intended to replace Gherkin 2 and be used by all Cucumber
 implementations to parse '.feature' files.")
     (home-page "https://github.com/cucumber/gherkin3")
     (license license:expat)))
+
+(define-public ruby-bio-logger
+  (package
+    (name "ruby-bio-logger")
+    (version "1.0.1")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (rubygems-uri "bio-logger" version))
+        (sha256
+         (base32
+          "02pylfy8nkdqzyzplvnhn1crzmfkj1zmi3qjhrj2f2imlxvycd28"))))
+    (build-system ruby-build-system)
+    (propagated-inputs `(("ruby-log4r" ,ruby-log4r)))
+    (synopsis "Log4r wrapper for Ruby")
+    (description "Bio-logger is a wrapper around Log4r adding extra
+logging features such as filtering and fine grained logging.")
+    (home-page "https://github.com/pjotrp/bioruby-logger-plugin")
+    (license license:expat)))
-- 
2.4.3