From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pjotr Prins Subject: Re: [PATCH] gnu: Add ruby-bio-locus. Date: Mon, 14 Sep 2015 16:18:52 +0200 Message-ID: <20150914141852.GA29936@thebird.nl> References: <20150914132433.GA29632@thebird.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbUcs-0003cD-RJ for guix-devel@gnu.org; Mon, 14 Sep 2015 10:21:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZbUcn-0007PQ-3m for guix-devel@gnu.org; Mon, 14 Sep 2015 10:20:58 -0400 Received: from mail.thebird.nl ([95.154.246.10]:50886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZbUcm-0007Om-VZ for guix-devel@gnu.org; Mon, 14 Sep 2015 10:20:53 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: "Thompson, David" Cc: guix-devel I am at the biohackathon in Japan - planning to submit more of these. Many people here are interested in our work :) http://2015.biohackathon.org/hackathon OK, yes, it probably belongs in bioinformatics.scm. Note the gem contains tests that pass ;). I love the abstraction that guix offers for gems. I added to https://github.com/pjotrp/guix-notes/blob/master/RUBY.org#adding-a-ruby-gem-to-guix Pj. On Mon, Sep 14, 2015 at 10:01:40AM -0400, Thompson, David wrote: > On Mon, Sep 14, 2015 at 9:24 AM, Pjotr Prins wrote: > > * gnu/packages/ruby.scm (ruby-bio-locus): New variable. > > Awesome! Just a couple of minor comments below. > > > --- > > gnu/packages/ruby.scm | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > > index ee0acc8..0a0fc1a 100644 > > --- a/gnu/packages/ruby.scm > > +++ b/gnu/packages/ruby.scm > > @@ -1124,3 +1124,23 @@ it unifies the API for web servers, web frameworks, and software in between > > into a single method call.") > > (home-page "http://rack.github.io/") > > (license license:expat))) > > + > > +(define-public ruby-bio-locus > > + (package > > + (name "ruby-bio-locus") > > This is an application, not a library, correct? If so, I think it > would be best to name it just "bio-locus" and put it in the (gnu > packages bioinformatics) module. WDYT? > > > + (version "0.0.7") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (rubygems-uri "bio-locus" version)) > > + (sha256 > > + (base32 > > + "02vmrxyimkj9sahsp4zhfhnmbvz6dbbqz1y01vglf8cbwvkajfl0")))) > > + (build-system ruby-build-system) > > + (native-inputs > > + `(("ruby-rspec" ,ruby-rspec))) > > + (synopsis "Tool for fast querying of genome locations") > > + (description "This tabix-like tool essentially allows your to > > +store this chr+pos or chr+pos+alt information in a fast database.") > > How about something more descriptive? Here's a modified snippet from > your README: > > Bio-locus is a tool for fast querying of genome locations. > Many file formats in bioinformatics contain records that start with a > chromosome name and a position for a SNP, or a start-end position > for indels. > Bio-locus allows users to store this chr+pos or chr+pos+alt information in a > fast database. > > > + (home-page "https://github.com/pjotrp/bio-locus") > > + (license license:expat))) > > -- > > 2.4.3 > > > > Thanks! Keep 'em coming! > > - Dave > --