From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] Add MAFFT.
Date: Mon, 7 Sep 2015 10:55:19 +0200
Message-ID: <20150907085519.GA4513@debian>
References: <55B0E173.1030406@uq.edu.au> <876158xcoo.fsf@mdc-berlin.de>
	<55B44F96.8050808@uq.edu.au> <20150726094338.GA24898@debian>
	<20150726102915.GA32496@debian> <55BBF9E6.50403@uq.edu.au>
	<87d1ybhypp.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45678)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1ZYsD5-00019r-KK
	for guix-devel@gnu.org; Mon, 07 Sep 2015 04:55:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1ZYsD1-0006W6-Ka
	for guix-devel@gnu.org; Mon, 07 Sep 2015 04:55:31 -0400
Content-Disposition: inline
In-Reply-To: <87d1ybhypp.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-15?Q?Court=E8s?= <ludo@gnu.org>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>

On Tue, Aug 25, 2015 at 10:58:42PM +0200, Ludovic Courtès wrote:
> It seems this message was left unanswered.  Andreas?

I had a cursory look at the patch, here are some comments:

On Thu, Jul 23, 2015 at 10:43:31PM +1000, Ben Woodcroft wrote:
> +       #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
> +                          (string-append "BINDIR=" (string-append
> +                                                    (assoc-ref %outputs "out")
> +                                                    "/bin")))

Would it make sense to include this into a 
  (let ((out (assoc-ref %outputs out))) ...)
?

> +         (add-after 'enter-dir 'patch-makefile
> +                    (lambda _
> +                      (substitute* "Makefile"
> +                        (("^SCRIPTS = mafft mafft-homologs.rb")
> +                         "SCRIPTS = mafft")
> +                        (((string-append "^PROGS = dvtditr dndfast7 dndblast"
> +                                         " sextet5 mafft-distance"))
> +                         "PROGS = dvtditr dndfast7 dndblast sextet5")

This "string-append" to concatenate two literal strings is difficult to read;
I would suggest to move the "(lambda" more to the left so that everything
fits into one line.

> +    (synopsis
> +     "Multiple sequence alignment program for unix-like operating systems")

Maybe drop "for unix-like operating systems"; instead, you could add
"for nucleotide and protein sequences" from the description.

> +protein sequences.  For instance, it offers L-INS-i (accurate; for alignment
> +of <???200 sequences) and FFT-NS-2 (fast; for alignment of <???30,000

Is this an artefact of the mailer?

I did not check whether the package passes "guix lint".

Could you send an updated patch?

Andreas