Re: [PATCH 1/2] gnu: Add eyed3.

[Efraim Flashner <efraim@flashner.co.il>]

[-- Attachment #1.1: Type: text/plain, Size: 1982 bytes --]

On Mon, 24 Aug 2015 18:48:04 -0400
Mark H Weaver <mhw@netris.org> wrote:

> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > On Thu, 20 Aug 2015 17:50:10 +0800
> > 宋文武 <iyzsong@gmail.com> wrote:
> >
> >> Efraim Flashner <efraim@flashner.co.il> writes:
> >> 
> >> eyeD3 is both a tool and python library, I wonder whether
> >> 'python-eyed3' fits better.
> >
> > 'python-eyed3' is probably a better name. I wonder perhaps as a python
> > library it should be in python.scm instead of mp3.scm. Anyone have a
> > suggestion on that front?
> 
> If it includes a library, then I think it should be named
> 'python-eyed3'.  This is our usual convention, and it has the advantage
> that we can add 'python2-eyed3' later, in case someone wants it.

Changed the package to python-eyed3 and moved it to python.scm.

> 
> Also, your mail client seems to have applied word-wrapping to the patch,
> so some of the "+" signs have been wrapped into the description.  This
> is what I see:
> 
> --8<---------------cut here---------------start------------->8---
> +    (description
> +     "Eyed3 is a command-line editor to add/edit/remove ID3-tags on mp3
> files. +It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard.
> Additionally it +displays several information about the file such as length
> and bitrate from an +MP3 file.")
> --8<---------------cut here---------------end--------------->8---
> 
> This makes it difficult for us to apply it, since we'd have to fix it up
> by hand.  Can you persuade your mail client to avoid word-wrapping?  You
> could make it an attachment if needed.
> 
>      Thanks!
>        Mark

I've turned off line wrapping so there shouldn't be any more wrapping in my email messages.

-- 
Efraim Flashner   <efraim@flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-Add-python-eyed3.patch --]
[-- Type: text/x-patch, Size: 1745 bytes --]

From b6830016d2bcd3cd68d7eec61f2627677141b13f Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Tue, 25 Aug 2015 10:16:43 +0300
Subject: [PATCH] gnu: Add python-eyed3.

* gnu/packages/python.scm (python-eyed3): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 940efec..6ef4303 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -4629,3 +4629,25 @@ term.js Javascript terminal emulator library.")
                  ,python2-backport-ssl-match-hostname)
                 ,@(alist-delete "python-tornado"
                                 (package-propagated-inputs terminado)))))))
+
+(define-public python-eyed3
+  (package
+    (name "python-eyed3")
+    (version "0.7.8")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://eyed3.nicfit.net/releases/eyeD3-"
+                                  version ".tar.gz"))
+              (sha256
+               (base32
+                "1nv7nhfn1d0qm7rgkzksbccgqisng8klf97np0nwaqwd5dbmdf86"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f)) ;fail with: UserWarning: Duplicate name: 'paver/shell.py'
+     (home-page "http://eyed3.nicfit.net/")
+     (synopsis "Display and manipulate id3-tags on mp3 files")
+     (description "Eyed3 is a command-line editor to add/edit/remove ID3-tags 
+on mp3 files.  It supports version 1.0, 1.1, 2.3 and 2.4 of the ID3 standard. 
+Additionally it displays several information about the file such as length and
+bitrate from an MP3 file.")
+    (license gpl2+)))
-- 
2.5.0


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]