From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Bavier <ericbavier@openmailbox.org>
Subject: Re: [PATCH 2/7] gnu: Add libyajl.
Date: Sun, 16 Aug 2015 18:27:44 -0500
Message-ID: <20150816182744.384d86a6@openmailbox.org>
References: <1439777162-7769-1-git-send-email-eric@dvorsak.fr>
	<1439777162-7769-2-git-send-email-eric@dvorsak.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37915)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZRBuG-0007WK-8d
	for guix-devel@gnu.org; Mon, 17 Aug 2015 00:20:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZRBuC-0004na-7n
	for guix-devel@gnu.org; Mon, 17 Aug 2015 00:20:20 -0400
Received: from smtp23.openmailbox.org ([62.4.1.57]:37616)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ericbavier@openmailbox.org>) id 1ZRBuB-0004my-V7
	for guix-devel@gnu.org; Mon, 17 Aug 2015 00:20:16 -0400
In-Reply-To: <1439777162-7769-2-git-send-email-eric@dvorsak.fr>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Eric Dvorsak <eric@dvorsak.fr>
Cc: guix-devel@gnu.org

On Mon, 17 Aug 2015 04:05:57 +0200
Eric Dvorsak <eric@dvorsak.fr> wrote:

> * gnu/packages/web.scm (libyajl): New variable.
> ---
>  gnu/packages/web.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>=20
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 48bfbc7..07054c2 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -6,6 +6,7 @@
>  ;;; Copyright =C2=A9 2015 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright =C2=A9 2015 Taylan Ulrich Bay=C4=B1rl=C4=B1/Kammer
> <taylanbayirli@gmail.com> ;;; Copyright =C2=A9 2015 Eric Bavier
> <bavier@member.fsf.org> +;;; Copyright =C2=A9 2015 Eric Dvorsak
> <eric@dvorsak.fr> ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -287,6 +288,24 @@ parse JSON formatted strings back into the C
> representation of JSON objects.") style API.")
>      (license l:expat)))
> =20
> +(define-public libyajl
> +  (package
> +    (name "libyajl")
> +    (version "2.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/lloyd/yajl/archive=
/" version ".tar.gz"))

Wrap this line to 80 characters.

It would also be nice to provide a "file-name" field so that the tarball
is put in the store with a meaningful name, rather than just
"2.1.0.tar.gz".  E.g.:

  (file-name (string-append name "-" version ".tar.gz"))

See the aardict package for an example.

> +              (sha256
> +               (base32
> +
> "0nmcqpaiq4pv7dymyg3n3jsd57yhp5npxl26a1hzw3m3lmj37drz"))))
> +    (build-system cmake-build-system)
> +    (home-page "https://lloyd.github.io/yajl/")
> +    (synopsis "C library for parsing JSON")
> +    (description "Yet Another JSON Library.  YAJL is a small
> +event-driven (SAX-style) JSON parser written in ANSI C, and a small
> +validating JSON generator.")
> +    (license isc)))
> +
>  (define-public libwebsockets
>    (package
>      (name "libwebsockets")

Otherwise looks good to me.

Thanks,
`~Eric