From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pjotr Prins <pjotr.public12@thebird.nl>
Subject: Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system
Date: Mon, 20 Jul 2015 08:37:21 +0200
Message-ID: <20150720063721.GA29471@thebird.nl>
References: <20150713134451.GA29236@thebird.nl> <87380lo5kz.fsf@gnu.org>
	<20150719092941.GA25934@thebird.nl> <877fpvnahp.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pjotr2015@thebird.nl>) id 1ZH4ie-0001em-3o
	for guix-devel@gnu.org; Mon, 20 Jul 2015 02:38:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pjotr2015@thebird.nl>) id 1ZH4ia-0006F8-VL
	for guix-devel@gnu.org; Mon, 20 Jul 2015 02:38:32 -0400
Content-Disposition: inline
In-Reply-To: <877fpvnahp.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@gnu.org>
Cc: guix-devel <guix-devel@gnu.org>

On Sun, Jul 19, 2015 at 10:44:18PM +0200, Ludovic Court=C3=A8s wrote:
> > On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Court=C3=A8s wrote:
> >> >      (zero? (system* "gem" "install" "--local"
> >> > -                    "--bindir" (string-append out "/bin")))))
> >> > +                    "--bindir" (string-append out "/bin") "--"
> >> > +                    (string-join (cond (null? gem-flags)('())(gem=
-flags)))))))

> My guess is that there are options like --bindir (maybe =E2=80=9C--docd=
ir=E2=80=9D?) for
> which =E2=80=9C--=E2=80=9D does not need to be added, and others for wh=
ich it is
> needed.  That=E2=80=99s why I left it out (also: users can easily add =E2=
=80=9C--=E2=80=9D but
> cannot remove it if it=E2=80=99s hard-coded.)

OK. Makes sense. Arguably, in that case the default options (--local,
--bindir) should be overridable too. But, as they are sensible, let's
leave it the way it is now. We'll just add "--" for every gem (it is
actually a pass-through of options to the underlying build system, so
I could have named it ext-flags, or something, and have a separate
gem-flags).

But I think the current version is fine. Next up the ruby-nokogiri
package.

Pj.