From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pjotr Prins Subject: Re: [PATCH] build: ruby: Add 'gem-flags' key to ruby build system Date: Sun, 19 Jul 2015 11:29:41 +0200 Message-ID: <20150719092941.GA25934@thebird.nl> References: <20150713134451.GA29236@thebird.nl> <87380lo5kz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGkvv-0002Se-G9 for guix-devel@gnu.org; Sun, 19 Jul 2015 05:30:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGkvs-0007uc-9Y for guix-devel@gnu.org; Sun, 19 Jul 2015 05:30:55 -0400 Content-Disposition: inline In-Reply-To: <87380lo5kz.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel On Sat, Jul 18, 2015 at 05:20:28PM +0200, Ludovic Court=C3=A8s wrote: > > (zero? (system* "gem" "install" "--local" > > - "--bindir" (string-append out "/bin"))))) > > + "--bindir" (string-append out "/bin") "--" > > + (string-join (cond (null? gem-flags)('())(gem-fl= ags))))))) >=20 > , and =E2=80=98gem-flags=E2=80=99 is not a procedure so it cannot be ca= lled. So > I=E2=80=99ve changed that, also removing the =E2=80=9C--=E2=80=9D. Pus= hed as 6e9f291. The "--" is required when gem-flags is passed in. It is optional when gem-flags is empty. Do you think gem authors should always prepend the "--" in front of the other options? I would think it is a builder thing if we can abstract it away. Right? If that is so, we can leave it there since it is harmless if gem-flags is empty. Pj.