From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Bavier Subject: Re: [PATCH 4/4] gnu: git: Add inputs for send-email. Date: Mon, 29 Jun 2015 20:46:09 -0500 Message-ID: <20150629204609.674b71bc@openmailbox.org> References: <1435459147-5159-1-git-send-email-ericbavier@openmailbox.org> <1435459147-5159-5-git-send-email-ericbavier@openmailbox.org> <87fv5aohh8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/DCkEsMVRufyXWeuFUcbIit=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9pB5-0000dr-LH for guix-devel@gnu.org; Tue, 30 Jun 2015 02:37:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9pB0-0008Vh-L8 for guix-devel@gnu.org; Tue, 30 Jun 2015 02:37:55 -0400 Received: from smtp19.openmailbox.org ([62.4.1.53]:48821) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9pB0-0008VP-9w for guix-devel@gnu.org; Tue, 30 Jun 2015 02:37:50 -0400 In-Reply-To: <87fv5aohh8.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?UTF-8?B?Q291cnTDqHM=?= Cc: guix-devel@gnu.org, Eric Bavier --MP_/DCkEsMVRufyXWeuFUcbIit= Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Mon, 29 Jun 2015 13:56:51 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > ericbavier@openmailbox.org skribis: >=20 > > From: Eric Bavier > > > > * gnu/packages/version-control.scm (git)[inputs]: Add > > perl-authen-sasl, perl-net-smtp-ssl, and perl-io-socket-ssl. > > [arguments]: Add #:modules argument with srfi-1. In 'split phase, > > wrap git-send-email. >=20 > [...] >=20 > > + #:modules ((guix build gnu-build-system) > > + (guix build utils) > > + (srfi srfi-1)) >=20 > Use %gnu-build-system-modules instead of listing modules explicitly. >=20 > > + ;; Tell 'git-send-email' where perl modules are. > > + (wrap-program (string-append out > > "/libexec/git-core/git-send-email") >=20 > It would be best to add a =E2=80=9Csend-email=E2=80=9D output specificall= y for that, > so we keep the size of the closure of =E2=80=9Cout=E2=80=9D under control= (2 MiB is > still 10% of the size of =E2=80=9Cout=E2=80=9D.) >=20 > > + `("PERL5LIB" ":" prefix > > + ,(map (lambda (o) (string-append o > > "/lib/perl5/site_perl")) > > + (delete-duplicates > > + (list > > + ,@(append-map > > + (lambda (p) > > + (let ((name (package-name p))) > > + `((assoc-ref inputs ,name) > > + ,@(map (match-lambda > > + ((label (? package? > > _) . _) > > + `(assoc-ref inputs > > + ,(string-appe= nd > > name "/" label)))) > > + > > (package-transitive-propagated-inputs p))))) > > + `(,perl-authen-sasl > > + ,perl-net-smtp-ssl > > + ,perl-io-socket-ssl))))))) >=20 > Could you move the part of ,@ to a top-level procedure? Updated patch attached. `~Eric --MP_/DCkEsMVRufyXWeuFUcbIit= Content-Type: text/plain Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0004-gnu-git-Add-inputs-for-send-email.patch RnJvbSA4NTBmMzY3MmVmMTkyMzU0ZDRiYWNhZDQ4ZmQ4NDA3OWRiMDg3NzVlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQ0KRnJvbTogRXJpYyBCYXZpZXIgPGJhdmllckBtZW1iZXIuZnNmLm9yZz4N CkRhdGU6IFNhdCwgMjcgSnVuIDIwMTUgMjE6MDY6NTMgLTA1MDANClN1YmplY3Q6IFtQQVRDSCA0 LzRdIGdudTogZ2l0OiBBZGQgaW5wdXRzIGZvciBzZW5kLWVtYWlsLg0KDQoqIGdudS9wYWNrYWdl cy92ZXJzaW9uLWNvbnRyb2wuc2NtIChwYWNrYWdlLXRyYW5zaXRpdmUtcHJvcGFnYXRlZC1sYWJl bHMqKQ0KICAocGFja2FnZS1wcm9wYWdhdGVkLWlucHV0LXJlZnMpOiBOZXcgcHJvY2VkdXJlcy4N CiAgKGdpdClbaW5wdXRzXTogQWRkIHBlcmwtYXV0aGVuLXNhc2wsIHBlcmwtbmV0LXNtdHAtc3Ns LCBhbmQgcGVybC1pby1zb2NrZXQtc3NsLg0KICBbb3V0cHV0c106IEFkZCBzZW5kLWVtYWlsIG91 dHB1dC4NCiAgW2FyZ3VtZW50c106IEFkZCAjOm1vZHVsZXMgYXJndW1lbnQgd2l0aCBzcmZpLTEu ICBJbiAnc3BsaXQgcGhhc2UsIHdyYXANCiAgZ2l0LXNlbmQtZW1haWwuDQotLS0NCiBnbnUvcGFj a2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbSB8IDQ5ICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKystLS0NCiAxIGZpbGUgY2hhbmdlZCwgNDYgaW5zZXJ0aW9ucygrKSwgMyBkZWxl dGlvbnMoLSkNCg0KZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy92ZXJzaW9uLWNvbnRyb2wuc2Nt IGIvZ251L3BhY2thZ2VzL3ZlcnNpb24tY29udHJvbC5zY20NCmluZGV4IDcxMTcxZTYuLjE1ZTZm YjYgMTAwNjQ0DQotLS0gYS9nbnUvcGFja2FnZXMvdmVyc2lvbi1jb250cm9sLnNjbQ0KKysrIGIv Z251L3BhY2thZ2VzL3ZlcnNpb24tY29udHJvbC5zY20NCkBAIC02MCw3ICs2MCw5IEBADQogICAj OnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyBjb21wcmVzc2lvbikNCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIHN3aWcpDQogICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcyB0Y2wpDQot ICAjOnVzZS1tb2R1bGUgKGdudSBwYWNrYWdlcykpDQorICAjOnVzZS1tb2R1bGUgKGdudSBwYWNr YWdlcykNCisgICM6dXNlLW1vZHVsZSAoaWNlLTkgbWF0Y2gpDQorICAjOnVzZS1tb2R1bGUgKHNy Zmkgc3JmaS0xKSkNCiANCiAoZGVmaW5lLXB1YmxpYyBiYXphYXINCiAgIChwYWNrYWdlDQpAQCAt OTcsNiArOTksMjMgQEAgY2hhbmdlcyB0byBwcm9qZWN0IGZpbGVzIG92ZXIgdGltZS4gIEl0IHN1 cHBvcnRzIGJvdGggYSBkaXN0cmlidXRlZCB3b3JrZmxvdw0KIGFzIHdlbGwgYXMgdGhlIGNsYXNz aWMgY2VudHJhbGl6ZWQgd29ya2Zsb3cuIikNCiAgICAgKGxpY2Vuc2UgZ3BsMispKSkNCiANCiso ZGVmaW5lIChwYWNrYWdlLXRyYW5zaXRpdmUtcHJvcGFnYXRlZC1sYWJlbHMqIHBhY2thZ2UpDQor ICAiUmV0dXJuIGEgbGlzdCBvZiB0aGUgaW5wdXQgbGFiZWxzIG9mIFBBQ0tBR0UgYW5kIGl0cyB0 cmFuc2l0aXZlIGlucHV0cy4iDQorICAobGV0ICgobmFtZSAocGFja2FnZS1uYW1lIHBhY2thZ2Up KSkNCisgICAgYCgsbmFtZQ0KKyAgICAgICxAKG1hcCAobWF0Y2gtbGFtYmRhDQorICAgICAgICAg ICAgICAgKChsYWJlbCAoPyBwYWNrYWdlPyBfKSAuIF8pDQorICAgICAgICAgICAgICAgIChzdHJp bmctYXBwZW5kIG5hbWUgIi8iIGxhYmVsKSkpDQorICAgICAgICAgICAgIChwYWNrYWdlLXRyYW5z aXRpdmUtcHJvcGFnYXRlZC1pbnB1dHMgcGFja2FnZSkpKSkpDQorDQorKGRlZmluZSAocGFja2Fn ZS1wcm9wYWdhdGVkLWlucHV0LXJlZnMgaW5wdXRzIHBhY2thZ2VzKQ0KKyAgIlJldHVybiBhIGxp c3Qgb2YgKGFzc29jLXJlZiBJTlBVVFMgPHBhY2thZ2UtbmFtZT4pIGZvciBlYWNoIHBhY2thZ2Ug aW4NCitQQUNLQUdFUyBhbmQgdGhlaXIgcHJvcGFnYXRlZCBpbnB1dHMuIg0KKyAgKG1hcCAobGFt YmRhIChsKQ0KKyAgICAgICAgIGAoYXNzb2MtcmVmICxpbnB1dHMgLGwpKQ0KKyAgICAgICAoYXBw ZW5kLW1hcCBwYWNrYWdlLXRyYW5zaXRpdmUtcHJvcGFnYXRlZC1sYWJlbHMqDQorICAgICAgICAg ICAgICAgICAgIHBhY2thZ2VzKSkpDQorDQogKGRlZmluZS1wdWJsaWMgZ2l0DQogICA7OyBLZWVw IGluIHN5bmMgd2l0aCAnZ2l0LW1hbnBhZ2VzJyENCiAgIChwYWNrYWdlDQpAQCAtMTI0LDEwICsx NDMsMTYgQEAgYXMgd2VsbCBhcyB0aGUgY2xhc3NpYyBjZW50cmFsaXplZCB3b3JrZmxvdy4iKQ0K ICAgICAgIDs7IEZvciAnZ2l0LXN2bicuDQogICAgICAgKCJzdWJ2ZXJzaW9uIiAsc3VidmVyc2lv bikNCiANCisgICAgICA7OyBGb3IgJ2dpdC1zZW5kLWVtYWlsJw0KKyAgICAgICgicGVybC1hdXRo ZW4tc2FzbCIgLHBlcmwtYXV0aGVuLXNhc2wpDQorICAgICAgKCJwZXJsLW5ldC1zbXRwLXNzbCIg LHBlcmwtbmV0LXNtdHAtc3NsKQ0KKyAgICAgICgicGVybC1pby1zb2NrZXQtc3NsIiAscGVybC1p by1zb2NrZXQtc3NsKQ0KKw0KICAgICAgIDs7IEZvciAnZ2l0IGd1aScsICdnaXRrJywgYW5kICdn aXQgY2l0b29sJy4NCiAgICAgICAoInRjbCIgLHRjbCkNCiAgICAgICAoInRrIiAsdGspKSkNCiAg ICAob3V0cHV0cyAnKCJvdXQiICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDsgdGhlIGNv cmUNCisgICAgICAgICAgICAgICJzZW5kLWVtYWlsIiAgICAgICAgICAgICAgICAgICAgICAgIDsg Zm9yIGdpdC1zZW5kLWVtYWlsDQogICAgICAgICAgICAgICAic3ZuIiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICA7IGdpdC1zdm4NCiAgICAgICAgICAgICAgICJndWkiKSkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDsgZ2l0aywgZ2l0IGd1aQ0KICAgIChhcmd1bWVudHMNCkBAIC0x NDEsNiArMTY2LDggQEAgYXMgd2VsbCBhcyB0aGUgY2xhc3NpYyBjZW50cmFsaXplZCB3b3JrZmxv dy4iKQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChhc3Nv Yy1yZWYgJWJ1aWxkLWlucHV0cyAidGsiKQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICIvYmluL3dpc2g4LjYiKSkgOyBYWFgNCiANCisgICAgICAjOm1vZHVs ZXMgKChzcmZpIHNyZmktMSkNCisgICAgICAgICAgICAgICAgICxAJWdudS1idWlsZC1zeXN0ZW0t bW9kdWxlcykNCiAgICAgICAjOnBoYXNlcw0KICAgICAgICAoYWxpc3QtY29ucy1hZnRlcg0KICAg ICAgICAgJ2NvbmZpZ3VyZSAncGF0Y2gtbWFrZWZpbGUtc2hlYmFuZ3MNCkBAIC0xNjQsNiArMTkx LDcgQEAgYXMgd2VsbCBhcyB0aGUgY2xhc3NpYyBjZW50cmFsaXplZCB3b3JrZmxvdy4iKQ0KICAg ICAgICAgICAobGFtYmRhKiAoIzprZXkgaW5wdXRzIG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlz KQ0KICAgICAgICAgICAgIDs7IFNwbGl0IHRoZSBiaW5hcmllcyB0byB0aGUgdmFyaW91cyBvdXRw dXRzLg0KICAgICAgICAgICAgIChsZXQqICgob3V0ICAgICAgKGFzc29jLXJlZiBvdXRwdXRzICJv dXQiKSkNCisgICAgICAgICAgICAgICAgICAgKHNlICAgICAgIChhc3NvYy1yZWYgb3V0cHV0cyAi c2VuZC1lbWFpbCIpKQ0KICAgICAgICAgICAgICAgICAgICAoc3ZuICAgICAgKGFzc29jLXJlZiBv dXRwdXRzICJzdm4iKSkNCiAgICAgICAgICAgICAgICAgICAgKGd1aSAgICAgIChhc3NvYy1yZWYg b3V0cHV0cyAiZ3VpIikpDQogICAgICAgICAgICAgICAgICAgIChnaXRrICAgICAoc3RyaW5nLWFw cGVuZCBvdXQgIi9iaW4vZ2l0ayIpKQ0KQEAgLTE3MiwyMCArMjAwLDIzIEBAIGFzIHdlbGwgYXMg dGhlIGNsYXNzaWMgY2VudHJhbGl6ZWQgd29ya2Zsb3cuIikNCiAgICAgICAgICAgICAgICAgICAg KGdpdC1ndWkqIChzdHJpbmctYXBwZW5kIGd1aSAiL2xpYmV4ZWMvZ2l0LWNvcmUvZ2l0LWd1aSIp KQ0KICAgICAgICAgICAgICAgICAgICAoZ2l0LWNpdCAgKHN0cmluZy1hcHBlbmQgb3V0ICIvbGli ZXhlYy9naXQtY29yZS9naXQtY2l0b29sIikpDQogICAgICAgICAgICAgICAgICAgIChnaXQtY2l0 KiAoc3RyaW5nLWFwcGVuZCBndWkgIi9saWJleGVjL2dpdC1jb3JlL2dpdC1jaXRvb2wiKSkNCisg ICAgICAgICAgICAgICAgICAgKGdpdC1zZSAgIChzdHJpbmctYXBwZW5kIG91dCAiL2xpYmV4ZWMv Z2l0LWNvcmUvZ2l0LXNlbmQtZW1haWwiKSkNCisgICAgICAgICAgICAgICAgICAgKGdpdC1zZSog IChzdHJpbmctYXBwZW5kIHNlICAiL2xpYmV4ZWMvZ2l0LWNvcmUvZ2l0LXNlbmQtZW1haWwiKSkN CiAgICAgICAgICAgICAgICAgICAgKGdpdC1zdm4gIChzdHJpbmctYXBwZW5kIG91dCAiL2xpYmV4 ZWMvZ2l0LWNvcmUvZ2l0LXN2biIpKQ0KICAgICAgICAgICAgICAgICAgICAoZ2l0LXN2biogKHN0 cmluZy1hcHBlbmQgc3ZuICIvbGliZXhlYy9naXQtY29yZS9naXQtc3ZuIikpDQogICAgICAgICAg ICAgICAgICAgIChnaXQtc20gICAoc3RyaW5nLWFwcGVuZCBvdXQNCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvbGliZXhlYy9naXQtY29yZS9naXQtc3VibW9k dWxlIikpKQ0KICAgICAgICAgICAgICAgKG1rZGlyLXAgKHN0cmluZy1hcHBlbmQgZ3VpICIvYmlu IikpDQogICAgICAgICAgICAgICAobWtkaXItcCAoc3RyaW5nLWFwcGVuZCBndWkgIi9saWJleGVj L2dpdC1jb3JlIikpDQorICAgICAgICAgICAgICAobWtkaXItcCAoc3RyaW5nLWFwcGVuZCBzZSAg Ii9saWJleGVjL2dpdC1jb3JlIikpDQogICAgICAgICAgICAgICAobWtkaXItcCAoc3RyaW5nLWFw cGVuZCBzdm4gIi9saWJleGVjL2dpdC1jb3JlIikpDQogDQogICAgICAgICAgICAgICAoZm9yLWVh Y2ggKGxhbWJkYSAob2xkIG5ldykNCiAgICAgICAgICAgICAgICAgICAgICAgICAgIChjb3B5LWZp bGUgb2xkIG5ldykNCiAgICAgICAgICAgICAgICAgICAgICAgICAgIChkZWxldGUtZmlsZSBvbGQp DQogICAgICAgICAgICAgICAgICAgICAgICAgICAoY2htb2QgbmV3ICNvNTU1KSkNCi0gICAgICAg ICAgICAgICAgICAgICAgICAobGlzdCBnaXRrIGdpdC1ndWkgZ2l0LWNpdCBnaXQtc3ZuKQ0KLSAg ICAgICAgICAgICAgICAgICAgICAgIChsaXN0IGdpdGsqIGdpdC1ndWkqIGdpdC1jaXQqIGdpdC1z dm4qKSkNCisgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCBnaXRrIGdpdC1ndWkgZ2l0LWNp dCBnaXQtc2UgZ2l0LXN2bikNCisgICAgICAgICAgICAgICAgICAgICAgICAobGlzdCBnaXRrKiBn aXQtZ3VpKiBnaXQtY2l0KiBnaXQtc2UqIGdpdC1zdm4qKSkNCiANCiAgICAgICAgICAgICAgIDs7 IFRlbGwgJ2dpdC1zdm4nIHdoZXJlIFN1YnZlcnNpb24gaXMuDQogICAgICAgICAgICAgICAod3Jh cC1wcm9ncmFtIGdpdC1zdm4qDQpAQCAtMjAyLDYgKzIzMywxOCBAQCBhcyB3ZWxsIGFzIHRoZSBj bGFzc2ljIGNlbnRyYWxpemVkIHdvcmtmbG93LiIpDQogICAgICAgICAgICAgICAgICAgKCwoc3Ry aW5nLWFwcGVuZCAoYXNzb2MtcmVmIGlucHV0cyAic3VidmVyc2lvbiIpDQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAiL2xpYiIpKSkpDQogDQorICAgICAgICAgICAgICA7OyBU ZWxsICdnaXQtc2VuZC1lbWFpbCcgd2hlcmUgcGVybCBtb2R1bGVzIGFyZS4NCisgICAgICAgICAg ICAgICh3cmFwLXByb2dyYW0gZ2l0LXNlKg0KKyAgICAgICAgICAgICAgICBgKCJQRVJMNUxJQiIg IjoiIHByZWZpeA0KKyAgICAgICAgICAgICAgICAgICwobWFwIChsYW1iZGEgKG8pIChzdHJpbmct YXBwZW5kIG8gIi9saWIvcGVybDUvc2l0ZV9wZXJsIikpDQorICAgICAgICAgICAgICAgICAgICAg ICAgKGRlbGV0ZS1kdXBsaWNhdGVzDQorICAgICAgICAgICAgICAgICAgICAgICAgIChsaXN0DQor ICAgICAgICAgICAgICAgICAgICAgICAgICAsQChwYWNrYWdlLXByb3BhZ2F0ZWQtaW5wdXQtcmVm cw0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2lucHV0cw0KKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgYCgscGVybC1hdXRoZW4tc2FzbA0KKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAscGVybC1uZXQtc210cC1zc2wNCisgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgLHBlcmwtaW8tc29ja2V0LXNzbCkpKSkpKSkNCisNCiAgICAgICAgICAgICAgIDs7IFRl bGwgJ2dpdC1zdWJtb2R1bGUnIHdoZXJlIFBlcmwgaXMuDQogICAgICAgICAgICAgICAod3JhcC1w cm9ncmFtIGdpdC1zbQ0KICAgICAgICAgICAgICAgICBgKCJQQVRIIiAiOiIgcHJlZml4DQotLSAN CjIuMi4xDQoNCg== --MP_/DCkEsMVRufyXWeuFUcbIit=--