From: Eric Bavier <ericbavier@openmailbox.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org, Eric Bavier <bavier@member.fsf.org>
Subject: Re: [PATCH 10/14] gnu: Add MUMPS.
Date: Sun, 28 Jun 2015 10:59:26 -0500 [thread overview]
Message-ID: <20150628105926.06922425@openmailbox.org> (raw)
In-Reply-To: <87h9prvbgn.fsf@gnu.org>
On Sun, 28 Jun 2015 22:12:40 +0200
ludo@gnu.org (Ludovic Courtès) wrote:
> ericbavier@openmailbox.org skribis:
>
> > From: Eric Bavier <bavier@member.fsf.org>
> >
> > * gnu/packages/maths.scm (mumps, mumps-metis, mumps-openmpi)
> > (mumps-metis-openmpi): New variables.
> > * gnu/packages/patches/mumps-build-parallelism.patch: New patch.
> > * gnu-system.am (dist_patch_DATA): Add it.
>
> ISTR that some time ago MUMPS included obfuscated code; I assume this
> is no longer the case?
Indeed, the 5.0.0 release no longer contains obfuscated code. I had
not realized this; thanks for bringing it my attention! ;)
>
> > + (zero? (system* "make" "all"
> > + (format #f
> > "-j~a" (current-processor-count))))))
>
> Rather ‘parallel-job-count’.
OK
>
> > + (lambda* (#:key (exec-prefix '()) #:allow-other-keys)
> > + (with-directory-excursion "examples"
> > + (use-modules (srfi srfi-1))
> > + (every
> > + (lambda (prec type)
> > + (use-modules (ice-9 popen))
>
> Local ‘use-modules’ forms are not very nice (it’s not documented.)
> Rather use:
>
> #:modules ((srfi srfi-1)
> (ice-9 popen)
> ,@%gnu-build-system-modules)
Much nicer, yes.
>
> > + (let ((tester (apply open-pipe*
> > + `(,OPEN_WRITE
> > + ,@exec-prefix
> > + ,(string-append "./" prec
> > +
> > "simpletest"))))
> > + (input (open-input-file
> > + (string-append "input_simpletest_"
> > type))))
> > + (begin
> > + (dump-port input tester)
> > + (close-port input)
> > + (zero? (close-pipe tester)))))
> > + '("s" "d" "c" "z")
> > + '("real" "real" "cmplx" "cmplx")))))
>
> Please add a comment saying that this does, to appease the
> reader. ;-)
Sure thing.
>
> > + (license license:public-domain)))
>
> I think it’s CeCILL-C, see
> <http://mumps.enseeiht.fr/index.php?page=dwnld>.
Good catch. Yes, this is also new in the 5.0.0 release. I believe I
orginally started writing this recipe for 4.10.0.
Thanks for the review,
`~Eric
next prev parent reply other threads:[~2015-06-28 20:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 3:45 [PATCH 00/14] Add deal.II and some dependencies ericbavier
2015-06-28 3:45 ` [PATCH 01/14] gnu: hwloc: Upgrade to 1.10.1 ericbavier
2015-06-28 9:08 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 02/14] gnu: hwloc: Move numactl to inputs ericbavier
2015-06-28 9:09 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 03/14] gnu: openmpi: Upgrade to 1.8.5 ericbavier
2015-06-28 9:10 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 04/14] gnu: Update scotch to 6.0.4 ericbavier
2015-06-28 9:12 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 05/14] gnu: scotch, pt-scotch: Use modify-phases ericbavier
2015-06-28 9:15 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 06/14] gnu: scotch, pt-scotch: Build esmumps libraries ericbavier
2015-06-28 9:14 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 07/14] gnu: Add ScaLAPACK ericbavier
2015-06-28 9:12 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 08/14] gnu: Add p4est ericbavier
2015-06-28 20:03 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 09/14] gnu: Add METIS ericbavier
2015-06-28 20:03 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 10/14] gnu: Add MUMPS ericbavier
2015-06-28 20:12 ` Ludovic Courtès
2015-06-28 15:59 ` Eric Bavier [this message]
2015-06-28 3:45 ` [PATCH 11/14] gnu: petsc: Upgrade to 3.6.0 ericbavier
2015-06-28 20:13 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 12/14] gnu: Add arpack-ng-openmpi ericbavier
2015-06-28 20:13 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 13/14] gnu: Add SLEPc ericbavier
2015-06-28 20:18 ` Ludovic Courtès
2015-06-28 3:45 ` [PATCH 14/14] gnu: Add deal.II ericbavier
2015-06-28 20:22 ` Ludovic Courtès
2015-06-28 16:05 ` Eric Bavier
2015-06-28 21:09 ` Andreas Enge
2015-06-29 8:39 ` Ludovic Courtès
2015-06-30 19:55 ` Eric Bavier
2015-07-04 7:40 ` Mark H Weaver
2015-07-05 10:20 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150628105926.06922425@openmailbox.org \
--to=ericbavier@openmailbox.org \
--cc=bavier@member.fsf.org \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).