unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: amirouche@hypermove.net
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] Add st
Date: Tue, 9 Jun 2015 16:22:10 +0200	[thread overview]
Message-ID: <20150609142210.GA5037@debian> (raw)
In-Reply-To: <960301908817217a6148629f683a3f34@hypermove.net>

Hello,

thanks for the submission! Just a partial review:

On Tue, Jun 09, 2015 at 03:07:55PM +0200, amirouche@hypermove.net wrote:
> +       ("font-liberation5" ,font-liberation)))

Typo? Drop "5"

> +    (description
> +     "Xterm is bloated and unmaintainable.  It has over 65K lines of code and

Please write a more neutral description. Something like
"St implements a simple and light-weight terminal emulator.  It implements
256 colors, most VT10X escape sequences, utf8, X11 copy/paste,
antialiased fonts (using fontconfig), fallback fonts, resizing,
and line drawing."
It is nicer to write what a programme does well than to complain about
what others do poorly.

Andreas

  reply	other threads:[~2015-06-09 14:22 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-09 11:04 [PATCH] Add st amirouche
2015-06-09 13:07 ` amirouche
2015-06-09 14:22   ` Andreas Enge [this message]
2015-06-10  6:28     ` amirouche
2015-06-11 22:15       ` Mark H Weaver
2015-06-13 19:13         ` amirouche
2015-06-14 17:46           ` Cyril Roelandt
2015-06-15 20:33             ` Ludovic Courtès
2015-06-15 21:28           ` Mark H Weaver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150609142210.GA5037@debian \
    --to=andreas@enge.fr \
    --cc=amirouche@hypermove.net \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).