Daemon update again

Daemon update again

[Ludovic Courtès]

Commit 54c260e updates the daemon again from upstream Nix code.  Few
interesting changes this time; interesting changes include:

  • Fixed-output derivations (such as downloads) are now also run in a
    chroot environment.  The difference with other derivations is that
    they do not get a separate network name space, which allows them to
    access the network, and they get additional files such as
    /etc/resolv.conf.

  • pivot_root(2) is used in addition to chroot(2), which is claimed to
    really prevent getting out of the chroot (though in practice build
    processes are non-root so I don’t see how they could get away.)

  • The ‘verifyStore’ RPC (more on that soon.)

Please report any issues!

Ludo’.

Re: Daemon update again

[Andreas Enge]

I did a "make distclean", "./bootstrap", "./configure" and "make" on my mips
machine. It fails with the following message:
  CXX      nix/libstore/libstore_a-build.o
nix/libstore/build.cc: In member function ‘void nix::DerivationGoal::startBuilder()’:
nix/libstore/build.cc:1808:91: error: ‘DEFAULT_CHROOT_DIRS’ was not declared in this scope
         PathSet dirs = tokenizeString<StringSet>(settings.get("build-chroot-dirs", string(DEFAULT_CHROOT_DIRS)));
                                                                                           ^
nix/libstore/build.cc: In member function ‘void nix::Worker::waitForInput()’:
nix/libstore/build.cc:3324:74: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (!waitingForAWhile.empty() && lastWokenUp + settings.pollInterval <= after) {
                                                                          ^
Makefile:2630: recipe for target 'nix/libstore/libstore_a-build.o' failed

Andreas

Re: Daemon update again

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> I did a "make distclean", "./bootstrap", "./configure" and "make" on my mips

‘make’ is usually enough.

> machine. It fails with the following message:
>   CXX      nix/libstore/libstore_a-build.o
> nix/libstore/build.cc: In member function ‘void nix::DerivationGoal::startBuilder()’:
> nix/libstore/build.cc:1808:91: error: ‘DEFAULT_CHROOT_DIRS’ was not declared in this scope
>          PathSet dirs = tokenizeString<StringSet>(settings.get("build-chroot-dirs", string(DEFAULT_CHROOT_DIRS)));

Could you run “make V=1”?  Normally DEFAULT_CHROOT_DIRS is defined from
the command line (see ‘libstore_a_CPPFLAGS’.)

> nix/libstore/build.cc: In member function ‘void nix::Worker::waitForInput()’:
> nix/libstore/build.cc:3324:74: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
>      if (!waitingForAWhile.empty() && lastWokenUp + settings.pollInterval <= after) {
>                                                                           ^

Weird, I don’t have it on x86_64 with GCC 5.1.0 -Wall but ‘time_t’ is
indeed signed on all platforms (according to <bits/typesizes.h>) and
‘pollInterval’ is unsigned.

Thanks,
Ludo’.

Re: Daemon update again

[Andreas Enge]

On Sat, Jun 06, 2015 at 07:41:42PM +0200, Ludovic Courtès wrote:
> Could you run “make V=1”?  Normally DEFAULT_CHROOT_DIRS is defined from
> the command line (see ‘libstore_a_CPPFLAGS’.)

There is no trace of it on the command line:

g++ -DHAVE_CONFIG_H -I. -I./nix  -I./nix -I./nix/libutil -I./nix -I./nix/libstore -I./nix/libstore -DNIX_STORE_DIR=\"/gnu/store\" -DNIX_DATA_DIR=\"/usr/local/guix/share\" -DNIX_STATE_DIR=\"/usr/local/guix/var/guix\" -DNIX_LOG_DIR=\"/usr/local/guix/var/log/guix\" -DNIX_CONF_DIR=\"/usr/local/guix/etc/guix\" -DNIX_LIBEXEC_DIR=\"/usr/local/guix/libexec\" -DNIX_BIN_DIR=\"/usr/local/guix/bin\" -DOPENSSL_PATH="\"guix-authenticate\""  -Wall -std=c++0x   -g -O2 -MT nix/libstore/libstore_a-build.o -MD -MP -MF nix/libstore/.deps/libstore_a-build.Tpo -c -o nix/libstore/libstore_a-build.o `test -f 'nix/libstore/build.cc' || echo './'`nix/libstore/build.cc
nix/libstore/build.cc: In member function ‘void nix::DerivationGoal::startBuilder()’:
nix/libstore/build.cc:1808:91: error: ‘DEFAULT_CHROOT_DIRS’ was not declared in this scope
         PathSet dirs = tokenizeString<StringSet>(settings.get("build-chroot-dirs", string(DEFAULT_CHROOT_DIRS)));

Andreas

Re: Daemon update again

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Sat, Jun 06, 2015 at 07:41:42PM +0200, Ludovic Courtès wrote:
>> Could you run “make V=1”?  Normally DEFAULT_CHROOT_DIRS is defined from
>> the command line (see ‘libstore_a_CPPFLAGS’.)
>
> There is no trace of it on the command line:
>
> g++ -DHAVE_CONFIG_H -I. -I./nix  -I./nix -I./nix/libutil -I./nix -I./nix/libstore -I./nix/libstore -DNIX_STORE_DIR=\"/gnu/store\" -DNIX_DATA_DIR=\"/usr/local/guix/share\" -DNIX_STATE_DIR=\"/usr/local/guix/var/guix\" -DNIX_LOG_DIR=\"/usr/local/guix/var/log/guix\" -DNIX_CONF_DIR=\"/usr/local/guix/etc/guix\" -DNIX_LIBEXEC_DIR=\"/usr/local/guix/libexec\" -DNIX_BIN_DIR=\"/usr/local/guix/bin\" -DOPENSSL_PATH="\"guix-authenticate\""  -Wall -std=c++0x   -g -O2 -MT nix/libstore/libstore_a-build.o -MD -MP -MF nix/libstore/.deps/libstore_a-build.Tpo -c -o nix/libstore/libstore_a-build.o `test -f 'nix/libstore/build.cc' || echo './'`nix/libstore/build.cc
> nix/libstore/build.cc: In member function ‘void nix::DerivationGoal::startBuilder()’:
> nix/libstore/build.cc:1808:91: error: ‘DEFAULT_CHROOT_DIRS’ was not declared in this scope
>          PathSet dirs = tokenizeString<StringSet>(settings.get("build-chroot-dirs", string(DEFAULT_CHROOT_DIRS)));

Hmm.  What’s the value of ‘libstore_a_CPPFLAGS’ in daemon.am,
Makefile.in, and Makefile?

There’s also the fact that it’s using -std=c++0x, whereas current master
uses -std=c++11.  Fishy!

Ludo’.

Re: Daemon update again

[Andreas Enge]

On Tue, Jun 09, 2015 at 05:51:00PM +0200, Ludovic Courtès wrote:
> There’s also the fact that it’s using -std=c++0x, whereas current master
> uses -std=c++11.  Fishy!

Very fishy indeed! I think I did not run "autoreconf -vfi" correctly, or
it failed and I did not pay attention, and was left with a mixture of old
and new files. Now I redid it, and there is no trace left of "-std=c++0x",
and the flags seem to be correctly said.

Thank you for asking the right questions, and sorry for taking your time!

Andreas

Re: Daemon update again

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> On Tue, Jun 09, 2015 at 05:51:00PM +0200, Ludovic Courtès wrote:
>> There’s also the fact that it’s using -std=c++0x, whereas current master
>> uses -std=c++11.  Fishy!
>
> Very fishy indeed! I think I did not run "autoreconf -vfi" correctly, or
> it failed and I did not pay attention, and was left with a mixture of old
> and new files. Now I redid it, and there is no trace left of "-std=c++0x",
> and the flags seem to be correctly said.
>
> Thank you for asking the right questions, and sorry for taking your time!

Good, no problem!

Ludo’.