unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: David Thompson <dthompson2@worcester.edu>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add xxhash.
Date: Tue, 28 Apr 2015 16:48:26 +0200	[thread overview]
Message-ID: <20150428144826.GB4503@debian> (raw)
In-Reply-To: <87oama8skj.fsf@fsf.org>

On Sun, Apr 26, 2015 at 05:53:32PM -0400, David Thompson wrote:
> * gnu/packages/xxhash.scm: New file.

I am usually not in favour of adding new files for small utilities. Could it
go somewhere else?

> +    (synopsis "Extremely fast non-cryptographic hash algorithm")
> +    (description
> +     "xxHash is an extremely fast hash algorithm, running at RAM speed limits.
> +It successfully passes the SMHasher test suite evaluating hash quality.")

Maybe drop the marketing parts "extremely fast"?

Otherwise, it looks good to me.

Andreas

  reply	other threads:[~2015-04-28 14:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26 21:53 [PATCH] gnu: Add xxhash David Thompson
2015-04-28 14:48 ` Andreas Enge [this message]
2015-04-28 15:36   ` David Thompson
2015-04-29 20:53     ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150428144826.GB4503@debian \
    --to=andreas@enge.fr \
    --cc=dthompson2@worcester.edu \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).