From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Enge Subject: Re: [PATCH] gnu: Add IR. Date: Sun, 26 Apr 2015 14:09:59 +0200 Message-ID: <20150426120959.GA5194@debian> References: <87siboyreg.fsf@mango.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:41111) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmLNx-0003xJ-4y for guix-devel@gnu.org; Sun, 26 Apr 2015 08:10:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YmLNs-0001bV-6P for guix-devel@gnu.org; Sun, 26 Apr 2015 08:10:09 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:57986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YmLNr-0001a7-Tq for guix-devel@gnu.org; Sun, 26 Apr 2015 08:10:04 -0400 Content-Disposition: inline In-Reply-To: <87siboyreg.fsf@mango.localdomain> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ricardo Wurmus Cc: guix-devel On Sat, Apr 25, 2015 at 08:49:43PM +0200, Ricardo Wurmus wrote: > + (chdir "libs") #t) I would put "#t" onto a new line as it is a separate "command". + (("^LIBDIR =.*") "LIBDIR = lib\n")) I think this adds a line break, which is not a problem. > + "Zita convolver is a C++ library implementing a real-time convolution > +matrix.") This I find difficult to understand. How can you implement a matrix? What is a real time matrix? Maybe "for computing convolution matrices in real time"? Or also add "double precision" (or whatever is correct) in front of "convolution matrices". Otherwise looks good. Andreas