unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Tomáš Čech" <sleep_walker@gnu.org>
To: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: curl: Update to 7.41.0. Fix #20121.
Date: Sun, 22 Mar 2015 18:41:15 +0100	[thread overview]
Message-ID: <20150322174115.GA13755@venom> (raw)
In-Reply-To: <87vbht7yyc.fsf@netris.org>

[-- Attachment #1: Type: text/plain, Size: 1299 bytes --]

Thanks for review!

On Sun, Mar 22, 2015 at 12:56:43PM -0400, Mark H Weaver wrote:
>Tomáš Čech <sleep_walker@gnu.org> writes:
>
>> @@ -60,7 +64,18 @@
>>         ("pkg-config" ,pkg-config)
>>         ("python" ,python-2)))
>>     (arguments
>> -    `(#:configure-flags '("--with-gnutls" "--with-gssapi")
>> +    `(#:configure-flags
>> +      '("--with-gnutls" "--with-gssapi" "--enable-http"
>> +        ;; This option requires parameter so let's use this one
>> +        ;; - when it exists, it makes sense
>> +        ;; - when it doesn't exist, we can still use SSL_CERT_DIR environment
>> +        ;;   variable to set it per user or for whole system
>> +        ;; Fixes #20121.
>> +        "--with-ca-path=/etc/ssl/certs"
>
>It would be better to avoid passing the --with-ca-path= option.  We are
>attempting to move away from having any compiled-in system-wide location
>for the CA trust store.  Each user should be able to specify their
>desired trust store using environment variables or other settings.

I verified that patch is now sufficient as solution and I verified
that it respects SSL_CERT_DIR with that so it is ideal solution.

Thanks for kicking me step further. (And yes, that patch is really needed :)

I'll update the patch accordingly.

S_W

[-- Attachment #2: Type: application/pgp-signature, Size: 181 bytes --]

  reply	other threads:[~2015-03-22 17:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-22 10:20 [PATCH] gnu: curl: Update to 7.41.0. Fix #20121 Tomáš Čech
2015-03-22 12:40 ` Tomáš Čech
2015-03-22 16:56 ` Mark H Weaver
2015-03-22 17:41   ` Tomáš Čech [this message]
2015-03-22 18:16     ` Mark H Weaver
2015-03-22 19:09       ` Tomáš Čech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150322174115.GA13755@venom \
    --to=sleep_walker@gnu.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).