From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [PATCH] gnu: Add gnash. Date: Thu, 19 Mar 2015 22:22:16 +0100 Message-ID: <20150319212216.GF525@venom.suse.cz> References: <1426676259-22302-1-git-send-email-sleep_walker@gnu.org> <877fud2cd0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="DEueqSqTbz/jWVG1" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYhtX-0003KI-0M for guix-devel@gnu.org; Thu, 19 Mar 2015 17:22:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYhtT-00017d-J2 for guix-devel@gnu.org; Thu, 19 Mar 2015 17:22:22 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39387 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYhtT-00017S-9I for guix-devel@gnu.org; Thu, 19 Mar 2015 17:22:19 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 45F10ABF1 for ; Thu, 19 Mar 2015 21:22:18 +0000 (UTC) Content-Disposition: inline In-Reply-To: <877fud2cd0.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --DEueqSqTbz/jWVG1 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 19, 2015 at 05:17:10PM +0100, Ludovic Court=C3=A8s wrote: >Tom=C3=A1=C5=A1 =C4=8Cech skribis: > >> * gnu/packages/gnash.scm: New file. >> * gnu-system.am (GNU_SYSTEM_MODULES): Add the file. > >[...] > >> +(define-module (gnu packages gnash) > >Maybe we could call it =E2=80=98flash=E2=80=99 since there may be other to= ols going >there (players or things like libswf)? Yes, that was my working name - when I got circular deps in web module, I moved it to separate file. `flash' is good name - I'm already working on lightspark which will go there as well... >> + #:use-module (guix build-system gnu) >> + ) > >Move the paren to the previous line. OK > >> + ;; release is too old to be built correctly against ffmpeg, libj= peg and >> + ;; more, lets go with head containing all required fixes already >> + (method git-fetch) > >We have ffmpeg-2.2 and libjpeg-8 already available. Would that allow us >to build from the release tarball? The problem is incompatibility between the release (2 years old) and the versions we have in Guix (ffmpeg, libjpeg, boost, automake, gcc and mabe more). I originally started with the release tarball and took bunch of patches which fixed ffmpeg changes and libjpeg changes but it was just too many so I gave up. >If yes, we should probably do that, plus the CVE-2012-1175 patch at > >(don=E2=80=99t know if there are others.) > >> + ;; gstreamer 0.10 is required, but not available, gstreamer-1.0 not > >gstreamer-0.10 is available from (gnu packages gstreamer). In that case `guix package -s gstreamer' didn't show that to me. Btw. I run this command several times and it's showing versions randomly (in following case gst-plugins-base has different version): guix package -s gstreamer | recsel -p name,version ---------%<----------------------------%<-------------------- $ guix package -s gstreamer | recsel -p name,version name: gst-plugins-base version: 0.10.36 name: gst-plugins-good version: 1.4.5 name: gstreamer version: 1.4.5 name: libcanberra version: 0.30 $ guix package -s gstreamer | recsel -p name,version name: gst-plugins-base version: 1.4.5 name: gst-plugins-good version: 1.4.5 name: gstreamer version: 1.4.5 name: libcanberra version: 0.30 --------->%---------------------------->%-------------------- Grep found it reliably. >> + (synopsis "GNU Flash movie player") >> + (description "GNU Gnash is the GNU Flash movie player =E2=80=94 Fla= sh is an >> +animation file format pioneered by Macromedia which continues to be sup= ported by >> +their successor company, Adobe. Flash has been extended to include aud= io and >> +video content, and programs written in ActionScript, an ECMAScript-comp= atible >> +language. Gnash is based on GameSWF, and supports most SWF v7 features= and >> +some SWF v8 and v9. SWF v10 is not supported by GNU Gnash.") > >Please use those suggested by =E2=80=98guix lint=E2=80=99. Where did that text come from!? Will do. > >> + (license l:gpl3))) > >l:gpl3+ Thanks. > >Could you send an updated patch? > > >In the Nixpkgs recipe I had added this hack: > >+ # Provide a default font. >+ sed -i "configure" \ >+ -e 's|/usr/share/fonts/truetype/freefont/|${freefont_ttf}/share/f= onts/truetype/|g' > >Any idea if this is still needed? IOW, does gtk-gnash manage to display >text at all without it? It's hard to find flash old enough, showing text and with sources to confirm it's text. I think that this can be used for verification: http://technoargia.free.fr/swftools/examples/button3/button3.html And yes, works for me. Thanks for review. S_W --DEueqSqTbz/jWVG1 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlULPgYACgkQ37XrCapiVCMLqQCfYm5hpeAqaBsLTDM5QGrIjYBc f/kAnRhDFJKiOPlbgfCdHqSxyPOxzp+6 =e9hw -----END PGP SIGNATURE----- --DEueqSqTbz/jWVG1--