From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: 01/01: gnu: Add agg. Date: Wed, 18 Mar 2015 14:47:20 +0100 Message-ID: <20150318134720.GA27555@venom> References: <20150318105410.2359.97929@vcs.savannah.gnu.org> <87r3smfo4i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYEJj-0006GO-Ep for guix-devel@gnu.org; Wed, 18 Mar 2015 09:47:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYEJe-0005Ho-Ih for guix-devel@gnu.org; Wed, 18 Mar 2015 09:47:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:51470 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYEJe-0005Ha-9e for guix-devel@gnu.org; Wed, 18 Mar 2015 09:47:22 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 0E65EAC11 for ; Wed, 18 Mar 2015 13:47:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <87r3smfo4i.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: guix-devel@gnu.org --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 18, 2015 at 02:09:49PM +0100, Ludovic Court=C3=A8s wrote: >Tomas Cech skribis: > >> commit 87bafa07ae68084819bb2648bd1042c354d11317 >> Author: Tom=C3=A1=C5=A1 =C4=8Cech >> Date: Wed Mar 18 08:57:50 2015 +0100 >> >> gnu: Add agg. >> >> * gnu/packages/graphics.scm (agg): New variable. >> * gnu/packages/patches/agg-am_c_prototype.patch: New file. >> * gnu-system.am (dist_patch_DATA): Add it. > >[...] > >> +++ b/gnu/packages/patches/agg-am_c_prototype.patch >> @@ -0,0 +1,10 @@ >> +--- a/configure.in 2015-03-15 18:59:12.557417149 +0100 >> ++++ b/configure.in 2015-03-15 18:59:29.273416518 +0100 > >Patches must have a comment at the beginning to explain what they do, >why, and what the upstream status is. Will do. >Please pay more attention to these rules before pushing. In general, I >would recommend that you wait for some review before pushing. (This is >sometimes slow, but hopefully others will help reduce latency, >hint hint! ;-)) Yeah, I can see what I'm causing lately. I'll relax with pushing. > >> +@@ -8,7 +8,6 @@ >> + AC_PROG_CC >> + AC_PROG_CXX >> + AC_ISC_POSIX >> +-AM_C_PROTOTYPES >> + if test "x$U" !=3D "x"; then >> + AC_MSG_ERROR(Compiler not ANSI compliant) >> + fi > >It is best to avoid modifying .ac or .am files because that requires >adding a dependency on the autotools.] I will remember that but I'm afraid that in this case there is no configure in tarball anyway and has to be generated. >What problem does this patch solve? I=E2=80=99m confident this can be wor= ked >around without modifying the .ac file, for instance by passing the right >ac_cv_ variable as a =E2=80=98configure=E2=80=99 argument. AM_C_PROTOTYPES has been removed from automake. https://lists.gnu.org/archive/html/automake-patches/2011-06/msg00082.html and the reconfigure leads to failure: starting phase `autoreconf' aclocal: warning: autoconf input should be named 'configure.ac', not 'confi= gure.in' configure.in:11: error: automatic de-ANSI-fication support has been removed /gnu/store/2h4lnk22bj479fnr0l2cyx2rvisv9cg7-automake-1.15/share/aclocal-1.1= 5/obsolete.m4:26: AM_C_PROTOTYPES is expanded from... configure.in:11: the top level I'd gladly take your recommendation about passing 'the right ac_cv_ variable' on this. The agg package is old, last it's release was 8 years ago, sourceforge marked that as '(historical)'. It is unlikely that anyone would accept patch. The only reason I spent time on it is because it is required dependency for GNU Gnash. Thanks for review. Best regards, S_W --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlUJgeYACgkQ37XrCapiVCPGbgCfQ9WASYF2WnwKeNso9zhdiDBy l7gAoLjC5MtM4qOrHRB7C2MOjk4gxFP2 =AIbC -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--