From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add quvi.
Date: Fri, 6 Mar 2015 22:54:36 +0100
Message-ID: <20150306215436.GA32174@debian>
References: <87385ke82v.fsf@taylan.uni.cx>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33087)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YU0Cj-000450-Vn
	for guix-devel@gnu.org; Fri, 06 Mar 2015 16:54:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YU0Ce-0007kH-WE
	for guix-devel@gnu.org; Fri, 06 Mar 2015 16:54:45 -0500
Received: from mout.kundenserver.de ([212.227.126.187]:59053)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YU0Ce-0007jy-Lj
	for guix-devel@gnu.org; Fri, 06 Mar 2015 16:54:40 -0500
Content-Disposition: inline
In-Reply-To: <87385ke82v.fsf@taylan.uni.cx>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Taylan Ulrich =?utf-8?B?QmF5xLFybMSxL0thbW1lcg==?= <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org

On Wed, Mar 04, 2015 at 11:00:56PM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
> This actually adds three packages but they're closely tied together.

Still, could you commit them as three separate packages?

> +    (description "This package contains the support scripts called upon by
> +libquvi to parse media stream properties.")

"called" instead of "called upon"?

> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "mirror://sourceforge/quvi/libquvi-" version ".tar.xz"))
> +       (sha256
> +        (base32 "00x9gbmzc5cns0gnfag0hsphcr3cb33vbbb9s7ppvvd6bxz2z1mm"))))

Your indentation (here and further down) is not quite consistens, sometimes
it it one, sometimes two spaces.

> +          (string-append "liblua_CFLAGS=-I" lua "/include")
> +          (string-append "liblua_LIBS=-L" lua "/libs -llua")))))

These are two flags and should be two entries in the list.

Apart from that, they look good to push.

Andreas