From: Andreas Enge <andreas@enge.fr>
To: "Taylan Ulrich Bayırlı/Kammer" <taylanbayirli@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add quvi.
Date: Fri, 6 Mar 2015 22:54:36 +0100 [thread overview]
Message-ID: <20150306215436.GA32174@debian> (raw)
In-Reply-To: <87385ke82v.fsf@taylan.uni.cx>
On Wed, Mar 04, 2015 at 11:00:56PM +0100, Taylan Ulrich Bayırlı/Kammer wrote:
> This actually adds three packages but they're closely tied together.
Still, could you commit them as three separate packages?
> + (description "This package contains the support scripts called upon by
> +libquvi to parse media stream properties.")
"called" instead of "called upon"?
> + (origin
> + (method url-fetch)
> + (uri (string-append
> + "mirror://sourceforge/quvi/libquvi-" version ".tar.xz"))
> + (sha256
> + (base32 "00x9gbmzc5cns0gnfag0hsphcr3cb33vbbb9s7ppvvd6bxz2z1mm"))))
Your indentation (here and further down) is not quite consistens, sometimes
it it one, sometimes two spaces.
> + (string-append "liblua_CFLAGS=-I" lua "/include")
> + (string-append "liblua_LIBS=-L" lua "/libs -llua")))))
These are two flags and should be two entries in the list.
Apart from that, they look good to push.
Andreas
next prev parent reply other threads:[~2015-03-06 21:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 22:00 [PATCH] gnu: Add quvi Taylan Ulrich Bayırlı/Kammer
2015-03-06 21:54 ` Andreas Enge [this message]
2015-03-06 22:47 ` Mark H Weaver
2015-03-06 23:05 ` Andreas Enge
2015-03-06 23:32 ` Mark H Weaver
2015-03-06 23:48 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306215436.GA32174@debian \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=taylanbayirli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).