From: Andreas Enge <andreas@enge.fr>
To: "Tomáš Čech" <sleep_walker@suse.cz>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: valgrind: Fix build against glibc 2.21
Date: Fri, 6 Mar 2015 19:41:28 +0100 [thread overview]
Message-ID: <20150306184128.GA7034@debian.math.u-bordeaux1.fr> (raw)
In-Reply-To: <1425661321-12432-1-git-send-email-sleep_walker@suse.cz>
I had a look yesterday and wanted to make a patch this evening, but you
beat me to it! This looks a lot like what I wanted to do, so please push.
A tiny bit of nitpicking:
On Fri, Mar 06, 2015 at 06:02:01PM +0100, Tomáš Čech wrote:
> + gnu/packages/patches/valgrind-glibc_version.patch \
We usually use '-' instead of '_', so I would call it
valgrind-glibc-version.patch .
Or maybe valgrind-glibc-2.21.patch .
Andreas
PS: The funny thing is that the error message states that valgrind needs
glibc up to 2.19, while the configure script already supports 2.20.
next prev parent reply other threads:[~2015-03-06 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 17:02 [PATCH] gnu: valgrind: Fix build against glibc 2.21 Tomáš Čech
2015-03-06 18:41 ` Andreas Enge [this message]
2015-03-06 19:38 ` tcech
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150306184128.GA7034@debian.math.u-bordeaux1.fr \
--to=andreas@enge.fr \
--cc=guix-devel@gnu.org \
--cc=sleep_walker@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).