unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: Eric Bavier <ericbavier@openmailbox.org>
Cc: Guix-devel <guix-devel@gnu.org>
Subject: Re: [PATCH] gnu: Add Scikit-learn.
Date: Fri, 27 Feb 2015 23:48:34 +0100	[thread overview]
Message-ID: <20150227224834.GA6114@debian> (raw)
In-Reply-To: <20150227094151.GA4043@debian.eduroam.u-bordeaux.fr>

On Fri, Feb 27, 2015 at 10:41:51AM +0100, Andreas Enge wrote:
> So let us rename python(2)-py(2)cairo to python(2)-pycairo. If nobody beats
> me to it, I can do it tomorrow.

Well, if I am not mistaken, renaming does not solve the problem really. I had
forgotten how 'package-with-python2' works: It does not replace the input
'python-foo' with 'python2-foo', but with '(package-with-python2 python-foo)'
(and this recursively).

Now, 'python2-pycairo' is not the same as '(package-with-python2 python-pycairo)'
(in particular the source fields are changed).

This means that if one has a package with 'python-pycairo' as input, then
its python2 version cannot simply be created using 'package-with-python2'.
And worse, if one has a package with input a package with input 'python-pycairo',
one needs to unravel even one level more. And so on. This is very unpleasant.
(See the definition of 'python2-matplotlib', in which some inputs are rewritten
by hand. And 'python2-scipy' inherits the problem, since it has as input
'python2-matplotlib'.) This has actually been discussed in November
on the list...

Now, as also discussed before, we cannot look at variable names and just
rewrite them syntactically. But can we adapt the package definition to depend
on the 'name' field, which changes in a predictible way?

For instance: 'python2-pycairo' differs from '(package-with-python2 python-pycairo)'
only in the 'source' field (and the 'license' field, which is a minor point
for the sake of building). So could we redefine the source depending on the
'name' field, which is 'python-pycairo' in one case and 'python2-pycairo'
in the other? Can we use in the 'source' field something like
(if (string=? name "python-pycairo"
              source-x
              source-y))
?
I assume that yes - after all, we already use the 'version' field in the
'source' field. This can only work if the fields are evaluated in the
right order. Is it the order in the definition of the 'package' record?

Andreas

  reply	other threads:[~2015-02-27 22:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-23 16:24 [PATCH] gnu: Add Scikit-learn Ricardo Wurmus
2015-02-23 17:17 ` Ricardo Wurmus
2015-02-23 17:36   ` Andreas Enge
2015-02-26 11:28     ` Ricardo Wurmus
2015-02-26 20:44       ` Andreas Enge
2015-02-23 17:52   ` Andreas Enge
2015-02-25 22:52     ` Andreas Enge
2015-02-25 22:57       ` Andreas Enge
2015-02-26 17:11         ` Ludovic Courtès
2015-02-26 17:59           ` Andreas Enge
2015-02-26 18:20             ` Ludovic Courtès
2015-02-26 18:23               ` Andreas Enge
2015-02-26 20:03             ` Eric Bavier
2015-02-26 20:43               ` Andreas Enge
2015-02-26 21:10                 ` Eric Bavier
2015-02-27  9:41                   ` Andreas Enge
2015-02-27 22:48                     ` Andreas Enge [this message]
2015-02-27 23:53                       ` Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150227224834.GA6114@debian \
    --to=andreas@enge.fr \
    --cc=ericbavier@openmailbox.org \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).