[PATCH] gnu: cmake: Update to 3.1.3.

[PATCH] gnu: cmake: Update to 3.1.3.

[宋文武]

* gnu/packages/cmake.scm (cmake): Update to 3.1.3.
---
 gnu/packages/cmake.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/cmake.scm b/gnu/packages/cmake.scm
index 63805ef..c3ed4ae 100644
--- a/gnu/packages/cmake.scm
+++ b/gnu/packages/cmake.scm
@@ -35,7 +35,7 @@
 (define-public cmake
   (package
     (name "cmake")
-    (version "2.8.12")
+    (version "3.1.3")
     (source (origin
              (method url-fetch)
              (uri (string-append
@@ -43,7 +43,7 @@
                    (version-major+minor version)
                    "/cmake-" version ".tar.gz"))
              (sha256
-              (base32 "11q21vyrr6c6smyjy81k2k07zmn96ggjia9im9cxwvj0n88bm1fq"))
+              (base32 "1l662p9lscbzx9s85y86cynb9fn1rb2alqg4584wqq9gibxd7x25"))
              (patches (list (search-patch "cmake-fix-tests.patch")))))
     (build-system gnu-build-system)
     (arguments
@@ -62,6 +62,7 @@
                          "Source/cmGlobalXCodeGenerator.cxx"
                          "Source/CTest/cmCTestBatchTestHandler.cxx"
                          "Source/cmLocalUnixMakefileGenerator3.cxx"
+                         "Source/cmExecProgramCommand.cxx"
                          "Utilities/cmbzip2/Makefile-libbz2_so"
                          "Utilities/Release/release_cmake.cmake"
                          "Utilities/cmlibarchive/libarchive/archive_write_set_format_shar.c"
-- 
2.1.2

Re: [PATCH] gnu: cmake: Update to 3.1.3.

[Andreas Enge]

On Thu, Feb 26, 2015 at 10:18:01PM +0800, 宋文武 wrote:
> * gnu/packages/cmake.scm (cmake): Update to 3.1.3.

Excellent, it all looks good! Do you think it would be useful to create a
wip-cmake branch first and to build it on hydra, to see whether there will be
many breakages in our existing packages, or do you think the risk is
sufficiently low to push to master directly?

Thanks!

Andreas

Re: [PATCH] gnu: cmake: Update to 3.1.3.

[Mark H Weaver]

Andreas Enge <andreas@enge.fr> writes:

> On Thu, Feb 26, 2015 at 10:18:01PM +0800, 宋文武 wrote:
>> * gnu/packages/cmake.scm (cmake): Update to 3.1.3.
>
> Excellent, it all looks good! Do you think it would be useful to create a
> wip-cmake branch first and to build it on hydra, to see whether there will be
> many breakages in our existing packages, or do you think the risk is
> sufficiently low to push to master directly?

I think this should go to core-updates, because it will cause a lot of
rebuilds, and a core-updates merge should happen fairly soon anyway.  We
don't have the tools to determine the exact number of rebuilds, but
openjpeg alone (which uses cmake-build-system) would cause about 807
rebuilds.

     Thanks!
       Mark

Re: [PATCH] gnu: cmake: Update to 3.1.3.

[Andreas Enge]

On Thu, Feb 26, 2015 at 10:41:30AM -0500, Mark H Weaver wrote:
> I think this should go to core-updates, because it will cause a lot of
> rebuilds, and a core-updates merge should happen fairly soon anyway.

Okay, I agree.

Andreas

Re: [PATCH] gnu: cmake: Update to 3.1.3.

[Andreas Enge]

By the way, I still think we should modify our cmake build system to pass
   -DCMAKE_VERBOSE_MAKEFILE=ON
It shows the commands executed by make, which is really useful when there
is a build problem.

This would be the occasion to implement it in core-updates.

What do you think?

Andreas

Re: [PATCH] gnu: cmake: Update to 3.1.3.

[宋文武]

Andreas Enge <andreas@enge.fr> writes:

> By the way, I still think we should modify our cmake build system to pass
>    -DCMAKE_VERBOSE_MAKEFILE=ON
> It shows the commands executed by make, which is really useful when there
> is a build problem.
>
> This would be the occasion to implement it in core-updates.
>
> What do you think?
Agree!

I just pushed 2 commit (one for update, one for verbose) to
core-updates.

Thanks for review!
>
> Andreas