From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?utf-8?B?VG9tw6HFoSDEjGVjaA==?= Subject: Re: [PATCH 4/5] gnu: Add emotion-generic-players Date: Thu, 26 Feb 2015 12:14:43 +0100 Message-ID: <20150226111443.GB10407@venom> References: <1424910673-17665-1-git-send-email-sleep_walker@suse.cz> <1424910673-17665-4-git-send-email-sleep_walker@suse.cz> <20150226102308.GA3600@debian.math.u-bordeaux1.fr> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="p4qYPpj5QlsIQJ0K" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59715) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQwP5-0003uS-2X for guix-devel@gnu.org; Thu, 26 Feb 2015 06:14:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQwOy-0008OY-Vk for guix-devel@gnu.org; Thu, 26 Feb 2015 06:14:51 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52350 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQwOy-0008OQ-Oz for guix-devel@gnu.org; Thu, 26 Feb 2015 06:14:44 -0500 Content-Disposition: inline In-Reply-To: <20150226102308.GA3600@debian.math.u-bordeaux1.fr> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Andreas Enge Cc: guix-devel@gnu.org --p4qYPpj5QlsIQJ0K Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, thanks for review. On Thu, Feb 26, 2015 at 11:23:27AM +0100, Andreas Enge wrote: >Hello, > >just a quick comment on the descriptions. It would be good to write full >sentences, for instance: > >On Thu, Feb 26, 2015 at 01:31:12AM +0100, Tom=C3=A1=C5=A1 =C4=8Cech wrote: >> + "Set of generic media players allowing to open video files through= emotion. Useful only for emotion library based applications.") > >"Emotion Generic Players provides/consists of/is a set of generic ... >It is useful only for ...". I agree that sentences may be better, I only suck at it. I'll try to improvide it or I can accept any recommendations in the meantime. >I think it would also be good to expand a bit where possible, and to intro= duce >the word "enlightenment" in each of these packages (by replacing "EFL" with >"Enlightenment Foundation Libraries", I do agree that use of "Enlightenment Foundation Libraries" instead of "EFL" could make it more enjoyable to read, but we could expand also Gimp toolkit, Tool Command Language, ... Those who would need such these packages will know and it won't help to others anyway. Synopsis of efl package will show you "Enlightenment Foundation Libraries". >for instance, or adding a sentence like >"It is part of the Enlightenment desktop environment"). Enlightenment is using the same libraries (they were developed for Enlightenment) but the libraries are much more generic. It's like relationship between Qt and KDE, only with reversed history order. >Maybe call the file enlightenment.scm? I believe efl.scm is more accurate as the packages there would be EFL based but not necessarily Enlightenment related. --p4qYPpj5QlsIQJ0K Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlTvACMACgkQ37XrCapiVCO3UgCeJMY9w4KFBaLnJVUkkhBOXNQU yTgAnjeoVYvh4eoBl8WwJr++xb1F8S/f =vhe0 -----END PGP SIGNATURE----- --p4qYPpj5QlsIQJ0K--