From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH]: add freepats and timidity
Date: Thu, 19 Feb 2015 21:03:20 +0100
Message-ID: <20150219200320.GA7712@debian>
References: <87h9uhlpig.fsf@mango.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43000)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YOXJu-0000DQ-W7
	for guix-devel@gnu.org; Thu, 19 Feb 2015 15:03:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YOXJr-00078u-4Y
	for guix-devel@gnu.org; Thu, 19 Feb 2015 15:03:34 -0500
Received: from mout.kundenserver.de ([212.227.17.24]:60387)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YOXJq-00078a-S3
	for guix-devel@gnu.org; Thu, 19 Feb 2015 15:03:31 -0500
Content-Disposition: inline
In-Reply-To: <87h9uhlpig.fsf@mango.localdomain>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Ricardo Wurmus <rekado@elephly.net>
Cc: Guix-devel <guix-devel@gnu.org>

Hi again,

thanks a lot for the two packages, they work for me. Nevertheless two
comments.

On Thu, Feb 19, 2015 at 07:33:59PM +0100, Ricardo Wurmus wrote:
> +(define-public timidity++
> +  (package
> +    (name "timidity++")

Back to names... I would call this "timidity". The package guidelines only
state that underscores are replaced by "-", but the general idea would be
to replace special characters with dashes, and to rather drop them at the end
(or beginning) of a package name.

> +          (let ((out (string-append (assoc-ref %outputs "out")
> +                                    "/share/timidity")))
> +            (mkdir-p out)
> +            (call-with-output-file
> +                (string-append out "/timidity.cfg")

It is a bit strange to have config files in /share and not in /etc, but that
is indeed where by default timidity looks for its config file. Nevertheless,
I would use
  (string-append (assoc-ref %outputs "out") "/etc/timidity")
and then add the configure flag
  (string-append "--with-default-path=" (assoc-ref %outputs "out") "/etc/timidity")

Andreas