From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: [PATCH] gnu: Add gnugo.
Date: Thu, 19 Feb 2015 20:37:57 +0100
Message-ID: <20150219193757.GA26929@debian>
References: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37456)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YOWvJ-0002q0-2x
	for guix-devel@gnu.org; Thu, 19 Feb 2015 14:38:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YOWvD-0004iB-SH
	for guix-devel@gnu.org; Thu, 19 Feb 2015 14:38:09 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:55815)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1YOWvD-0004hz-IV
	for guix-devel@gnu.org; Thu, 19 Feb 2015 14:38:03 -0500
Content-Disposition: inline
In-Reply-To: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: David Hashe <david.hashe@dhashe.com>
Cc: guix-devel@gnu.org

Hello,

thanks, and congratulations for your first (I think) package!

Alex Kost has already made a few comments, so I will just add what I found.
I compiled the package successfully, but did not try the binary.

On Thu, Feb 19, 2015 at 07:57:21AM -0600, David Hashe wrote:
> +++ b/gnu/packages/gnugo.scm

How about adding the package into the games.scm module?

> +  #:use-module (gnu packages texinfo))
> +              ("texinfo", texinfo)))

This is not needed, I think.

The package contains a number of perl, python and pike scripts. They are
not installed, but maybe used during "make check"? (I wonder because some
of them are in the "regression" directory.) In that case, you should add
the perl and python interpreters as native-inputs (since they would be
executed during package building).

Could you please send an updated patch taking our comments into account?

Thanks!

Andreas