unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andreas Enge <andreas@enge.fr>
To: David Hashe <david.hashe@dhashe.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add gnugo.
Date: Thu, 19 Feb 2015 20:37:57 +0100	[thread overview]
Message-ID: <20150219193757.GA26929@debian> (raw)
In-Reply-To: <1424354241-31310-1-git-send-email-david.hashe@dhashe.com>

Hello,

thanks, and congratulations for your first (I think) package!

Alex Kost has already made a few comments, so I will just add what I found.
I compiled the package successfully, but did not try the binary.

On Thu, Feb 19, 2015 at 07:57:21AM -0600, David Hashe wrote:
> +++ b/gnu/packages/gnugo.scm

How about adding the package into the games.scm module?

> +  #:use-module (gnu packages texinfo))
> +              ("texinfo", texinfo)))

This is not needed, I think.

The package contains a number of perl, python and pike scripts. They are
not installed, but maybe used during "make check"? (I wonder because some
of them are in the "regression" directory.) In that case, you should add
the perl and python interpreters as native-inputs (since they would be
executed during package building).

Could you please send an updated patch taking our comments into account?

Thanks!

Andreas

  parent reply	other threads:[~2015-02-19 19:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-19 13:57 [PATCH] gnu: Add gnugo David Hashe
2015-02-19 17:04 ` Alex Kost
2015-02-19 19:37 ` Andreas Enge [this message]
2015-02-19 23:39 ` Mark H Weaver
     [not found]   ` <1424393853.31280.12.camel@Octavian>
2015-02-20  4:15     ` Mark H Weaver
2015-02-20  4:17   ` David Hashe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150219193757.GA26929@debian \
    --to=andreas@enge.fr \
    --cc=david.hashe@dhashe.com \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).