Add hexchat

Add hexchat

[Julien Lepiller]

[-- Attachment #1: Type: text/plain, Size: 77 bytes --]

Hello,

here is the patch for hexchat I was asked to write.

Julien Lepiller.

[-- Attachment #2: 0001-gnu-Add-hexchat.patch --]
[-- Type: application/octet-stream, Size: 2579 bytes --]

From 2607a59685392eb669e6bbec80924933ae0ce390 Mon Sep 17 00:00:00 2001
From: Julien Lepiller <julien@lepiller.eu>
Date: Fri, 21 Nov 2014 18:39:39 +0100
Subject: [PATCH] gnu: Add hexchat.

* gnu/packages/messaging.scm (hexchat): New variable.
---
 gnu/packages/messaging.scm | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 7e2056c..fccf6af 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -23,6 +23,12 @@
   #:use-module (guix download)
   #:use-module (guix build-system gnu)
   #:use-module (gnu packages)
+  #:use-module (gnu packages enchant)
+  #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gtk)
+  #:use-module (gnu packages libcanberra)
+  #:use-module (gnu packages openssl)
+  #:use-module (gnu packages xml)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages glib)
@@ -118,4 +124,37 @@ identi.ca and status.net).")
     (home-page "http://www.bitlbee.org/")
     (license (list gpl2+ bsd-2))))
 
+(define-public hexchat
+  (package
+    (name "hexchat")
+    (version "2.10.1")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://dl.hexchat.net/hexchat/hexchat-" version ".tar.xz"))
+              (sha256
+               (base32 "1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))
+    (build-system gnu-build-system)
+    (native-inputs `(("pkg-config" ,pkg-config)
+              ("intltool" ,intltool)))
+    (inputs `(("dbus-glib" ,dbus-glib)
+              ("dbus" ,dbus)
+              ("enchant" ,enchant)
+              ("glib:bin" ,glib "bin") ;; need glib-genmarshal
+              ("gtk" ,gtk+-2)
+              ("libcanberra" ,libcanberra)
+              ("libnotify" ,libnotify)
+              ("openssl" ,openssl)
+              ("perl-xml-parser" ,perl-xml-parser) ;; for addons
+              ("python-2" ,python-2))) ;; for addons
+    (synopsis "Graphical IRC Client")
+    (description
+     "HexChat lets you connect to multiple IRC networks at once.  The main window
+shows the list of currently connected networks and their channels, the current
+conversation and the list of users.  It uses colors to differentiate between
+users and to highlight messages.  It checks spelling using available
+dictionaries.  HexChat can be extended with multiple addons.")
+    (home-page "http://hexchat.net/")
+    (license gpl2+)))
+
 ;;; messaging.scm ends here
-- 
2.1.2

Re: Add hexchat

[Andreas Enge]

On Fri, Nov 21, 2014 at 06:44:34PM +0100, Julien Lepiller wrote:
> here is the patch for hexchat I was asked to write.

This looks very clean, thank you! A few minor comments:

+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://dl.hexchat.net/hexchat/hexchat-" version ".tar.xz"))
+              (sha256
+               (base32 "1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))

This goes a bit beyond the 80 columns limit (as many other packages, in fact).
I think we should indent them rather like this:
    (source
      (origin
        (method url-fetch)
          (uri (string-append
                "https://dl.hexchat.net/hexchat/hexchat-" version ".tar.xz"))
          (sha256
            (base32 "1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))
Did I get it right (by hand, without emacs)?

+    (native-inputs `(("pkg-config" ,pkg-config)
+              ("intltool" ,intltool)))

This should be alined like this:
+    (native-inputs `(("pkg-config" ,pkg-config)
+                     ("intltool" ,intltool)))
Or with the literal list starting on the line following "native-inputs".

Andreas

Re: Add hexchat

[Ludovic Courtès]

Julien Lepiller <julien@lepiller.eu> skribis:

> here is the patch for hexchat I was asked to write.

s/asked/invited/  ;-)

> From 2607a59685392eb669e6bbec80924933ae0ce390 Mon Sep 17 00:00:00 2001
> From: Julien Lepiller <julien@lepiller.eu>
> Date: Fri, 21 Nov 2014 18:39:39 +0100
> Subject: [PATCH] gnu: Add hexchat.
>
> * gnu/packages/messaging.scm (hexchat): New variable.

Applied, along with formatting changes like Andreas suggested (see other
files for examples, the “Coding Style” part of ‘HACKING’, or use
‘indent-region’ in Emacs), and a copyright line for you.

Thanks!

Ludo’.