From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andreas Enge <andreas@enge.fr>
Subject: Re: Add hexchat
Date: Fri, 21 Nov 2014 18:52:59 +0100
Message-ID: <20141121175259.GA15607@debian>
References: <20141121184434.5d531599@lepiller.eu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1XrsOU-0004Hu-UC
	for guix-devel@gnu.org; Fri, 21 Nov 2014 12:53:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1XrsOO-0005rt-LT
	for guix-devel@gnu.org; Fri, 21 Nov 2014 12:53:18 -0500
Received: from mout.kundenserver.de ([212.227.126.131]:54393)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas@enge.fr>) id 1XrsOO-0005rf-C1
	for guix-devel@gnu.org; Fri, 21 Nov 2014 12:53:12 -0500
Content-Disposition: inline
In-Reply-To: <20141121184434.5d531599@lepiller.eu>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Julien Lepiller <julien@lepiller.eu>
Cc: guix-devel@gnu.org

On Fri, Nov 21, 2014 at 06:44:34PM +0100, Julien Lepiller wrote:
> here is the patch for hexchat I was asked to write.

This looks very clean, thank you! A few minor comments:

+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://dl.hexchat.net/hexchat/hexchat-" version ".tar.xz"))
+              (sha256
+               (base32 "1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))

This goes a bit beyond the 80 columns limit (as many other packages, in fact).
I think we should indent them rather like this:
    (source
      (origin
        (method url-fetch)
          (uri (string-append
                "https://dl.hexchat.net/hexchat/hexchat-" version ".tar.xz"))
          (sha256
            (base32 "1ag9rmfisv0hsbk05jq4f1rnap7kwg90vgbmkr9zklkh6imfxk7z"))))
Did I get it right (by hand, without emacs)?

+    (native-inputs `(("pkg-config" ,pkg-config)
+              ("intltool" ,intltool)))

This should be alined like this:
+    (native-inputs `(("pkg-config" ,pkg-config)
+                     ("intltool" ,intltool)))
Or with the literal list starting on the line following "native-inputs".

Andreas