Acl

Acl

[Andreas Enge]

Adding optional inputs to kdelibs, I notice that acl is not recognised.
The reason is that the header files are not installed. Would that be easy
to modify? Maybe by changing the line
  (zero? (system* "make" "install" "install-lib")))
to
  (zero? (system* "make" "install")))
or not replacing the normal install phase (but then there may be a
reason for this special command!).

Concerning the acl test failures, I tried
 #:tests? #t
and found that there is no "check" target. A good reason for the
tests to fail...

Andreas

Re: Acl

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> Adding optional inputs to kdelibs, I notice that acl is not recognised.
> The reason is that the header files are not installed. Would that be easy
> to modify? Maybe by changing the line
>   (zero? (system* "make" "install" "install-lib")))

Commit 16755848 added ‘install-lib’ (before that libacl.so was not
installed), but yeah, installing headers would have been cool too.  ;-)

> to
>   (zero? (system* "make" "install")))
> or not replacing the normal install phase (but then there may be a
> reason for this special command!).

ISTR that the ‘install’ target installs only the executables.

> Concerning the acl test failures, I tried
>  #:tests? #t
> and found that there is no "check" target. A good reason for the
> tests to fail...

Heh.

Anyway, this is depended on by Coreutils, so changes should go to
core-updates.

In the meantime, you can always add a fixed version of ACL for use in
KDE (you could even add a ‘replacement’ field pointing to it in ‘acl’
itself, although that doesn’t seem like a very good use case.)

Thanks for looking into it!

Ludo’.

Re: Acl

[Andreas Enge]

On Wed, Nov 05, 2014 at 09:38:32PM +0100, Ludovic Courtès wrote:
> Commit 16755848 added ‘install-lib’ (before that libacl.so was not
> installed)

Ah, nothing stops the progress!

Just to make sure that I understand things correctly: Can we drop the
'patch-makefile-SHELL phase? There is no occurrence of the string "SHELL"
in include/buildmacros for the current version.

> Anyway, this is depended on by Coreutils, so changes should go to
> core-updates.

Okay. Should we open the branch?

> In the meantime, you can always add a fixed version of ACL for use in
> KDE (you could even add a ‘replacement’ field pointing to it in ‘acl’
> itself, although that doesn’t seem like a very good use case.)

Well, acl is optional, so there is no hurry.

Andreas

Re: Acl

[Andreas Enge]

[-- Attachment #1: Type: text/plain, Size: 48 bytes --]

The attached patch should do the job.

Andreas


[-- Attachment #2: 0001-gnu-acl-Also-install-header-files.patch --]
[-- Type: text/plain, Size: 1437 bytes --]

From 34f1cd18d14a0a75d73e7f4b57f76495edae56d8 Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Thu, 6 Nov 2014 22:56:32 +0100
Subject: [PATCH] gnu: acl: Also install header files.

* gnu/packages/acl.scm (acl): Install header files. Drop unneeded phase
    PATCH-MAKEFILE-SHELL.
---
 gnu/packages/acl.scm | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index cbe14c9..ee101da 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2012 Nikita Karetnikov <nikita@karetnikov.org>
 ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2014 Andreas Enge <andreas@enge.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -42,15 +43,11 @@
     (arguments
      `(#:tests? #f   ; FIXME: Investigate test suite failures
        #:phases
-       (alist-cons-after
-        'configure 'patch-makefile-SHELL
-        (lambda _
-          (patch-makefile-SHELL "include/buildmacros"))
         (alist-replace
          'install
          (lambda _
-           (zero? (system* "make" "install" "install-lib")))
-         %standard-phases))))
+           (zero? (system* "make" "install" "install-lib" "install-dev")))
+         %standard-phases)))
     (inputs `(("attr" ,attr)))
     (native-inputs
      `(("gettext" ,gnu-gettext)))
-- 
2.1.2

Re: Acl

[Ludovic Courtès]

Andreas Enge <andreas@enge.fr> skribis:

> From 34f1cd18d14a0a75d73e7f4b57f76495edae56d8 Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Thu, 6 Nov 2014 22:56:32 +0100
> Subject: [PATCH] gnu: acl: Also install header files.
>
> * gnu/packages/acl.scm (acl): Install header files. Drop unneeded phase
>     PATCH-MAKEFILE-SHELL.

OK.  Could you create the ‘core-updates’ branch and commit it?

Thanks!

Ludo’.

Re: Acl

[Andreas Enge]

On Fri, Nov 07, 2014 at 10:15:12AM +0100, Ludovic Courtès wrote:
> OK.  Could you create the ‘core-updates’ branch and commit it?

Done. I have also worked a bit on tests and got them to execute at least.

Now a few of the first ones fail like this:
[16] $ ls -dl d | awk '{print $1}' | sed 's/.$//g' -- failed
drwxr-xr-                             != drwxr-xr-t
[18] $ ls -dl d/u | awk '{print $1}' | sed 's/.$//g' -- failed
-rwSr--r-                             != -rwSr--r--
[20] $ ls -dl d/g | awk '{print $1}' | sed 's/.$//g' -- failed
-rw-r-Sr-                             != -rw-r-Sr--

It looks as if "ls -dl" were expected to output one character more than
it does. The tests also fail outside of guix. When I drop the "sed ...",
these tests pass, but then others fail.

Andreas

Re: Acl

[Mark H Weaver]

ludo@gnu.org (Ludovic Courtès) writes:

> ndreas Enge <andreas@enge.fr> skribis:
>
>> Adding optional inputs to kdelibs, I notice that acl is not recognised.
>> The reason is that the header files are not installed. Would that be easy
>> to modify? Maybe by changing the line
>>   (zero? (system* "make" "install" "install-lib")))
>
> Commit 16755848 added ‘install-lib’ (before that libacl.so was not
> installed), but yeah, installing headers would have been cool too.  ;-)

Indeed.  I would apologize for overlooking this, but doc/INSTALL
specifically recommends "make install install-lib", and "install-dev"
appears to be completely undocumented :-/

      Mark