From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pjotr Prins Subject: Re: [PATCH] gnu: Add ruby 1.8.7 Date: Mon, 27 Oct 2014 02:56:50 +0100 Message-ID: <20141027015650.GB21971@thebird.nl> References: <20141026203111.GA20849@thebird.nl> <87wq7mpfs0.fsf@yeeloong.lan> <20141026234436.GA21721@thebird.nl> <87siiap9s5.fsf@yeeloong.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:58809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XiZYd-0006Ud-QD for guix-devel@gnu.org; Sun, 26 Oct 2014 21:57:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XiZYY-0007jl-VK for guix-devel@gnu.org; Sun, 26 Oct 2014 21:57:19 -0400 Content-Disposition: inline In-Reply-To: <87siiap9s5.fsf@yeeloong.lan> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org On Sun, Oct 26, 2014 at 09:43:22PM -0400, Mark H Weaver wrote: > In broad strokes, we use the GNU changelog conventions: > > http://www.gnu.org/prep/standards/html_node/Change-Logs.html > > but with some minor formatting differences. However, the best thing is > to look in the commit history for examples close to what you're doing. > > There is brief mention of this in the "Submitting Patches" section of > the HACKING file in the source tree. I read those earlier. I used a commit message we used before. I think that if you are serious about convention you should point to a real list of allowed standard messages. Now it looks arbitrary and makes the submitter look stupid. > >> It looks like the 'native-search-paths' field needs to be overridden, > >> since the existing one has "2.1.3" in it. > > > > I don't think it is used by 1.8.7. Does that matter? > > Yes, otherwise users who install ruby 1.8.7 will be advised to set > GEM_PATH to $HOME/.guix-profile/lib/ruby/gems/2.1.3. Ah, that is what it is for. Actually the build did not give me that message. I DO get a load of messages such as strip:/gnu/store/icz59y35qqmm4jcrnkqx7d73xlzsq0lq-ruby-1.8.7-p374/lib/ruby/1.8/rexml/attlistdecl.rb: File format not recognized is there a way to prevent files with a .rb extension or ruby shebang to be stripped? Pj.