From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Denhardt Subject: Re: [PATCH 1/1] Factor out a common pattern into a procedure. Date: Sun, 19 Oct 2014 17:12:17 -0400 Message-ID: <20141019211217.13660.44512@vulcan.local.tld> References: <168a3c777e9011635e3a99fb042253e4d0ca324a.1413685080.git.ian@zenhack.net> <20141019074036.GA4382@jocasta.intra> <20141019181507.618.67316@rook.local.tld> <8738ajyfim.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="pgp-sha1"; boundary="===============3865071831921992018==" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45418) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XfxmN-0007zl-Jr for guix-devel@gnu.org; Sun, 19 Oct 2014 17:12:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XfxmI-0004H6-Bq for guix-devel@gnu.org; Sun, 19 Oct 2014 17:12:43 -0400 Content-Disposition: inline In-Reply-To: <8738ajyfim.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --===============3865071831921992018== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Quoting Ludovic Court=C3=A8s (2014-10-19 16:24:17) > Ian Denhardt skribis: > = > > How about this: separate it out into to functions: version-prefix, which > > is the same as what I have now, but takes a (mandatory) argument > > specifying the number of fields, and feature-version, which is defined > > like: > > > > (define (feature-version version) (version-prefix version 2)) > > > > ..with an appropriate docstring explaining the use case. Thoughts? > = > Sounds good to me, although I=E2=80=99d rather call =E2=80=98feature-vers= ion=E2=80=99, say, > =E2=80=98version-major+minor=E2=80=99, on the grounds that the semantics = of version > numbers are specific to each project. Mark? Sounds good to me; I'll update the patch soon. -Ian --===============3865071831921992018== MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Description: signature Content-Type: application/pgp-signature; name="signature.asc"; charset="us-ascii" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIbBAABAgAGBQJURCkxAAoJEPZUuMfUyjy4LOQP9RGXlXn9Mb7QwKq7mH6qRvXG FnKjomDzYsEMcOWv4URWui0BD78M9rwo9rnPg+EDiDjCffgd4Wgl+3zq0+u4VLUF GSLyj2KcjJSMQBLPV2/pKep/GrpkeYYvUi2estbdLda/MvIXEIARXk7MCAcrhucb fw+GiP0YWOqX5mod2vMrxPyY/nG+KP9OTbdZp7lsX59yNNrDljrmvsM56ODlOFfe CcA3eHhN2lZGLWHvKbzANcGiiC0a60XZjnabZGAl1Ms5cTNdXvjVKcYttNHaN35r YfBP/cDRJdiJoSIIIAThQkG/gQzNSHctwCNck8eXBcG0XxglLy+WlOu8NUrIqkRn kWw0AlelSFfwseiy3raseITq3X5HLnfnPI+ZRSSlFfwbdiCoCca66hljhp6h6LVo uhGO97QweavQ2P5A/+s21QMaNYT6d2fXkaKnLhelvXJrmJ71kAblcZgJWRGcebaR SvY9DADRwnqMtLokqzXDvOijpf6TZq0JryzIYkUTTz7A2npYbi1SYgGL8GyZFYyz 6t5oaVTaFULnapQ9/4DhDcex8t5El6KYsrXdI5VKV+E+oreBE7V9X310HMPPytrp iug1tXShqnPx6arz2+qNyvJWS+9MwVYQATLlXwpH9xL+HvC0NX+tUoUvWEWJmYHQ JQJ2P419GWbf86iB1Bo= =lCnP -----END PGP SIGNATURE----- --===============3865071831921992018==--