From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 6/6] gnu: Tinyproxy: Cleanup xml dependencies Date: Tue, 15 Jul 2014 23:11:21 +0200 Message-ID: <20140715211120.GA16482@jocasta.intra> References: <1405449096-29230-1-git-send-email-jmd@gnu.org> <1405449096-29230-6-git-send-email-jmd@gnu.org> <87mwcal4ls.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X7A0g-0006KN-9h for guix-devel@gnu.org; Tue, 15 Jul 2014 17:11:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X7A0c-0007F6-4E for guix-devel@gnu.org; Tue, 15 Jul 2014 17:11:38 -0400 Content-Disposition: inline In-Reply-To: <87mwcal4ls.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic Court??s Cc: guix-devel@gnu.org, John Darrington --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 15, 2014 at 11:00:31PM +0200, Ludovic Court??s wrote: John Darrington skribis: =20 > * gnu/packages/web.scm (tinyproxy): Use the xml_catalog from docbook= instead of > generating a temporary one. =20 Limit lines to 80 chars please. By my count, that is exactly 78 characters. =20 Also, ???Use the XML catalog??? no? =20 > + (setenv "XML_CATALOG_FILES"=20 > + (string-append > + (assoc-ref inputs "docbook-xsl") "/xml/xsl/docbo= ok-xsl-1.78.1/catalog.xml" > + " " ; This must be a space, not a : (contrary t= o the documentation) > + (assoc-ref inputs "docbook-xml") "/xml/dtd/docbo= ok/catalog.xml"))) =20 Line length. =20 OK to push with this fixed. =20 Ludo???. =20 --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlPFmPgACgkQimdxnC3oJ7OSoACfV8qInDfDRxeznklBvDQzUjXK lZgAoIYlPSR+QH0dh7fF0VXsqjBNO2eD =TVhl -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--