From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: gnome-doc-utils: Do not omit tests Date: Mon, 23 Jun 2014 06:44:45 +0200 Message-ID: <20140623044444.GA19164@jocasta.intra> References: <1403422253-9505-1-git-send-email-jmd@gnu.org> <87egygd973.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="LZvS9be/3tNcYl/X" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wyw7t-0006IV-B0 for guix-devel@gnu.org; Mon, 23 Jun 2014 00:45:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wyw7p-0001dZ-7G for guix-devel@gnu.org; Mon, 23 Jun 2014 00:45:05 -0400 Content-Disposition: inline In-Reply-To: <87egygd973.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Ludovic Court??s Cc: guix-devel@gnu.org, John Darrington --LZvS9be/3tNcYl/X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jun 22, 2014 at 09:40:32PM +0200, Ludovic Court??s wrote: =20 John Darrington skribis: =20 > * gnu/packages/gnome.scm (gnome-doc-utils): Added pre-check phase an= d do not > skip check phase =20 [...] =20 > + ;; This stuff is needed, because without it, xmlint etc t= ries > + ;; to download docbookx.dtd and docbook.xsl from the net > + (let ((build (assoc-ref %standard-phases 'build)) > + (docbook-xml (assoc-ref inputs "docbook-xml")) > + (docbook-xsl (assoc-ref inputs "docbook-xsl")) > + (our-catalog "/tmp/docbook-xml.xml")) > + (setenv "XML_CATALOG_FILES" our-catalog) > + (with-output-to-file our-catalog > + (lambda () > + (display (string-append > + " > + +\"file:///usr/share/xml/schema/xml-core/catalog.dtd\"> > + > + +uri=3D\"file://" docbook-xml "/xml/dtd/docbook/docbookx.dtd\"/> > + +uri=3D\"file://" docbook-xsl "/xml/xsl/docbook-xsl-1.72.0/manpages= /docbook.xsl\"/> > +\n")))))) > + %standard-phases))) =20 Seems about time to discuss factorization. :-) =20 Docbook-{XML,XSL} both provide a catalog.xml file. Would it be enough to set XML_CATALOG_FILES=3D/first/one/catalog.xml:/second/one/catalog.= xml rather than creating a new catalog.xml file that just points to them? =20 The problem is, that some files refer to=20 http://www.oasis-open.org/docbook/xml/4.4/docbookx.dtd others to=20 http://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd or http://www.oasis-open.org/docbook/xml/4.2.1/docbookx.dtd Similarly, I have seen urls like http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl http://docbook.sourceforge.net/release/xsl/1.72/manpages/docbook.xsl and other variations. The purpose of the catalog file as I understand it, is to provide a map =66rom these urls to files on the local system. If a url does not have a m= apping, then it will attempt to download from the wild. Now so far, we have got away with a n:1 mapping of ALL the dtd urls to a si= ngle=20 target regardless of version, and likewise with the xsl. However this ap= proach is likely to bite us sometime. So I suppose the "correct" thing to do is to maintain a local archive of al= l the files, including previous versions from oasis-open.org / sourceforge.net =20 =20 --=20 PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --LZvS9be/3tNcYl/X Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlOnsLwACgkQimdxnC3oJ7OlzQCcD3OViQoorh+bkwm1x3XHtTsZ pkYAn1Xp+vOeglwtzrvL3GgPz8lSe9cE =biP5 -----END PGP SIGNATURE----- --LZvS9be/3tNcYl/X--