From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch Date: Wed, 28 May 2014 13:17:28 +0200 Message-ID: <20140528111728.GA21965@jocasta.intra> References: <1401261536-15414-1-git-send-email-jmd@gnu.org> <8738fugr93.fsf@gnu.org> <20140528111258.GA21687@jocasta.intra> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WpbrY-00005E-5W for guix-devel@gnu.org; Wed, 28 May 2014 07:17:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WpbrT-00011p-MI for guix-devel@gnu.org; Wed, 28 May 2014 07:17:40 -0400 Content-Disposition: inline In-Reply-To: <20140528111258.GA21687@jocasta.intra> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: John Darrington Cc: guix-devel@gnu.org, John Darrington On Wed, May 28, 2014 at 01:12:59PM +0200, John Darrington wrote: On Wed, May 28, 2014 at 11:57:28AM +0200, Ludovic Court??s wrote: Hi John, Could you make it two separate patches? Why is the patch no longer needed? The patch is no longer needed because of the new dependency. I guess I could make it two changes, but in my opinion, they belong together. BTW. Both of your questions are a good example of why I believe the *reason* for a change is far more useful in a commit message, than the details of what has changed (which is redundant anyway, since it could be seen by running "git diff"). J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key.