From: John Darrington <john@darrington.wattle.id.au>
To: John Darrington <john@darrington.wattle.id.au>
Cc: guix-devel@gnu.org, John Darrington <jmd@gnu.org>
Subject: Re: [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch
Date: Wed, 28 May 2014 13:17:28 +0200 [thread overview]
Message-ID: <20140528111728.GA21965@jocasta.intra> (raw)
In-Reply-To: <20140528111258.GA21687@jocasta.intra>
On Wed, May 28, 2014 at 01:12:59PM +0200, John Darrington wrote:
On Wed, May 28, 2014 at 11:57:28AM +0200, Ludovic Court??s wrote:
Hi John,
Could you make it two separate patches? Why is the patch no longer
needed?
The patch is no longer needed because of the new dependency. I guess I could
make it two changes, but in my opinion, they belong together.
BTW. Both of your questions are a good example of why I believe the *reason*
for a change is far more useful in a commit message, than the details
of what has changed (which is redundant anyway, since it could be seen by
running "git diff").
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
next prev parent reply other threads:[~2014-05-28 11:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-28 7:18 [PATCH] gnu: Make gtk-glext depend on pangox-compat and remove workaround patch John Darrington
2014-05-28 9:57 ` Ludovic Courtès
2014-05-28 11:12 ` John Darrington
2014-05-28 11:17 ` John Darrington [this message]
2014-05-28 13:20 ` Ludovic Courtès
2014-05-28 13:18 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140528111728.GA21965@jocasta.intra \
--to=john@darrington.wattle.id.au \
--cc=guix-devel@gnu.org \
--cc=jmd@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).